Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117192/?format=api
{ "id": 117192, "url": "http://patches.dpdk.org/api/patches/117192/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-18-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220930072220.20753-18-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220930072220.20753-18-liudongdong3@huawei.com", "date": "2022-09-30T07:22:18", "name": "[17/19] net/hns3: revert fix mailbox communication with HW", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f5f894cb60b813cb9cb7ac8fcfe4b0b4cc441682", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-18-liudongdong3@huawei.com/mbox/", "series": [ { "id": 24928, "url": "http://patches.dpdk.org/api/series/24928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24928", "date": "2022-09-30T07:22:03", "name": "some bugfixes and clean code for hns3 - part2", "version": 1, "mbox": "http://patches.dpdk.org/series/24928/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117192/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/117192/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 23E42A034C;\n\tFri, 30 Sep 2022 09:25:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D03FE42BD7;\n\tFri, 30 Sep 2022 09:24:27 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id AF19642B84;\n Fri, 30 Sep 2022 09:24:22 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Mf1pN458kzVhkP;\n Fri, 30 Sep 2022 15:20:12 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Fri, 30 Sep 2022 15:24:20 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>, <ferruh.yigit@amd.com>,\n <thomas@monjalon.net>", "CC": "<stable@dpdk.org>, <fengchengwen@huawei.com>, <yisen.zhuang@huawei.com>,\n <liudongdong3@huawei.com>, <lihuisong@huawei.com>, <haijie1@huawei.com>", "Subject": "[PATCH 17/19] net/hns3: revert fix mailbox communication with HW", "Date": "Fri, 30 Sep 2022 15:22:18 +0800", "Message-ID": "<20220930072220.20753-18-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220930072220.20753-1-liudongdong3@huawei.com>", "References": "<20220930072220.20753-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nVF's command receive queue was mainly used to receive mailbox messages\nfrom PF. There are two type mailbox messages: request response message\nand message pushed by PF.\n\nThere are two types of threads that can handle these messages:\n1) the interrupt thread of the main process: it could handle both types\nof messages.\n2) other threads: it could only handle request response messages.\n\nThe collaboration mechanism between the two type threads is that other\nthreads set the opcode of processed messages to zero so that the\ninterrupt thread of the main process does not process these messages\nagain. Because other threads can only process part of the messages,\nafter the processing is complete, the next-to-use pointer of the\ncommand receive queue should not be updated. Otherwise, some messages\n(e.g. messages pushed by PF) maybe discarded.\n\nUnfortunately, the patch to be reverted updates next-to-use pointer of\nthe command receive queue in other threads context, and this will lead\nto discard some mailbox message.\n\nSo this commit reverts\ncommit 599ef84add7e (\"net/hns3: fix mailbox communication with HW\")\n\nFixes: 599ef84add7e (\"net/hns3: fix mailbox communication with HW\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_mbx.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c\nindex 02028dcd9c..910a16c999 100644\n--- a/drivers/net/hns3/hns3_mbx.c\n+++ b/drivers/net/hns3/hns3_mbx.c\n@@ -436,8 +436,10 @@ hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw)\n \t\tnext_to_use = (next_to_use + 1) % hw->cmq.crq.desc_num;\n \t}\n \n-\tcrq->next_to_use = next_to_use;\n-\thns3_write_dev(hw, HNS3_CMDQ_RX_HEAD_REG, crq->next_to_use);\n+\t/*\n+\t * Note: the crq->next_to_use field should not updated, otherwise,\n+\t * mailbox messages may be discarded.\n+\t */\n }\n \n void\n", "prefixes": [ "17/19" ] }