Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/11718/?format=api
{ "id": 11718, "url": "http://patches.dpdk.org/api/patches/11718/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1458892732-3885-3-git-send-email-yuanhan.liu@linux.intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1458892732-3885-3-git-send-email-yuanhan.liu@linux.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1458892732-3885-3-git-send-email-yuanhan.liu@linux.intel.com", "date": "2016-03-25T07:58:50", "name": "[dpdk-dev,v2,2/4] examples/vhost: remove unnecessary pseudo checksum calc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a1b69683c2f024ad478567daef3d0a0fd0be5885", "submitter": { "id": 307, "url": "http://patches.dpdk.org/api/people/307/?format=api", "name": "Yuanhan Liu", "email": "yuanhan.liu@linux.intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1458892732-3885-3-git-send-email-yuanhan.liu@linux.intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/11718/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/11718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0A4C0532E;\n\tFri, 25 Mar 2016 08:56:23 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 1F1C74CE7\n\tfor <dev@dpdk.org>; Fri, 25 Mar 2016 08:56:19 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga104.fm.intel.com with ESMTP; 25 Mar 2016 00:56:19 -0700", "from yliu-dev.sh.intel.com ([10.239.66.49])\n\tby FMSMGA003.fm.intel.com with ESMTP; 25 Mar 2016 00:56:18 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,389,1455004800\"; d=\"scan'208\";a=\"675414001\"", "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "To": "dev@dpdk.org", "Cc": "huawei.xie@intel.com, Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tKsiadz MarcinX <marcinx.ksiadz@intel.com>,\n\tYuanhan Liu <yuanhan.liu@linux.intel.com>", "Date": "Fri, 25 Mar 2016 15:58:50 +0800", "Message-Id": "<1458892732-3885-3-git-send-email-yuanhan.liu@linux.intel.com>", "X-Mailer": "git-send-email 1.9.0", "In-Reply-To": "<1458892732-3885-1-git-send-email-yuanhan.liu@linux.intel.com>", "References": "<1458885694-31111-1-git-send-email-yuanhan.liu@linux.intel.com>\n\t<1458892732-3885-1-git-send-email-yuanhan.liu@linux.intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/4] examples/vhost: remove unnecessary pseudo\n\tchecksum calc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For checksum offloading only case, the TCP/IP stack would\nhave calculated the pseudo checksum. Therefore, we don't\nneed to re-calculate it again here; remove it.\n\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\n---\n examples/vhost/main.c | 41 ++++++-----------------------------------\n 1 file changed, 6 insertions(+), 35 deletions(-)", "diff": "diff --git a/examples/vhost/main.c b/examples/vhost/main.c\nindex a45cddb..ceabbce 100644\n--- a/examples/vhost/main.c\n+++ b/examples/vhost/main.c\n@@ -52,8 +52,6 @@\n #include <rte_virtio_net.h>\n #include <rte_ip.h>\n #include <rte_tcp.h>\n-#include <rte_udp.h>\n-#include <rte_sctp.h>\n \n #include \"main.h\"\n \n@@ -1161,42 +1159,15 @@ static void virtio_tx_offload(struct rte_mbuf *m)\n \tvoid *l3_hdr;\n \tstruct ipv4_hdr *ipv4_hdr = NULL;\n \tstruct tcp_hdr *tcp_hdr = NULL;\n-\tstruct udp_hdr *udp_hdr = NULL;\n-\tstruct sctp_hdr *sctp_hdr = NULL;\n \tstruct ether_hdr *eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *);\n \n \tl3_hdr = (char *)eth_hdr + m->l2_len;\n \n-\tif (m->tso_segsz != 0) {\n-\t\tipv4_hdr = (struct ipv4_hdr *)l3_hdr;\n-\t\ttcp_hdr = (struct tcp_hdr *)((char *)l3_hdr + m->l3_len);\n-\t\tm->ol_flags |= PKT_TX_IP_CKSUM;\n-\t\tipv4_hdr->hdr_checksum = 0;\n-\t\ttcp_hdr->cksum = get_psd_sum(l3_hdr, m->ol_flags);\n-\t\treturn;\n-\t}\n-\n-\tif (m->ol_flags & PKT_TX_L4_MASK) {\n-\t\tswitch (m->ol_flags & PKT_TX_L4_MASK) {\n-\t\tcase PKT_TX_TCP_CKSUM:\n-\t\t\ttcp_hdr = (struct tcp_hdr *)\n-\t\t\t\t\t((char *)l3_hdr + m->l3_len);\n-\t\t\ttcp_hdr->cksum = get_psd_sum(l3_hdr, m->ol_flags);\n-\t\t\tbreak;\n-\t\tcase PKT_TX_UDP_CKSUM:\n-\t\t\tudp_hdr = (struct udp_hdr *)\n-\t\t\t\t\t((char *)l3_hdr + m->l3_len);\n-\t\t\tudp_hdr->dgram_cksum = get_psd_sum(l3_hdr, m->ol_flags);\n-\t\t\tbreak;\n-\t\tcase PKT_TX_SCTP_CKSUM:\n-\t\t\tsctp_hdr = (struct sctp_hdr *)\n-\t\t\t\t\t((char *)l3_hdr + m->l3_len);\n-\t\t\tsctp_hdr->cksum = 0;\n-\t\t\tbreak;\n-\t\tdefault:\n-\t\t\tbreak;\n-\t\t}\n-\t}\n+\tipv4_hdr = (struct ipv4_hdr *)l3_hdr;\n+\ttcp_hdr = (struct tcp_hdr *)((char *)l3_hdr + m->l3_len);\n+\tm->ol_flags |= PKT_TX_IP_CKSUM;\n+\tipv4_hdr->hdr_checksum = 0;\n+\ttcp_hdr->cksum = get_psd_sum(l3_hdr, m->ol_flags);\n }\n \n /*\n@@ -1265,7 +1236,7 @@ virtio_tx_route(struct vhost_dev *vdev, struct rte_mbuf *m, uint16_t vlan_tag)\n \t\tm->vlan_tci = vlan_tag;\n \t}\n \n-\tif ((m->ol_flags & PKT_TX_L4_MASK) || (m->ol_flags & PKT_TX_TCP_SEG))\n+\tif (m->ol_flags & PKT_TX_TCP_SEG)\n \t\tvirtio_tx_offload(m);\n \n \ttx_q->m_table[len] = m;\n", "prefixes": [ "dpdk-dev", "v2", "2/4" ] }