Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117178/?format=api
{ "id": 117178, "url": "http://patches.dpdk.org/api/patches/117178/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-4-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220930072220.20753-4-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220930072220.20753-4-liudongdong3@huawei.com", "date": "2022-09-30T07:22:04", "name": "[03/19] net/hns3: fix the lock protection of RSS flow rule", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "88d6ff5b334a0f7bfc21dd77f4ae2bc65db38f24", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-4-liudongdong3@huawei.com/mbox/", "series": [ { "id": 24928, "url": "http://patches.dpdk.org/api/series/24928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24928", "date": "2022-09-30T07:22:03", "name": "some bugfixes and clean code for hns3 - part2", "version": 1, "mbox": "http://patches.dpdk.org/series/24928/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117178/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/117178/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C3C41A034C;\n\tFri, 30 Sep 2022 09:24:21 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 48EF842B70;\n\tFri, 30 Sep 2022 09:24:08 +0200 (CEST)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id EA4D040E5A;\n Fri, 30 Sep 2022 09:24:03 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.54])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Mf1nq0K7Cz1P6vy;\n Fri, 30 Sep 2022 15:19:43 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Fri, 30 Sep 2022 15:24:01 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>, <ferruh.yigit@amd.com>,\n <thomas@monjalon.net>", "CC": "<stable@dpdk.org>, <fengchengwen@huawei.com>, <yisen.zhuang@huawei.com>,\n <liudongdong3@huawei.com>, <lihuisong@huawei.com>, <haijie1@huawei.com>", "Subject": "[PATCH 03/19] net/hns3: fix the lock protection of RSS flow rule", "Date": "Fri, 30 Sep 2022 15:22:04 +0800", "Message-ID": "<20220930072220.20753-4-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220930072220.20753-1-liudongdong3@huawei.com>", "References": "<20220930072220.20753-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nRSS flow rules are saved in RSS filter linked list. The linked\nlist is modified by rte_flow API and is used to restore RSS rules\nduring reset process. So this patch uses 'hw->flows_lock' to protect\nthe configuration and recovery of RSS rule.\n\nFixes: c37ca66f2b27 (\"net/hns3: support RSS\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 16 ++++++----------\n 1 file changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex 2fb83f756a..162a48e590 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1596,27 +1596,20 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,\n \t\thns3_warn(hw, \"Config queue numbers %u are beyond the scope of truncated\",\n \t\t\t rss_flow_conf.queue_num);\n \thns3_info(hw, \"Max of contiguous %u PF queues are configured\", num);\n-\n-\trte_spinlock_lock(&hw->lock);\n \tif (num) {\n \t\tret = hns3_update_indir_table(dev, &rss_flow_conf, num);\n \t\tif (ret)\n-\t\t\tgoto rss_config_err;\n+\t\t\treturn ret;\n \t}\n \n \t/* Set hash algorithm and flow types by the user's config */\n \tret = hns3_hw_rss_hash_set(hw, &rss_flow_conf);\n \tif (ret)\n-\t\tgoto rss_config_err;\n+\t\treturn ret;\n \n \tret = hns3_rss_conf_copy(rss_info, &rss_flow_conf);\n-\tif (ret) {\n+\tif (ret)\n \t\thns3_err(hw, \"RSS config init fail(%d)\", ret);\n-\t\tgoto rss_config_err;\n-\t}\n-\n-rss_config_err:\n-\trte_spinlock_unlock(&hw->lock);\n \n \treturn ret;\n }\n@@ -1661,6 +1654,7 @@ hns3_restore_rss_filter(struct rte_eth_dev *dev)\n \tstruct hns3_hw *hw = &hns->hw;\n \tint ret = 0;\n \n+\tpthread_mutex_lock(&hw->flows_lock);\n \tTAILQ_FOREACH(filter, &hw->flow_rss_list, entries) {\n \t\tif (!filter->filter_info.valid)\n \t\t\tcontinue;\n@@ -1673,6 +1667,8 @@ hns3_restore_rss_filter(struct rte_eth_dev *dev)\n \t}\n \n out:\n+\tpthread_mutex_unlock(&hw->flows_lock);\n+\n \treturn ret;\n }\n \n", "prefixes": [ "03/19" ] }