Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117177/?format=api
{ "id": 117177, "url": "http://patches.dpdk.org/api/patches/117177/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-2-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220930072220.20753-2-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220930072220.20753-2-liudongdong3@huawei.com", "date": "2022-09-30T07:22:02", "name": "[01/19] net/hns3: fix have no valid RSS rule", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0d84db23b4628595db502dd81ce1893aa4f7aefa", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-2-liudongdong3@huawei.com/mbox/", "series": [ { "id": 24928, "url": "http://patches.dpdk.org/api/series/24928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24928", "date": "2022-09-30T07:22:03", "name": "some bugfixes and clean code for hns3 - part2", "version": 1, "mbox": "http://patches.dpdk.org/series/24928/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117177/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/117177/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4CE2A034C;\n\tFri, 30 Sep 2022 09:24:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CC04B42905;\n\tFri, 30 Sep 2022 09:24:06 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 8954E410F1;\n Fri, 30 Sep 2022 09:24:03 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.56])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Mf1nn62wBzlVxf;\n Fri, 30 Sep 2022 15:19:41 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Fri, 30 Sep 2022 15:24:00 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>, <ferruh.yigit@amd.com>,\n <thomas@monjalon.net>", "CC": "<stable@dpdk.org>, <fengchengwen@huawei.com>, <yisen.zhuang@huawei.com>,\n <liudongdong3@huawei.com>, <lihuisong@huawei.com>, <haijie1@huawei.com>", "Subject": "[PATCH 01/19] net/hns3: fix have no valid RSS rule", "Date": "Fri, 30 Sep 2022 15:22:02 +0800", "Message-ID": "<20220930072220.20753-2-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220930072220.20753-1-liudongdong3@huawei.com>", "References": "<20220930072220.20753-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThe 'hns3_restore_rss_filter' function is used to restore RSS rule.\nBut this function calls the 'hns3_config_rss_filter' which sets the\nlast to invalid in flow RSS list. This causes the flow RSS list has\nno valid rule.\n\nFixes: ec674cb742e5 (\"net/hns3: fix flushing RSS rule\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 17 +++++++++--------\n 1 file changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex b84f26c26c..4952d807b8 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1539,7 +1539,6 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,\n \t\t const struct hns3_rss_conf *conf, bool add)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n-\tstruct hns3_rss_conf_ele *rss_filter_ptr;\n \tstruct hns3_hw *hw = &hns->hw;\n \tstruct hns3_rss_conf *rss_info;\n \tuint64_t flow_types;\n@@ -1618,13 +1617,6 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,\n \t\tgoto rss_config_err;\n \t}\n \n-\t/*\n-\t * When create a new RSS rule, the old rule will be overlaid and set\n-\t * invalid.\n-\t */\n-\tTAILQ_FOREACH(rss_filter_ptr, &hw->flow_rss_list, entries)\n-\t\trss_filter_ptr->filter_info.valid = false;\n-\n rss_config_err:\n \trte_spinlock_unlock(&hw->lock);\n \n@@ -1749,6 +1741,7 @@ hns3_flow_create_rss_rule(struct rte_eth_dev *dev,\n {\n \tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct hns3_rss_conf_ele *rss_filter_ptr;\n+\tstruct hns3_rss_conf_ele *filter_ptr;\n \tconst struct hns3_rss_conf *rss_conf;\n \tint ret;\n \n@@ -1773,6 +1766,14 @@ hns3_flow_create_rss_rule(struct rte_eth_dev *dev,\n \n \thns3_rss_conf_copy(&rss_filter_ptr->filter_info, &rss_conf->conf);\n \trss_filter_ptr->filter_info.valid = true;\n+\n+\t/*\n+\t * When create a new RSS rule, the old rule will be overlaid and set\n+\t * invalid.\n+\t */\n+\tTAILQ_FOREACH(filter_ptr, &hw->flow_rss_list, entries)\n+\t\tfilter_ptr->filter_info.valid = false;\n+\n \tTAILQ_INSERT_TAIL(&hw->flow_rss_list, rss_filter_ptr, entries);\n \tflow->rule = rss_filter_ptr;\n \tflow->filter_type = RTE_ETH_FILTER_HASH;\n", "prefixes": [ "01/19" ] }