Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117034/?format=api
{ "id": 117034, "url": "http://patches.dpdk.org/api/patches/117034/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220928052516.1279442-13-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220928052516.1279442-13-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220928052516.1279442-13-g.singh@nxp.com", "date": "2022-09-28T05:25:13", "name": "[12/15] net/dpaa: use internal mempool for SG table", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d1096e36b52112fa75aa032925bd72b78bf1a684", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220928052516.1279442-13-g.singh@nxp.com/mbox/", "series": [ { "id": 24872, "url": "http://patches.dpdk.org/api/series/24872/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24872", "date": "2022-09-28T05:25:01", "name": "DPAA and DPAA2 driver changes", "version": 1, "mbox": "http://patches.dpdk.org/series/24872/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117034/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/117034/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4258EA00C2;\n\tWed, 28 Sep 2022 07:27:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 99B5042BB5;\n\tWed, 28 Sep 2022 07:26:01 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-eopbgr60057.outbound.protection.outlook.com [40.107.6.57])\n by mails.dpdk.org (Postfix) with ESMTP id B766F42B99\n for <dev@dpdk.org>; Wed, 28 Sep 2022 07:25:59 +0200 (CEST)", "from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14)\n by PA4PR04MB7504.eurprd04.prod.outlook.com (2603:10a6:102:e6::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Wed, 28 Sep\n 2022 05:25:58 +0000", "from AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::14d0:4458:d6ec:b8b1]) by AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::14d0:4458:d6ec:b8b1%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022\n 05:25:58 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ea8K6qwqJLD0k1m1v3lpGza/AgtyHNgZryLW74oLEnh+qtGtwLJ1rHRYdEdpFaiuNVBqHzpJpBVtKY9190yHPNhpxu9VqIqxJ+85X99j9Si7MeBbOjQpEQyxi2FA7dsIZBcCeXQuDrBxcshfjegUDNk7ELY8AoosstzucQIUC/OQ4IJKOu77AgMIYb2WWxYQMttWOqh5/g+wSWA4UYNlcUT7UGwwl6Uo83jHIeeWRHQzO1Cyu0IJJcDC/KEe1Rr4IAFI+yD3MXo8lA+JRgZNOhuPZqoZ/jtfpFA9xloHYloLJGV61y/GnP11H4TudlKKe9xNpO5FMSSqpuhCiXKuEw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=AA9Xyv18FmPErafiouyr3AWlg/6Fe+owpLFrQeNUHfo=;\n b=NXNX3eYBhTsaaI0PWUkPIAhVzU4KVl4EDUBqGESdeafgrg660+pnNHyzcM4H2mgbQbzLtc2W4P2WZWikGP3ihuBFRsrIc9YaybFfKO05fQUOb5Lo5CEMbYtuPIxgAqVxHjJRul23NsCNJlyrHGEPczcqSzfTE0+os36bCDu7Q5nd4nYHcoJq6PiI46c5uNAF3b2sEK7E0J1J8oFoTxEh8f1v0m9+3K6hfZDXxqLQs7jdEIeImpDArvxiOUTEGjCHP0h0fIZQxROm4iVOgQW00iE+0rSTuW3fAGuAyfLvPkgMLG+EKW36xgXcj9koPs76FmkrbEPvwZN3QLgYHBpY2A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AA9Xyv18FmPErafiouyr3AWlg/6Fe+owpLFrQeNUHfo=;\n b=TGrv68MOWyDYJONpfDRMcoa7HqWJJ4v0s2zwMLGkzQxEl090RaDUR7n3DNNhYDVIDoiS0Bm59VdBqyF34zyL2cjBNRx2lw7P39O2W0j2KWKnrf/eQf99oMXmLrGCh9y2tbFoarxIPsDG/BZfNxNpnHGV8bZfZ5VkiUngL/lRtbI=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;", "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "ferruh.yigit@amd.com,\n\tdev@dpdk.org", "Cc": "Gagandeep Singh <g.singh@nxp.com>", "Subject": "[PATCH 12/15] net/dpaa: use internal mempool for SG table", "Date": "Wed, 28 Sep 2022 10:55:13 +0530", "Message-Id": "<20220928052516.1279442-13-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220928052516.1279442-1-g.singh@nxp.com>", "References": "<20220928052516.1279442-1-g.singh@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SGBP274CA0015.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::27)\n To AS8PR04MB8198.eurprd04.prod.outlook.com\n (2603:10a6:20b:3b0::14)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AS8PR04MB8198:EE_|PA4PR04MB7504:EE_", "X-MS-Office365-Filtering-Correlation-Id": "0fee896b-2478-4a33-4e79-08daa111ecc5", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 5llM3giQ0TT6clB94Dhg+D690T1CK/YUJ2Y9QohRjc3/HFP23XuGZZBOsRJXnq+JkZCJeD/7ws5CBIVE8SKBA5P9MOrUIinnY/EEkj5MKTVCnerU0jkhqikc/gJGjo/jxCDAlk9IwTkP7/V5T/iO8/4OIo0/KofRybugaXcSW0PwZaS9lsvhqYXnPJa0WEmMX3Zhu0OD7qk0KfjI07GAxgUuQtupIR8phwnspmpzh62pKNDgi3pri4t6qcVQv5tpgWHTjY6wXUC7Umn8F5VIaU+Y1AZ5B9HJ1+BmeM2L6NzxoQADchszdQGdv9x4liC95LvtxViYH/pSqNWAK8e9qsUy1VIl8NVRVk7UNopxKAtFwa7OIewabLCDbo52QxaGJ5umrY1Aa1fn1EOT/HvN9/38wKK0R99MCQHJP3DOPX3GJr8tayHVVYck8RJA8Fe9t6P2sXuNmTfUP9QmVPBey6qPo+Ui0bzo5vIK6EklAcjLCrfDBAT3FA0sEBHcBNB5dQGV2XQxh7St4mC6OXNcQ3cHVl3UBqITkxD986c41+JmCEQIjGyIYBzcWjUvXiNphXuOp5qjoE/krPsintSqJl5Ug/HJlkxtIsZeGIRjQ+8z52RmCOTc7Q+EPFP/BcPS3gv5OcJcwLH1if4Rd4n1hGZOIFZDmBWD1BzRnc7Gd8SfaFi3RSe1f5O8zrmQ3r1dtGpV+T6psDo7NWCUpehjjMsYilJNQGCU8IwluCCKKE7tX3hxi0r4MJSu0+v7TLOy7RCIcV9Sj9g2Rq4pwPU/tg==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230022)(4636009)(346002)(366004)(376002)(396003)(136003)(39860400002)(451199015)(1076003)(186003)(2616005)(8676002)(83380400001)(38350700002)(8936002)(6506007)(38100700002)(26005)(86362001)(6512007)(6666004)(2906002)(5660300002)(52116002)(478600001)(66556008)(66476007)(66946007)(316002)(36756003)(41300700001)(4326008)(6486002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n Yi/2YBu7ohVSmmFrTT5QypWiY6B5dFCb/TaaJ+JM/1RS7XnGjOBMeViMRZsBVkMwr67gnsO/6vnbCje6Kc41G9zi/MxLNEo8RtjPByY8hPJG+5fqMVt6DM9VMrXP90uBl4Ow+IMp9WWlY9dT93CNFcpuyHBE5EXdDIyOFko15Lo5iS3jpIUAlou0VDIR79YQ4YCOjs5uJhsTSUR3aO8iLjpEJKp+D4RmeWWz+sPQcuyPNPwjEOMQNvm3HbmBqIdx4AU6HuTg1T9petmEuUcyh9AeC0LW2/S4aemVyRZDrKpDmgpKqonFK/1AxfrLblydswBSvotWa0JDp6hDd4JH/QOMlsrhBB2wOSKDGtFI7oQEuyGZCJABoUyEquBbVRBg0tHXrvNdw4U/3uPz11HQuLMgBppj+W1LZxIEnUr/nXuEcz4AqT3fiZvgvR/RhcnbEtcEhAVrvUvpiByPnc0XwyEfdvs/xIU/4I1JlPzlzuIhxyWN3lcqmtABtVQ2Y2+XHLuk3KkXdrGMzMovM/jgz+r89PwDNopKwWDhtehN98WvfEpuPTUYWkmYHdw6nqk/jr3d2isuIAWv2+43UEk97oyy7eZI8pWjHEVQThJ+zH4BmvZOMnMqYkAZZS+OpDql8WhxRXCqZvxcNnL+VcLi1bB3QY3dK734VszCvcRGcl/Jy2n5AgJmSbUFIIW7cLveNHJsB/KeJx8TwVHiinAoV7qQb/gdNuF8eIE8qjX3+cIfw50xoiMDRnRKdDa5Auqs7wh8Pvw9U4RwczGNiPn7plIEOsb9+dfdkp5ycseB0tCKS5qIX+ERmaGrpQuG+G7HdFWusriLUn/btIx6mmztX5yELFJeh+9TdvYdTSJ4BQFoiVi9ssBK7t4Kg22uFEn8u6G021DuoCTFuEG4Ed8nLau5SJlNCh9REVlRPhNflGrPG/Jmu2XzPL1W0VIwYXoV9T/LHAsdFEIFQUNsC4D5WvFM8/Kv/gVd8m4PKn+ACSsPq7ukGAFtfbC+IC+xmizsNR/+wFCPza1FKsWCEWbUKNW7PKZ2c3VNHjl75uOf7cB0q81LJQBWTROh/sayiJfIj/4dVMz267IwzgE7C9gGk/RvKGB4KCLjxGMHlYa6VwvgqgYteX2wLIReDPCktrhW5QiJjwn59zRLNaWanzpAityGuYanltuTUFi6TvK6mlxTURMxSO3Z7SwuwrIRC6eeNX8tOHF49wPquXfnCjN3QswEU5WHS+KjJcb9Ll9+LrS98EB+4moagYGAEXFXz4nie8yKH6qvWNgCZEHCWHh4WvoL4GuKa4x/bXYq6rFU3vFIuEKtzyplOhjxUDeW4uZEU+YcNWqkS0xAVhWvd+FjP19JlZyikv0+np2D1v5h9bWZhek8LLLj7IiT7TauUvxFThf//2SmTCpteMQJwS13GNYPv2zr4UuA9bpzuNwJlIw2UcQXVKVQ5aQM2yFSR1B9J/3XsR9Rzqg+bRuJ0RzlrU5YETCdeBakXpJlZDQJNMXndfVb9xrCocjJQu9leHgkO/2L9P2Xy1rLAceqiLDUFC/w94R8JcSJAYqrjycFid3maNDhe7BP/4fj6ruBQj2u", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0fee896b-2478-4a33-4e79-08daa111ecc5", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8198.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Sep 2022 05:25:58.8184 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n wpywFujFJNQbKMILbXJrAt2AUy9EyshLT9lAxpAZupS1emMU1d2Sa55kVwsHUQgE", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PA4PR04MB7504", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Creating and using driver's mempool for\nallocating the SG table memory required for\nFD creation.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/net/dpaa/dpaa_ethdev.c | 13 +++++++++++++\n drivers/net/dpaa/dpaa_ethdev.h | 9 +++++++++\n drivers/net/dpaa/dpaa_rxtx.c | 9 ++++-----\n 3 files changed, 26 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex 9b281ba8cb..1e804e1462 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -133,6 +133,7 @@ static const struct rte_dpaa_xstats_name_off dpaa_xstats_strings[] = {\n };\n \n static struct rte_dpaa_driver rte_dpaa_pmd;\n+struct rte_mempool *dpaa_tx_sg_pool;\n \n static int\n dpaa_eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info);\n@@ -2222,6 +2223,18 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,\n \t/* Invoke PMD device initialization function */\n \tdiag = dpaa_dev_init(eth_dev);\n \tif (diag == 0) {\n+\t\tif (!dpaa_tx_sg_pool) {\n+\t\t\tdpaa_tx_sg_pool =\n+\t\t\t\trte_pktmbuf_pool_create(\"dpaa_mbuf_tx_sg_pool\",\n+\t\t\t\tDPAA_POOL_SIZE,\n+\t\t\t\tDPAA_POOL_CACHE_SIZE, 0,\n+\t\t\t\tDPAA_MAX_SGS * sizeof(struct qm_sg_entry),\n+\t\t\t\trte_socket_id());\n+\t\t\tif (dpaa_tx_sg_pool == NULL) {\n+\t\t\t\tDPAA_PMD_ERR(\"SG pool creation failed\\n\");\n+\t\t\t\treturn -ENOMEM;\n+\t\t\t}\n+\t\t}\n \t\trte_eth_dev_probing_finish(eth_dev);\n \t\treturn 0;\n \t}\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h\nindex 6fdd57dbc3..f9c0554530 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.h\n+++ b/drivers/net/dpaa/dpaa_ethdev.h\n@@ -33,6 +33,13 @@\n \n #define DPAA_SGT_MAX_ENTRIES 16 /* maximum number of entries in SG Table */\n \n+/* Maximum SG segments supported on all cores*/\n+#define DPAA_MAX_SGS 128\n+/* SG pool size */\n+#define DPAA_POOL_SIZE 2048\n+/* SG pool cache size */\n+#define DPAA_POOL_CACHE_SIZE 256\n+\n /* RX queue tail drop threshold (CGR Based) in frame count */\n #define CGR_RX_PERFQ_THRESH 256\n #define CGR_TX_CGR_THRESH 512\n@@ -103,6 +110,8 @@\n \n #define FMC_FILE \"/tmp/fmc.bin\"\n \n+extern struct rte_mempool *dpaa_tx_sg_pool;\n+\n /* Each network interface is represented by one of these */\n struct dpaa_if {\n \tint valid;\ndiff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c\nindex 22205cec30..e23206bf5c 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.c\n+++ b/drivers/net/dpaa/dpaa_rxtx.c\n@@ -803,8 +803,7 @@ uint16_t dpaa_eth_queue_rx(void *q,\n \n static int\n dpaa_eth_mbuf_to_sg_fd(struct rte_mbuf *mbuf,\n-\t\tstruct qm_fd *fd,\n-\t\tstruct dpaa_bp_info *bp_info)\n+\t\tstruct qm_fd *fd)\n {\n \tstruct rte_mbuf *cur_seg = mbuf, *prev_seg = NULL;\n \tstruct rte_mbuf *temp, *mi;\n@@ -813,7 +812,7 @@ dpaa_eth_mbuf_to_sg_fd(struct rte_mbuf *mbuf,\n \n \tDPAA_DP_LOG(DEBUG, \"Creating SG FD to transmit\");\n \n-\ttemp = rte_pktmbuf_alloc(bp_info->mp);\n+\ttemp = rte_pktmbuf_alloc(dpaa_tx_sg_pool);\n \tif (!temp) {\n \t\tDPAA_PMD_ERR(\"Failure in allocation of mbuf\");\n \t\treturn -1;\n@@ -849,7 +848,7 @@ dpaa_eth_mbuf_to_sg_fd(struct rte_mbuf *mbuf,\n \tfd->format = QM_FD_SG;\n \tfd->addr = temp->buf_iova;\n \tfd->offset = temp->data_off;\n-\tfd->bpid = bp_info ? bp_info->bpid : 0xff;\n+\tfd->bpid = DPAA_MEMPOOL_TO_BPID(dpaa_tx_sg_pool);\n \tfd->length20 = mbuf->pkt_len;\n \n \twhile (i < DPAA_SGT_MAX_ENTRIES) {\n@@ -967,7 +966,7 @@ tx_on_dpaa_pool(struct rte_mbuf *mbuf,\n \t\ttx_on_dpaa_pool_unsegmented(mbuf, bp_info, fd_arr);\n \t} else if (mbuf->nb_segs > 1 &&\n \t\t mbuf->nb_segs <= DPAA_SGT_MAX_ENTRIES) {\n-\t\tif (dpaa_eth_mbuf_to_sg_fd(mbuf, fd_arr, bp_info)) {\n+\t\tif (dpaa_eth_mbuf_to_sg_fd(mbuf, fd_arr)) {\n \t\t\tDPAA_PMD_DEBUG(\"Unable to create Scatter Gather FD\");\n \t\t\treturn 1;\n \t\t}\n", "prefixes": [ "12/15" ] }