Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116928/?format=api
{ "id": 116928, "url": "http://patches.dpdk.org/api/patches/116928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/8500896f97e47a19106f792193d1b72b3468fc29.1664258174.git.gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<8500896f97e47a19106f792193d1b72b3468fc29.1664258174.git.gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/8500896f97e47a19106f792193d1b72b3468fc29.1664258174.git.gmuthukrishn@marvell.com", "date": "2022-09-27T06:00:37", "name": "[v2,4/7] examples/fips_validation: fix buffer size to parse JSON string", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1d31a5fbeff3bb79c5da6a7858a3c0761c765f8e", "submitter": { "id": 2301, "url": "http://patches.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/8500896f97e47a19106f792193d1b72b3468fc29.1664258174.git.gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 24847, "url": "http://patches.dpdk.org/api/series/24847/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24847", "date": "2022-09-27T06:00:34", "name": "[v2,1/7] examples/fips_validation: fix parsing test group info", "version": 2, "mbox": "http://patches.dpdk.org/series/24847/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116928/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/116928/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A023CA00C2;\n\tTue, 27 Sep 2022 08:01:11 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2A6FD427FF;\n\tTue, 27 Sep 2022 08:00:58 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 18292410D0\n for <dev@dpdk.org>; Tue, 27 Sep 2022 08:00:57 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 28R44xIu016169;\n Mon, 26 Sep 2022 23:00:56 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jt1dp8p8k-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 26 Sep 2022 23:00:56 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 26 Sep 2022 23:00:54 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 26 Sep 2022 23:00:54 -0700", "from localhost.localdomain (unknown [10.28.34.38])\n by maili.marvell.com (Postfix) with ESMTP id BD4C85E6864;\n Mon, 26 Sep 2022 23:00:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=4LEE7wzS5vbBmNVzIoIWhjNjTpOYwNFDVSSE6gJEU4g=;\n b=gEjmr/maltIF5HmEPGwB1gilohaYUGTDkANP8KwA4FW4xaqE2eA1rr2y1b7SDwQnPO7Y\n XWN0LDifQg5fpxwP/4LzotFFmbPYvfiz+L3RX8kb7r95Mq/MUXpGEp9O1Ma4RVNPvkXW\n jWYbbLgluZ1T78prVYl9hWkDAm+bzBuAe+waykY5HcEctDMHvlcXDFa81ZrDnNOX281/\n lnzxycJbu5VWjd2pk6wJtKLhZI7YKC5RbnbbdSpzlA248KDaBwI9f9PeoOrJG2M6QQNC\n mmlEGvcL+NMCTGtCys6B3mjCpb0mXwsP3LOe8oarXWqZiWPnU9Iz2xN77l/d0fB/LGjE Cg==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "Anoob Joseph <anoobj@marvell.com>, Fan Zhang <roy.fan.zhang@intel.com>,\n Brian Dooley <brian.dooley@intel.com>,\n Akhil Goyal <gakhil@marvell.com>, <jerinj@marvell.com>,\n Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "Subject": "[v2 4/7] examples/fips_validation: fix buffer size to parse JSON\n string", "Date": "Tue, 27 Sep 2022 11:30:37 +0530", "Message-ID": "\n <8500896f97e47a19106f792193d1b72b3468fc29.1664258174.git.gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <e7c9578ea6bb9d5c9fba1bb227bf0b815dd76374.1664258174.git.gmuthukrishn@marvell.com>", "References": "\n <e7c9578ea6bb9d5c9fba1bb227bf0b815dd76374.1664258174.git.gmuthukrishn@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "Wl1W3CMdBfmOf9uIxK-uruaU3uS0F6kM", "X-Proofpoint-GUID": "Wl1W3CMdBfmOf9uIxK-uruaU3uS0F6kM", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1\n definitions=2022-09-26_11,2022-09-22_02,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In asym op, while parsing test interim info, existing buffer of size\n256 bytes is not sufficient, hence setting it to maximum that a test\nwould need.\n\nFixes: 58cc98801eb (\"examples/fips_validation: add JSON parsing\")\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\nAcked-by: Brian Dooley <brian.dooley@intel.com>\n---\n examples/fips_validation/fips_validation.c | 7 ++++---\n examples/fips_validation/fips_validation.h | 7 +++++++\n 2 files changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c\nindex e755654cd0..be0634c3ac 100644\n--- a/examples/fips_validation/fips_validation.c\n+++ b/examples/fips_validation/fips_validation.c\n@@ -484,7 +484,7 @@ fips_test_parse_one_json_group(void)\n \tjson_t *param;\n \n \tif (info.interim_callbacks) {\n-\t\tchar json_value[256];\n+\t\tchar json_value[FIPS_TEST_JSON_BUF_LEN];\n \t\tfor (i = 0; info.interim_callbacks[i].key != NULL; i++) {\n \t\t\tparam = json_object_get(json_info.json_test_group,\n \t\t\t\t\tinfo.interim_callbacks[i].key);\n@@ -493,11 +493,12 @@ fips_test_parse_one_json_group(void)\n \n \t\t\tswitch (json_typeof(param)) {\n \t\t\tcase JSON_STRING:\n-\t\t\t\tsnprintf(json_value, 256, \"%s\", json_string_value(param));\n+\t\t\t\tsnprintf(json_value, sizeof(json_value), \"%s\",\n+\t\t\t\t\t\t json_string_value(param));\n \t\t\t\tbreak;\n \n \t\t\tcase JSON_INTEGER:\n-\t\t\t\tsnprintf(json_value, 255, \"%\"JSON_INTEGER_FORMAT,\n+\t\t\t\tsnprintf(json_value, sizeof(json_value), \"%\"JSON_INTEGER_FORMAT,\n \t\t\t\t\t\tjson_integer_value(param));\n \t\t\t\tbreak;\n \ndiff --git a/examples/fips_validation/fips_validation.h b/examples/fips_validation/fips_validation.h\nindex 6e5f2fce75..43e5ffe4b0 100644\n--- a/examples/fips_validation/fips_validation.h\n+++ b/examples/fips_validation/fips_validation.h\n@@ -183,6 +183,13 @@ struct xts_interim_data {\n };\n \n #ifdef USE_JANSSON\n+/*\n+ * Maximum length of buffer to hold any json string.\n+ * Esp, in asym op, modulo bits decide char buffer size.\n+ * max = (modulo / 4)\n+ */\n+#define FIPS_TEST_JSON_BUF_LEN (4096 / 4)\n+\n struct fips_test_json_info {\n \t/* Information used for reading from json */\n \tjson_t *json_root;\n", "prefixes": [ "v2", "4/7" ] }