Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116848/?format=api
{ "id": 116848, "url": "http://patches.dpdk.org/api/patches/116848/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1664175597-37248-8-git-send-email-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1664175597-37248-8-git-send-email-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1664175597-37248-8-git-send-email-chaoyong.he@corigine.com", "date": "2022-09-26T06:59:51", "name": "[v10,07/13] net/nfp: move common rxtx function for flower use", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d4030cfb3369e65c2e15d76afe35533e9143e448", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1664175597-37248-8-git-send-email-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 24819, "url": "http://patches.dpdk.org/api/series/24819/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24819", "date": "2022-09-26T06:59:44", "name": "preparation for the rte_flow offload of nfp PMD", "version": 10, "mbox": "http://patches.dpdk.org/series/24819/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116848/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/116848/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7C9A8A00C2;\n\tMon, 26 Sep 2022 09:01:19 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A084142B80;\n\tMon, 26 Sep 2022 09:00:36 +0200 (CEST)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2130.outbound.protection.outlook.com [40.107.244.130])\n by mails.dpdk.org (Postfix) with ESMTP id BC1C742B75\n for <dev@dpdk.org>; Mon, 26 Sep 2022 09:00:33 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by SA1PR13MB4893.namprd13.prod.outlook.com (2603:10b6:806:18a::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.14; Mon, 26 Sep\n 2022 07:00:32 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::779:2722:a8e5:503b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::779:2722:a8e5:503b%7]) with mapi id 15.20.5676.014; Mon, 26 Sep 2022\n 07:00:32 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=mj6QifDCwpMfIqy/i0TL5I7Hr7+bJ7gXrKpEU1PNztbFH27y+paK321FC/qgzMzW/hZh2WzG75VgzhbpZOKiKUo9sUYUG3B6yAYAIPxDz7ECq2MeEVQugP3L6QGOD8LqoeNPCkc6xygM+M5DJp1hGYK0h0yXSDgnqMfzI1RB9qL8NQRmmSYVMY/jblei2yWCZMAQZMVFRO1CdiPY1fxAfl5auYmyzgnwIbA1IXZ+S7AdjxwVFDdqUXyiQ3NzeIwjWHi5TxOrJ7r6ZYXccTFpDPr+Ug9hysLc6aZyhQmrGtRjMnv5Tq0gy38Xk1KcaNFXzWIQr8yMspZs27A/UFdV+Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=HVKuP7tUbIZLw6xgolmmPujd42xFro8GShmm2ItScIM=;\n b=W1H1sZinDHmht5QyaUL2AUEqVcn4j1fFH4egIOwwGnh4+m5ixO44FDi0nsjsja5fh2K2blAbguO7xSkKI/Ov3cjOtN98yHkj+4JJpe4OzLUdAP2+2FyVG+vCSSWC3/Yo8VBwdAXxQwSFwqX1rij5UKs3iaPNTwZ2sHIm0xhey8acwGRxkymIYp189w2vP78tmYKbQ4LRKoohY3VkLbTCunhSGpntL2PWYaP+Tuudq1OVKJtHwWXVOYgY4zYecVm59VKUEOh6zIaA4/mSx/KLycX7glhZ599nkILdr+zF8j1gC8z0CW0c6JaOmqxeIMecxlXS/4uXzNmhgbgfhJhFxg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HVKuP7tUbIZLw6xgolmmPujd42xFro8GShmm2ItScIM=;\n b=pSm2d8UbvUqjOmovlEntAjVCmxdhtWncCHZOYpHOxWvcmpq5Jzx+n4Q8zUvmo4+PZdcnpLE7B0ADzwHz35+kEc8+QC/gZePj1QdGt4ODbINbelwf8hn434i/ZwUkYKBH8AyZr/rQrRW6RfR7q2XQhp1P8O0MpQwkztPp6+/IEao=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, niklas.soderlund@corigine.com,\n Chaoyong He <chaoyong.he@corigine.com>,\n Heinrich Kuhn <heinrich.kuhn@corigine.com>", "Subject": "[PATCH v10 07/13] net/nfp: move common rxtx function for flower use", "Date": "Mon, 26 Sep 2022 14:59:51 +0800", "Message-Id": "<1664175597-37248-8-git-send-email-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1664175597-37248-1-git-send-email-chaoyong.he@corigine.com>", "References": "<1664175597-37248-1-git-send-email-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "SG2P153CA0005.APCP153.PROD.OUTLOOK.COM (2603:1096::15) To\n SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|SA1PR13MB4893:EE_", "X-MS-Office365-Filtering-Correlation-Id": "0808a3e4-223b-4979-9640-08da9f8ccd9e", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n Yx7rpEae/BQOkYcq398pgnVYOothoAWziIblJpo3RM/3291Wtc4xjTjoQiGnwYh3fzBue6JFriJ26d4bDggvoYrox9ntgGHjJEDyBnc6lEjtnXjxQXJU+8Vtnyi+x2wdoMI+kzsR1uL2QmwqwkgZ4CT3kuBDvMYP8KKIaXFIf+/TJL+1DVsByFyfDoPwkUhUock5AxIQmDxmg3yIIWWlFoGdKMX0qFQcbHfC+N0c8Qql9VlYofrbFwa6gdWNxGyzoMnAdM2Va8nuCqUdyI8aRSbqz6JUgIfi5KvPNcIsC+yG1xMUMHP8CZmgYesX9+ubVtKOW66XbSqnNT+To+YS7rWGezzq1j4e/AUxzDdymgZNdsRZFYRrcJmXUuwjfs5qwIjOEemDpUZJzLFtYWAnQwcF1xALmErCEDYGNHVBk8Sz/qraKD+3it3C/0pDLknACnVGT5WCxa2kiJ7tn/dN063/Xs0T5lovAlUaUuBBJgLprVHhAk+/Ra5MtNgzS8cS0InE7bjGvNRLopyWZV9obuQR++56LlkNqJgj0+BqLQvi8HAAg7j5FUDKgyxc8/iQc9MQeZeAwy3jLPv+ci4/gWr65Plo8Xnor/eTifIvvOe4b/TUy7D+JQ1PmsnlpCOktZ7V9euTK3Uay0zBmoBWpJscXEM8lnjzBgpQOfSOtrAoXR9JfYVSHv67IgCcT+i9c50YizZBFzCAybaR1MZpQpEEKLKFEg3Yg/BNk6g/hS3XNVJH39ynEdr82VYGvnK7wQciM8vHvC1LO7rkjH9BXQ==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230022)(4636009)(366004)(396003)(39830400003)(136003)(376002)(346002)(451199015)(36756003)(38100700002)(38350700002)(2906002)(86362001)(44832011)(66946007)(8936002)(66556008)(66476007)(5660300002)(8676002)(4326008)(83380400001)(186003)(54906003)(6512007)(6916009)(316002)(52116002)(6666004)(2616005)(26005)(6506007)(478600001)(41300700001)(107886003)(6486002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?rEnW+ClJk0VOpA0CtsfNORTTbB+3?=\n\t=?utf-8?q?DQlb3AK6gtTzEIzjCMBOOyOI9bSMEwE97IBy0RsJBwdn1jdEy20jO0RezZDSrx0Lt?=\n\t=?utf-8?q?n61GX9oyJ7vIYNyCZWE9/A4LO0rEJ6DI8bl7PXzvCW2f/0GUo9yd54sPMy5MNzigw?=\n\t=?utf-8?q?Cc2aS4eLGV/qI0zRRb5WcsHDy6McsoSU8vSalqzkaU6XBY8Y+Y0QqyPC7M0Ks1N1d?=\n\t=?utf-8?q?ybnWlwr4WhxlgL5Q+DR3v+rWzg8UAYtso9uLZBIsHDSTcixfMXBDfkTlCrYKTd2Dd?=\n\t=?utf-8?q?otHh3EXuJMheKn4AY2o9PJy7yCJta5/P5zE3ChlM33/bpvJF9tJJZx1ZwNNJOBJVI?=\n\t=?utf-8?q?vU1xaT5YoQEakv4oogV70W6+J5CZoqhY3OEMD9qa7nFXyl/G1wzpusXYTg4D3Y3EK?=\n\t=?utf-8?q?sH4F+w0dYVGY1FcWOM2elmBISQK7aS2ceruY/QHgtfPUDfjcJWAJ/Kmb2lOKKeFTJ?=\n\t=?utf-8?q?aCNWobaqFHnnRBgyeZZYTw/4zmGArrIJtBUWab3B1KGkF2aWYS3SGZvSOr+D6p2Iw?=\n\t=?utf-8?q?CQbOfY3srTLEVsYyCBYZtOYrfcpDjRLaZkI0OzHuPh86LIzCgpr947Z26/ad3OD0k?=\n\t=?utf-8?q?K24TX8KPr69v/wRbPVPcWGcOKXAWYzUc80aNCLcNXE3rYZChV/7uXNjCb7ggnqjkb?=\n\t=?utf-8?q?o/LPaeqJ4QK8+7No5xGKF/dZnsNi34l5YxcMbHQSo2VDERkzVOKPK8WQ1UfQ+ge9m?=\n\t=?utf-8?q?x35QJYo8VW+rQWDcxfhYeplB+y71s85XYXcefd7NLJhG4VX2jYwj+w4Ls4bbd7Nwq?=\n\t=?utf-8?q?RS4XtfnwHsrqHj1V4Fcr2wjdWKwY9UvtlhZpgcbAvSS1r3k9xTU0W0hEDF/rXDYw2?=\n\t=?utf-8?q?aeOetCw0xnI74H3zofnwsFzN6vpJBAEJOq5WglbE6fNKHqBWEmMO6OLFnSoRwMFNR?=\n\t=?utf-8?q?A5jNZz1CFcOa8qRDAlfkYEimm6m94OoHKVvf6w28tsdebDR+aRYjw/psP0CTZX9tb?=\n\t=?utf-8?q?4lQrFBSY7XD2cXInvR0D5NJrEGoBjhXvdsPRR8+4imrF6XPzbE/RaAgJm8bHY7rmp?=\n\t=?utf-8?q?No2y/75ssDIh/IXv/O+hNiULkSDUtq9uiytG9NiJ4pt9K/PybXLJe3TJsce33AhdH?=\n\t=?utf-8?q?1FuQGHobHirmQ03yUiFXHKuPnbSUtWNApLLZhLGEJYzVGiQkNseJnYTSw1PBH1Twl?=\n\t=?utf-8?q?HedvQiiwQaEKpibNbufdzRk1CsF36Nj8/eO9pu6tv/wIDYuU/vW8V13CoapxQoGzC?=\n\t=?utf-8?q?3kTvRlfFDwcT5LtqEpgXkoXY398SSXvrBui2Jq9W61a1eXMuf/NjJMJ906wLPGrdb?=\n\t=?utf-8?q?JSnOen8SDHUJbfJTlljz30dvDQGmsjPwMNWhUrLCyq03xpRQYEuyUYZvn9X1yrYJI?=\n\t=?utf-8?q?2JlnkHf9feRfVTmjQ7zgYmaCvdRyytuwGHhz8ypStHjFm/JiitObvSzAXUWpusjsj?=\n\t=?utf-8?q?pv7rMNiNblRaaSsTokTlVWgBjhFIWfHwxCkellB8RLptphRff6y4mvOi5N38teU2k?=\n\t=?utf-8?q?RxJOTHObPrDljSSEC6ggYcaw6tsaxN/uUFBJqIHIGEs62lwQFTxNSzmNHzgjEQcvQ?=\n\t=?utf-8?q?e9u5BYcxkl0YH/aAC+ouEyU7ZCfa1VW2AQ=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0808a3e4-223b-4979-9640-08da9f8ccd9e", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Sep 2022 07:00:32.3119 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n LJbS/rzG5FigK2HCYBbROS9s5eOu4BeXz+YySe8inUyO9TSpMKVOdoBQ82RKhf9gmli9J5y1AqkT1ylFEBk1URcWvU8Oqgj42AgQ6gFX3g4=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA1PR13MB4893", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Move some common Rx and Tx logic to the header file so that\nthey can be re-used by flower Tx and Rx logic.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nSigned-off-by: Heinrich Kuhn <heinrich.kuhn@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfp_rxtx.c | 32 +-------------------------------\n drivers/net/nfp/nfp_rxtx.h | 31 +++++++++++++++++++++++++++++++\n 2 files changed, 32 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c\nindex 8429b44..8d63a7b 100644\n--- a/drivers/net/nfp/nfp_rxtx.c\n+++ b/drivers/net/nfp/nfp_rxtx.c\n@@ -116,12 +116,6 @@\n \treturn count;\n }\n \n-static inline void\n-nfp_net_mbuf_alloc_failed(struct nfp_net_rxq *rxq)\n-{\n-\trte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed++;\n-}\n-\n /*\n * nfp_net_set_hash - Set mbuf hash data\n *\n@@ -583,7 +577,7 @@\n * @txq: TX queue to work with\n * Returns number of descriptors freed\n */\n-static int\n+int\n nfp_net_tx_free_bufs(struct nfp_net_txq *txq)\n {\n \tuint32_t qcp_rd_p;\n@@ -774,30 +768,6 @@\n \treturn 0;\n }\n \n-/* Leaving always free descriptors for avoiding wrapping confusion */\n-static inline\n-uint32_t nfp_net_nfd3_free_tx_desc(struct nfp_net_txq *txq)\n-{\n-\tif (txq->wr_p >= txq->rd_p)\n-\t\treturn txq->tx_count - (txq->wr_p - txq->rd_p) - 8;\n-\telse\n-\t\treturn txq->rd_p - txq->wr_p - 8;\n-}\n-\n-/*\n- * nfp_net_txq_full - Check if the TX queue free descriptors\n- * is below tx_free_threshold\n- *\n- * @txq: TX queue to check\n- *\n- * This function uses the host copy* of read/write pointers\n- */\n-static inline\n-uint32_t nfp_net_nfd3_txq_full(struct nfp_net_txq *txq)\n-{\n-\treturn (nfp_net_nfd3_free_tx_desc(txq) < txq->tx_free_thresh);\n-}\n-\n /* nfp_net_tx_tso - Set TX descriptor for TSO */\n static inline void\n nfp_net_nfd3_tx_tso(struct nfp_net_txq *txq, struct nfp_net_nfd3_tx_desc *txd,\ndiff --git a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h\nindex 5c005d7..a30171f 100644\n--- a/drivers/net/nfp/nfp_rxtx.h\n+++ b/drivers/net/nfp/nfp_rxtx.h\n@@ -330,6 +330,36 @@ struct nfp_net_rxq {\n \tint rx_qcidx;\n } __rte_aligned(64);\n \n+static inline void\n+nfp_net_mbuf_alloc_failed(struct nfp_net_rxq *rxq)\n+{\n+\trte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed++;\n+}\n+\n+/* Leaving always free descriptors for avoiding wrapping confusion */\n+static inline uint32_t\n+nfp_net_nfd3_free_tx_desc(struct nfp_net_txq *txq)\n+{\n+\tif (txq->wr_p >= txq->rd_p)\n+\t\treturn txq->tx_count - (txq->wr_p - txq->rd_p) - 8;\n+\telse\n+\t\treturn txq->rd_p - txq->wr_p - 8;\n+}\n+\n+/*\n+ * nfp_net_nfd3_txq_full - Check if the TX queue free descriptors\n+ * is below tx_free_threshold\n+ *\n+ * @txq: TX queue to check\n+ *\n+ * This function uses the host copy* of read/write pointers\n+ */\n+static inline uint32_t\n+nfp_net_nfd3_txq_full(struct nfp_net_txq *txq)\n+{\n+\treturn (nfp_net_nfd3_free_tx_desc(txq) < txq->tx_free_thresh);\n+}\n+\n int nfp_net_rx_freelist_setup(struct rte_eth_dev *dev);\n uint32_t nfp_net_rx_queue_count(void *rx_queue);\n uint16_t nfp_net_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n@@ -355,6 +385,7 @@ int nfp_net_nfdk_tx_queue_setup(struct rte_eth_dev *dev,\n uint16_t nfp_net_nfdk_xmit_pkts(void *tx_queue,\n \t\tstruct rte_mbuf **tx_pkts,\n \t\tuint16_t nb_pkts);\n+int nfp_net_tx_free_bufs(struct nfp_net_txq *txq);\n \n #endif /* _NFP_RXTX_H_ */\n /*\n", "prefixes": [ "v10", "07/13" ] }