Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116797/?format=api
{ "id": 116797, "url": "http://patches.dpdk.org/api/patches/116797/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1663987546-15982-18-git-send-email-longli@linuxonhyperv.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1663987546-15982-18-git-send-email-longli@linuxonhyperv.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1663987546-15982-18-git-send-email-longli@linuxonhyperv.com", "date": "2022-09-24T02:45:45", "name": "[v9,17/18] net/mana: report queue stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fb59d6e2d82d19f13c04a68a87f21637aec4d9f2", "submitter": { "id": 1784, "url": "http://patches.dpdk.org/api/people/1784/?format=api", "name": "Long Li", "email": "longli@linuxonhyperv.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1663987546-15982-18-git-send-email-longli@linuxonhyperv.com/mbox/", "series": [ { "id": 24807, "url": "http://patches.dpdk.org/api/series/24807/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24807", "date": "2022-09-24T02:45:28", "name": "Introduce Microsoft Azure Network Adatper (MANA) PMD", "version": 9, "mbox": "http://patches.dpdk.org/series/24807/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116797/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/116797/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6CE68A054F;\n\tSat, 24 Sep 2022 04:47:36 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0454042C38;\n\tSat, 24 Sep 2022 04:46:44 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 3710442BD5\n for <dev@dpdk.org>; Sat, 24 Sep 2022 04:46:01 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1004)\n id 9C5C820C32C4; Fri, 23 Sep 2022 19:46:00 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 9C5C820C32C4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com;\n s=default; t=1663987560;\n bh=3rjo4cVyJzig54892rpH1ARYUFfpdy7cZ0ZOJDbkky8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:Reply-To:From;\n b=kL8YVH1bnkrc/JFJNORAZEUGVFj99LkNG1YeJGUalPJByp5PiJkVLZV5ERY105fjr\n vnGNHm+g80Ay7kJ//zJyRp0JgBojprMspSJ4P3H42NGnZDGPJYBLa3/3Rnox9T+PM3\n ixCXM+sgGkaNg8xzRkKXfWZAjKxwCSpEVijtG0l8=", "From": "longli@linuxonhyperv.com", "To": "Ferruh Yigit <ferruh.yigit@xilinx.com>", "Cc": "dev@dpdk.org, Ajay Sharma <sharmaajay@microsoft.com>,\n Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>", "Subject": "[Patch v9 17/18] net/mana: report queue stats", "Date": "Fri, 23 Sep 2022 19:45:45 -0700", "Message-Id": "<1663987546-15982-18-git-send-email-longli@linuxonhyperv.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1663987546-15982-1-git-send-email-longli@linuxonhyperv.com>", "References": "<1662674189-29524-1-git-send-email-longli@linuxonhyperv.com>\n <1663987546-15982-1-git-send-email-longli@linuxonhyperv.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Reply-To": "longli@microsoft.com", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Li <longli@microsoft.com>\n\nReport packet statistics.\n\nSigned-off-by: Long Li <longli@microsoft.com>\n---\nChange log:\nv5:\nFixed calculation of stats packets/bytes/errors by adding them over the queue stats.\nv8:\nFixed coding style on function definitions.\n\n doc/guides/nics/features/mana.ini | 1 +\n drivers/net/mana/mana.c | 77 +++++++++++++++++++++++++++++++\n 2 files changed, 78 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/features/mana.ini\nindex 7922816d66..81ebc9c365 100644\n--- a/doc/guides/nics/features/mana.ini\n+++ b/doc/guides/nics/features/mana.ini\n@@ -4,6 +4,7 @@\n ; Refer to default.ini for the full list of available PMD features.\n ;\n [Features]\n+Basic stats = Y\n Free Tx mbuf on demand = Y\n Link status = P\n Linux = Y\ndiff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c\nindex c43212950f..d247b930db 100644\n--- a/drivers/net/mana/mana.c\n+++ b/drivers/net/mana/mana.c\n@@ -526,6 +526,79 @@ mana_dev_link_update(struct rte_eth_dev *dev,\n \treturn rte_eth_linkstatus_set(dev, &link);\n }\n \n+static int\n+mana_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+{\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tstruct mana_txq *txq = dev->data->tx_queues[i];\n+\n+\t\tif (!txq)\n+\t\t\tcontinue;\n+\n+\t\tstats->opackets = txq->stats.packets;\n+\t\tstats->obytes = txq->stats.bytes;\n+\t\tstats->oerrors = txq->stats.errors;\n+\n+\t\tif (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n+\t\t\tstats->q_opackets[i] = txq->stats.packets;\n+\t\t\tstats->q_obytes[i] = txq->stats.bytes;\n+\t\t}\n+\t}\n+\n+\tstats->rx_nombuf = 0;\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tstruct mana_rxq *rxq = dev->data->rx_queues[i];\n+\n+\t\tif (!rxq)\n+\t\t\tcontinue;\n+\n+\t\tstats->ipackets = rxq->stats.packets;\n+\t\tstats->ibytes = rxq->stats.bytes;\n+\t\tstats->ierrors = rxq->stats.errors;\n+\n+\t\t/* There is no good way to get stats->imissed, not setting it */\n+\n+\t\tif (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n+\t\t\tstats->q_ipackets[i] = rxq->stats.packets;\n+\t\t\tstats->q_ibytes[i] = rxq->stats.bytes;\n+\t\t}\n+\n+\t\tstats->rx_nombuf += rxq->stats.nombuf;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused)\n+{\n+\tunsigned int i;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tstruct mana_txq *txq = dev->data->tx_queues[i];\n+\n+\t\tif (!txq)\n+\t\t\tcontinue;\n+\n+\t\tmemset(&txq->stats, 0, sizeof(txq->stats));\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tstruct mana_rxq *rxq = dev->data->rx_queues[i];\n+\n+\t\tif (!rxq)\n+\t\t\tcontinue;\n+\n+\t\tmemset(&rxq->stats, 0, sizeof(rxq->stats));\n+\t}\n+\n+\treturn 0;\n+}\n+\n static const struct eth_dev_ops mana_dev_ops = {\n \t.dev_configure\t\t= mana_dev_configure,\n \t.dev_start\t\t= mana_dev_start,\n@@ -542,9 +615,13 @@ static const struct eth_dev_ops mana_dev_ops = {\n \t.rx_queue_setup\t\t= mana_dev_rx_queue_setup,\n \t.rx_queue_release\t= mana_dev_rx_queue_release,\n \t.link_update\t\t= mana_dev_link_update,\n+\t.stats_get\t\t= mana_dev_stats_get,\n+\t.stats_reset\t\t= mana_dev_stats_reset,\n };\n \n static const struct eth_dev_ops mana_dev_secondary_ops = {\n+\t.stats_get = mana_dev_stats_get,\n+\t.stats_reset = mana_dev_stats_reset,\n \t.dev_infos_get = mana_dev_info_get,\n };\n \n", "prefixes": [ "v9", "17/18" ] }