Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116338/?format=api
{ "id": 116338, "url": "http://patches.dpdk.org/api/patches/116338/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1663238669-12244-4-git-send-email-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1663238669-12244-4-git-send-email-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1663238669-12244-4-git-send-email-chaoyong.he@corigine.com", "date": "2022-09-15T10:44:20", "name": "[v9,03/12] net/nfp: move app specific init logic to own function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fecc0bad5d8f56bcba07b123b0fbb17c762bb5f8", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1663238669-12244-4-git-send-email-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 24678, "url": "http://patches.dpdk.org/api/series/24678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24678", "date": "2022-09-15T10:44:17", "name": "preparation for the rte_flow offload of nfp PMD", "version": 9, "mbox": "http://patches.dpdk.org/series/24678/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116338/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/116338/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E2FFFA00C5;\n\tThu, 15 Sep 2022 12:45:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 01D3D4282F;\n\tThu, 15 Sep 2022 12:44:59 +0200 (CEST)", "from NAM04-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam04on2109.outbound.protection.outlook.com [40.107.101.109])\n by mails.dpdk.org (Postfix) with ESMTP id 2F53A4280D\n for <dev@dpdk.org>; Thu, 15 Sep 2022 12:44:58 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by SA0PR13MB4158.namprd13.prod.outlook.com (2603:10b6:806:9b::9) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.5; Thu, 15 Sep\n 2022 10:44:56 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::819:38c:6513:bf15]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::819:38c:6513:bf15%4]) with mapi id 15.20.5632.012; Thu, 15 Sep 2022\n 10:44:56 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Tm+d1t+boBq8LGIBn+fLcVSCY7TWMQpDc2l4Zbya1lLmibBHlYj1FHcWso6gxiU8noVm8OMPl1P495K5U7i0QkCDsjEcBW+/FbrBoMcbpsMjAzxhLT8pEdWVlNiWTL+NAw24BRxUxsXNQ7DSYJaRxnA4RUBec7/1dYtjWWetqWCIs9AzZabcPD3ahKyXpkS3I2XSFiEekVHP5wU9Zc/qSOs4EnHgrDsMy0dhiue882rziSa3oeMHeBA2IOFuFynMAFoudkAs2Rm1JfF8JZNUIvEa4O9+huAPQcUKiVx1wrflugWiySTNZA7fZ1Wt3FPDVyoByW7Ll+NYJgya0q+03g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=BdKMo4WIoS0z8M0mAkfqqFBPZt+O2goaKkiPOuz7AHU=;\n b=TSoLr/wS+a9pNG3iSTe8t/RhBXGkJf/6KqInGR5Do1/eop98ZSvwbZuBBEZ6DDxlrgoidV5K+XwDh8ZO3E7rXW1JMxCXun6dLIwAEnHZZFCILYIKNvK+oMkHi+EnKsVq++G0J0eEeBg8dPoQ05xVuubManzFVqdxdNv5O259E19YyBBwTn8oyJoh/Zm26v7IeKOX/fhQ4nk7gs9Heeeasm7ERIdUR/rIbccYmUuktDOisokq5tGmBdh73vBouKu2PLIX9/VbiUKy+6z4dA3d0vkDMAMR/yqsdPVl/0UqI8F+rM4rTGGeBsF/92rV9LRtj2bzekyrch7k4UQHnaJIGA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=BdKMo4WIoS0z8M0mAkfqqFBPZt+O2goaKkiPOuz7AHU=;\n b=FmyxFWrijFiQ1Ouebb9gG7ZOnpCigq1WyKiVNhXDozSRiu4eC81/uG2vQ6ewTXBfOag37bapx7yfld87H/05ENrRZk6bQy4ERinNoUzsvLr6cdn98ttEW9GEgw5YHVU1mMWNkytC7eh+fB5OMPZbrsLOlBMYm/3Fpp/JgyjDTa4=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, niklas.soderlund@corigine.com,\n Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH v9 03/12] net/nfp: move app specific init logic to own\n function", "Date": "Thu, 15 Sep 2022 18:44:20 +0800", "Message-Id": "<1663238669-12244-4-git-send-email-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1663238669-12244-1-git-send-email-chaoyong.he@corigine.com>", "References": "<1663238669-12244-1-git-send-email-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "BYAPR11CA0071.namprd11.prod.outlook.com\n (2603:10b6:a03:80::48) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|SA0PR13MB4158:EE_", "X-MS-Office365-Filtering-Correlation-Id": "663b00b2-fd8c-4658-d823-08da97075480", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n vcSxbe2yBfVTdwL6mDWQxnVyUCCzspd2AsVTeVGKIMsx3m/CYCESOOkLDxzvr9KX14fYwEeTI1LbYDsRX+Vbjg5IIbVTY293PhPyI7M0zEdmUgCoilUz4uETLREnJHkw3oCXFJDch91IxLHx7g594ccoteLHZ3gevYfVTXCBCGC6Wrg6/0KweneCydBzb1jSvGgSyPCR6E1swg49JIfv8FZX0lTSw/U728QCNusTmih3QscibJJlasw1clF3asvijeph1Ewf6a29pXpX64u9ii/3Y10SfZoYAPDIrj0TyENueqkD2gLQVMfce64dEcwpveaDZh5WJxAnPiN7Ih/vCMJ5kHHU591EuYIeR/9wTsk9pXzyN3gTjHlMdpcoXFYVQ1tctcwjQYo/RUgCqxAeHZFhK9PZT9jMuU3eCv1v7wWqgIRYNl9VQm5tpS9M2sRq1tfr/pOaF7zeGfTUpd+czvll/x+flObMedeSot2BaO6Of1i3k7uzEmAnSRekgyYQrduZPXrzvlauahygTjz/2rP3QfKveIYXRu9NKNATHnvvX+gW5wz+XdGiViCTn4hCYd8jGcsHKHXpjcw9MbQ4qBSyKVDv2BOlkoSMkoB7nAxU/RzTgnJBTbjaCOL3F+6WXtPF2nDD7Ef7Y3f01stlW+QqDAh9sLHTvZKnzpmJFMhut7E8wWwqukjoMbX4wwjobBZPL9vXsl591e1Qf3dnvQ0vOTWcmkdvtE7oH+6Qmf1OEJYSEaySVjS5Pz4gVd/kwLMuHI0g+cNq8SZR91dbwQ==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230022)(4636009)(396003)(346002)(366004)(376002)(39840400004)(136003)(451199015)(2616005)(38350700002)(38100700002)(186003)(86362001)(83380400001)(107886003)(8676002)(66946007)(66476007)(4326008)(66556008)(44832011)(8936002)(41300700001)(2906002)(5660300002)(6506007)(478600001)(6666004)(316002)(6512007)(26005)(6486002)(52116002)(6916009)(36756003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?gdxusWpgNZ/X69myKfG8SAgqsgpe?=\n\t=?utf-8?q?jwm46bQs781eyJ8IH3uZkUsVjiRwYn1Q49rQCm8/EpdB34mADTRBBjZ4dlu8HxoN7?=\n\t=?utf-8?q?Qr8HX8cFGPCIiPpnaRb4TOxMdxhSq08ak7ma7vNqwguWGFi7Vd/CLFsB+PNOoY0s6?=\n\t=?utf-8?q?Oa/lsBrhA5i+bVWkGq6Y7ms0W0Re9y0s4B+SblYtVuuX3rg+J9uJsSrdGavMxchlN?=\n\t=?utf-8?q?QYf6A3LDXiKsov5FrNipl2xVBZDldEzUvlRbbEr5gKBZNGrL9jLjMeUEHT9lLd9qk?=\n\t=?utf-8?q?dSM8684s7wMnLJh/fqreneNbg8CyEdnCYnV6ESxJDKQ+GzsGz8il5vuk/WMKDh1Or?=\n\t=?utf-8?q?0sPA9snxjVpgdiT7hTgowQ1af2MVtqHdxPhquKpBp1OUEtHo8B0uP1WFwWOgzUyD/?=\n\t=?utf-8?q?hJFZvGF5AY7UOrWYgd9zp78vHmuH0OdSiC52b9iP4ggrduvtWmGt83ANC5llJTVOR?=\n\t=?utf-8?q?KRVO6DnpgBkKhUZX+I/NSdXW94I5Gnp2Rl5sep5KRlRZyNtRLWPwhPk0Re2TrhCPP?=\n\t=?utf-8?q?+JTrCO13SsMTf0fUQD++HeK5Hh7LBk36RKnlNa0S3+jyRZ/QeL4nWZoWGi/WNO5EJ?=\n\t=?utf-8?q?xVLGMUw3VOWLTUZCOyF1/EQiN7l9VJKy6bU52KaiWVq+jAZzu4KGHS0XRpqLrgMaB?=\n\t=?utf-8?q?Af9qHXSpy43TmaBbI7mQVcRFB9iHZuz8XDtHOLfVyEcsgegEbagLSVD9biFYrDrFZ?=\n\t=?utf-8?q?BSDiQ/zPZaVcrxrpMz6pBT17AWW2w99UsWHxeRrq98tCICO6TrQQiQ1Jk+baTGhuT?=\n\t=?utf-8?q?eqHZu0OO9bsbC7B7amWcC5se8JZ7SxhtIj0mN0TXSJJ7p1g/Q7bzPVUZnWVsZteNk?=\n\t=?utf-8?q?kULQB8MW1h28MYTiwWxKJbWq2oC/R2tFTeJx5jmYN94uA8xPzM8lavoax537N1D9y?=\n\t=?utf-8?q?WdRoOeRN+YmGlNZKxIjuVaNktEXWsgf8WgVoY/iVnkdTQvjzL8lOBWFUv6Ig46zSX?=\n\t=?utf-8?q?NJhIK0l0Fig88CWHHR/9Ywtjwyxya27xnWDg0FFFI2P/Ywa3ldy86hmNDDzAzTECj?=\n\t=?utf-8?q?cx/3A9wlbDPwYbevT+9ImMayQaS5lSPa1FG/0YkAXX27mqsSCgx1M+xJZUD8Rf1WI?=\n\t=?utf-8?q?teADRE/JKYw8kRIV/hRuiA1SqKvHGnCh78jP2LpqcGXNIslqrinGE4qWfuH4wme9E?=\n\t=?utf-8?q?1bucw129gVCjKTqI9nTVHVduN2dWIOO9P1Hu5We5cQ2WDAwgnU1+juqcF/Q46OrVQ?=\n\t=?utf-8?q?5nCEZ39pe4THnfgpOZbPTquSmfw/L2thbKmvHWBb9L84IoxFE5em636WGCCPN0GQP?=\n\t=?utf-8?q?FimWlQjSNxK+BhA/DZRkKl8GdrvzBLbYX5fYr3Y2BHe8KuRfpYqQZKfCbSMLSGus7?=\n\t=?utf-8?q?00V3XQeG/+rVX5+QvWHMaqkGBL5e0EhKo1qHtnjXGtNZrGIMxtGO208eNX/o21UOl?=\n\t=?utf-8?q?QAZqkm8Itrjr2sjCm0NTj31F/ay6lhIvxIB9i0UyCPPeLSJt4d75dke4JT9ZSa4U+?=\n\t=?utf-8?q?C4m8ceub4YDXJDEdoHVAFIJYxOdzpxOMXJ2JCGS/Z3uzfnfYE7NyQ/UdoC+rYS7tm?=\n\t=?utf-8?q?HhCUbBv2PyvLhfY3JGb4hbGv30EimdffUw=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA0PR13MB4158", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The NFP card can load different firmware applications.\nThis commit move the init logic of corenic app of the\nsecondary process into its own function.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfp_ethdev.c | 90 +++++++++++++++++++++++++++++---------------\n 1 file changed, 60 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 5c96f0b..0d09a69 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -994,6 +994,49 @@\n \treturn ret;\n }\n \n+static int\n+nfp_secondary_init_app_fw_nic(struct rte_pci_device *pci_dev,\n+\t\tstruct nfp_rtsym_table *sym_tbl,\n+\t\tstruct nfp_cpp *cpp)\n+{\n+\tint i;\n+\tint err = 0;\n+\tint ret = 0;\n+\tint total_vnics;\n+\tstruct nfp_net_hw *hw;\n+\n+\t/* Read the number of vNIC's created for the PF */\n+\ttotal_vnics = nfp_rtsym_read_le(sym_tbl, \"nfd_cfg_pf0_num_ports\", &err);\n+\tif (err != 0 || total_vnics <= 0 || total_vnics > 8) {\n+\t\tPMD_INIT_LOG(ERR, \"nfd_cfg_pf0_num_ports symbol with wrong value\");\n+\t\treturn -ENODEV;\n+\t}\n+\n+\tfor (i = 0; i < total_vnics; i++) {\n+\t\tstruct rte_eth_dev *eth_dev;\n+\t\tchar port_name[RTE_ETH_NAME_MAX_LEN];\n+\t\tsnprintf(port_name, sizeof(port_name), \"%s_port%d\",\n+\t\t\t\tpci_dev->device.name, i);\n+\n+\t\tPMD_INIT_LOG(DEBUG, \"Secondary attaching to port %s\", port_name);\n+\t\teth_dev = rte_eth_dev_attach_secondary(port_name);\n+\t\tif (eth_dev == NULL) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Secondary process attach to port %s failed\", port_name);\n+\t\t\tret = -ENODEV;\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\teth_dev->process_private = cpp;\n+\t\thw = NFP_NET_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);\n+\t\tif (nfp_net_ethdev_ops_mount(hw, eth_dev))\n+\t\t\treturn -EINVAL;\n+\n+\t\trte_eth_dev_probing_finish(eth_dev);\n+\t}\n+\n+\treturn ret;\n+}\n+\n /*\n * When attaching to the NFP4000/6000 PF on a secondary process there\n * is no need to initialise the PF again. Only minimal work is required\n@@ -1002,12 +1045,10 @@\n static int\n nfp_pf_secondary_init(struct rte_pci_device *pci_dev)\n {\n-\tint i;\n \tint err = 0;\n \tint ret = 0;\n-\tint total_ports;\n \tstruct nfp_cpp *cpp;\n-\tstruct nfp_net_hw *hw;\n+\tenum nfp_app_fw_id app_fw_id;\n \tstruct nfp_rtsym_table *sym_tbl;\n \n \tif (pci_dev == NULL)\n@@ -1041,37 +1082,26 @@\n \t\treturn -EIO;\n \t}\n \n-\ttotal_ports = nfp_rtsym_read_le(sym_tbl, \"nfd_cfg_pf0_num_ports\", &err);\n-\tif (err != 0 || total_ports <= 0 || total_ports > 8) {\n-\t\tPMD_INIT_LOG(ERR, \"nfd_cfg_pf0_num_ports symbol with wrong value\");\n-\t\tret = -ENODEV;\n+\t/* Read the app ID of the firmware loaded */\n+\tapp_fw_id = nfp_rtsym_read_le(sym_tbl, \"_pf0_net_app_id\", &err);\n+\tif (err != 0) {\n+\t\tPMD_INIT_LOG(ERR, \"Couldn't read app_fw_id from fw\");\n \t\tgoto sym_tbl_cleanup;\n \t}\n \n-\tfor (i = 0; i < total_ports; i++) {\n-\t\tstruct rte_eth_dev *eth_dev;\n-\t\tchar port_name[RTE_ETH_NAME_MAX_LEN];\n-\n-\t\tsnprintf(port_name, sizeof(port_name), \"%s_port%d\",\n-\t\t\t pci_dev->device.name, i);\n-\n-\t\tPMD_DRV_LOG(DEBUG, \"Secondary attaching to port %s\", port_name);\n-\t\teth_dev = rte_eth_dev_attach_secondary(port_name);\n-\t\tif (eth_dev == NULL) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"secondary process attach failed, ethdev doesn't exist\");\n-\t\t\tret = -ENODEV;\n-\t\t\tbreak;\n+\tswitch (app_fw_id) {\n+\tcase NFP_APP_FW_CORE_NIC:\n+\t\tPMD_INIT_LOG(INFO, \"Initializing coreNIC\");\n+\t\tret = nfp_secondary_init_app_fw_nic(pci_dev, sym_tbl, cpp);\n+\t\tif (ret != 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Could not initialize coreNIC!\");\n+\t\t\tgoto sym_tbl_cleanup;\n \t\t}\n-\n-\t\thw = NFP_NET_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);\n-\n-\t\tif (nfp_net_ethdev_ops_mount(hw, eth_dev))\n-\t\t\treturn -EINVAL;\n-\n-\t\teth_dev->process_private = cpp;\n-\n-\t\trte_eth_dev_probing_finish(eth_dev);\n+\t\tbreak;\n+\tdefault:\n+\t\tPMD_INIT_LOG(ERR, \"Unsupported Firmware loaded\");\n+\t\tret = -EINVAL;\n+\t\tgoto sym_tbl_cleanup;\n \t}\n \n \t/* Register the CPP bridge service for the secondary too */\n", "prefixes": [ "v9", "03/12" ] }