Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116337/?format=api
{ "id": 116337, "url": "http://patches.dpdk.org/api/patches/116337/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1663238669-12244-3-git-send-email-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1663238669-12244-3-git-send-email-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1663238669-12244-3-git-send-email-chaoyong.he@corigine.com", "date": "2022-09-15T10:44:19", "name": "[v9,02/12] net/nfp: simplify initialization and remove dead code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ef8fbc8be3384af3966bab4f0193f10d7f2049c7", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1663238669-12244-3-git-send-email-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 24678, "url": "http://patches.dpdk.org/api/series/24678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24678", "date": "2022-09-15T10:44:17", "name": "preparation for the rte_flow offload of nfp PMD", "version": 9, "mbox": "http://patches.dpdk.org/series/24678/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116337/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/116337/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 46510A00C5;\n\tThu, 15 Sep 2022 12:45:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BCA92427FF;\n\tThu, 15 Sep 2022 12:44:57 +0200 (CEST)", "from NAM04-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam04on2111.outbound.protection.outlook.com [40.107.101.111])\n by mails.dpdk.org (Postfix) with ESMTP id 43B1340A80\n for <dev@dpdk.org>; Thu, 15 Sep 2022 12:44:56 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by SA0PR13MB4158.namprd13.prod.outlook.com (2603:10b6:806:9b::9) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.5; Thu, 15 Sep\n 2022 10:44:55 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::819:38c:6513:bf15]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::819:38c:6513:bf15%4]) with mapi id 15.20.5632.012; Thu, 15 Sep 2022\n 10:44:55 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=B/5WmBe4rsCxdxdij61Wn1hujsjvmd2GW5D9LT6K2L7qJ3LfCmSf8X32clhnx03AZ248UdfnJ4krSG+t5qz5pT/buVc4Bam85XEleYintcjn6saDTvtHXreVpqxU/FAsOKGqS4W/6x/NAwE8DUBGn4gKcQI3jbfhcLt5o1CExVX8SvJbVtFj/FyNh0zj1ZuNS6yKCXKO7HlDOXMAz+kQnlB/58RulRTn/QQptS1B5VrX72QLX0qUpHmmSNoFEzITZwxOoeLpOg4ySC7W0XH6lpaHkAsiTi0fbxMddFYDbMZLpcZxZijCi6G6LEvJVPKB/kWFo1SfAYH2aMc9r3+FUQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=oyLQGXpiN0BiwZD9djrcyNyt/SEuGOVXNc5eMJpddc4=;\n b=BaFZA/K0xCNKnNgKDQ/AW8XqGMepghu+XDveg61XlmtHH7RVYe4MEiv7HnM3fLAIeg7N3TNDwqy7lF4E7FYFyntC3Q3EfcPOZ9bRd/H+L9LyvhS7b6wM5dNmI1urdx1J09RK9gFcbNb3AHQCVkTod9rUiUQmCMWmatXtNikb73UcOyrL7ZgpwmHHb2UPX9GKJGw5qbp+QlqgkjXxQ8k97OnCKhnfTA7g96b0JM1WuONFk/L4nv5/OGz5fu3nH3Z7L0amfoUIe/m3YUJV0dlW6LOwC/hFxhekKiDaM2XjEeEa0YgCs9dOm8PkiatOuPMSDubCkuWy6SB8e8X9ZP04Ng==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=oyLQGXpiN0BiwZD9djrcyNyt/SEuGOVXNc5eMJpddc4=;\n b=XUsEbyQ5HQmPiFKgWBNOV1PkqSCBi8Fx0d5ZpY2t2+3uDAJRUQj7MWHifMjVvfnWZvQl99j8HPIdP3UkBIGA1+uhVkFrcYULGfFFG0tRhyW+RR2z+w4lZ0R5yQ9vRDgLI8Ub/LMnOqJ8+6TEAipXiIFs2GH/GFM4cXtacU9Hxrw=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, niklas.soderlund@corigine.com,\n Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH v9 02/12] net/nfp: simplify initialization and remove dead\n code", "Date": "Thu, 15 Sep 2022 18:44:19 +0800", "Message-Id": "<1663238669-12244-3-git-send-email-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1663238669-12244-1-git-send-email-chaoyong.he@corigine.com>", "References": "<1663238669-12244-1-git-send-email-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "BYAPR11CA0071.namprd11.prod.outlook.com\n (2603:10b6:a03:80::48) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|SA0PR13MB4158:EE_", "X-MS-Office365-Filtering-Correlation-Id": "6ad295d0-ec17-4263-2a68-08da970753a3", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n qCbXnMkbQSGPV3+e2fJjYThhdu+YnTvPdI7q783g5y9x/okt+VTPDGxMB8YuM7ZKPg1kzButCnwpHSjZuOfLM8j25HHNFs8QDzOrw4eJr1iX07+ENOUgqMvGtn9IQYH8Q/OEl7/NWZhH+PapRMvVJ/RkwjlVr3KBmITSizklINjCkOEJ12pkZ72eG0zlrsdLQxzgESCCTJfW8SKhbCxQRXLzxYid+knfaR6L4udtSC/NTj+drtZxum8NLTyU6M/g8Tqe1IidbNJXsKlbJWV0wVo0pwTuzHLAf/ppU9RuTaqJtoGG2SqZDG6nfJp9RJVxjhUhh7H+ktnqYZcnA2ij5sPbi/svE5ujv6sNlOLO8dDte/Tg5BZvO1KtJiMId8EERp2K02tDA4NfZ7A5RxP94lwBtatyCHy6Ff7njFrG9PSmvd1BXSV2mJJoK9Z1s8s6enFR4x5bvvfGw0Y6jQuGG58n5QCBuNFerXM9jHb5NPIttDI3nIsPkQiNoRZ0uIVtH9x+7D5szwWq5U+Q/KJ4Mlz4/upeZrtLT5xbqVndWHZmYW9YiDw0VZInuQv1xGRi8yVbXWntvJ7iVT5Kr9LyTAm0fDBpUiVqzSUAQscFeufKqAL71iXFqZtEczR9eVasq7iJYBwDza3ETP2BpCl+67aFFBZxuRA73zwHLEcOfCTYPT65eCKnA0e1UU5zCDSMqvnA5Cndg2P0Ufv/KY4b5enrufmpXkh2xoTxF5qYfKDkYy2lktDAgHqhLRbldcJ8RokresyPLA1KV0E+qf+QvA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230022)(4636009)(396003)(346002)(366004)(376002)(39840400004)(136003)(451199015)(2616005)(38350700002)(38100700002)(186003)(86362001)(83380400001)(107886003)(8676002)(66946007)(66476007)(4326008)(66556008)(44832011)(8936002)(41300700001)(2906002)(5660300002)(6506007)(478600001)(6666004)(316002)(6512007)(26005)(6486002)(52116002)(6916009)(36756003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?H9BXAV8sBwflhJI1XT1ZxaQBDhMP?=\n\t=?utf-8?q?P1g8LyxVC0x/+/GXrmy6ZAJgHTa0bbmZacGuxBVDSHP/qjkJCrorYpP232ecC03PX?=\n\t=?utf-8?q?v8WN1CsLV7Dy0ACS3Vb57jmJcqPNyZFwr+J5NUrOwHPDrY44ju4xfNe1yWGzF1mQd?=\n\t=?utf-8?q?Yl1+CXfMiNvHyNR5B3hdf7FCP/eklmg3ligTVl964HJ7jwRzY046r11WFEmzibmFd?=\n\t=?utf-8?q?E17yoHuua+oDULZaBuPQjv/mY+gRsedPkE2Ow09i+eW3SLCfPa4K5tSJzHI8MaD8h?=\n\t=?utf-8?q?K7aYNnS2DfV34wS5z5AlrhwEsZFS/ZWcAHTSFLHwBbM9LsPSMEby7mTL5G51JQ7oG?=\n\t=?utf-8?q?TMM163PdsQ6BZB6o6uzACxHKzCer05xdIB1NxJLhtB1e8O7pCa8rYOoneNmcB2276?=\n\t=?utf-8?q?KYEyIC6CBJm1cfYuy3XCRrYKIIOrZOsPO/TN4cuAQ+YpRkCyocY8EllHCiKxkIpFO?=\n\t=?utf-8?q?UIs0GrnoQMlA/5IkN8ec95+WeTZOpldNQWrjhcCTzNUpfrSG0LNEptd4MiniDiVgK?=\n\t=?utf-8?q?Xo/GH2mC6wtsvjQiKtY8ZO9PpT4x0S4Syjoy+v2niaGh/BcvYo1oDjuVQvIDM52vW?=\n\t=?utf-8?q?0il1omaaoVzd53M/k/kYgP0EsJ5SAZHTQEtdiUeWCQ77xDNXguwTsN2KpGYcg8Dbe?=\n\t=?utf-8?q?yxXByaEctetBbk5+grtcv3kCwcK38AL0++iZmnqQfCyyU81zDNWGYoMubO4ql3D96?=\n\t=?utf-8?q?FGJkHDcuHrp7KOESTK5nHFbXVq51btTBOeBH5GGGbS1vjnLkYyJ1JeWGOycjQqgHT?=\n\t=?utf-8?q?TGlgtLv5bQBqXANsI0z34v3cyZPWCk3uZ6D5qRukjT23FeWlmpiBaQT1UtshJZQi0?=\n\t=?utf-8?q?0uvoeETEu7O1BT1+3UURWpFWIzYjay5TN9nrnSaH926MPIN29IYLHLYMT4lmE/fHs?=\n\t=?utf-8?q?25FfBD1yMwGkXw5jg9vpSKUk0OkO+ALWBb2SNYDZevXJGMQ4c9mae4LeR1HTXKcBO?=\n\t=?utf-8?q?yIW5W2XFNENX7l50hpXbS4ZC7h4wNSkf/dmV32SIlc3h4iUQQTMDX4ICGR2METUZ0?=\n\t=?utf-8?q?dySNyLs649huxIAnkorcrpQxbG9B9vGeSBX58kN1tVsL3880xkwDs/Fgz+skT1nIQ?=\n\t=?utf-8?q?Yy0iM0nGkQgXkW2yq0Ab8nSCtDfhq2M9KHiKjRzBNUsYybIKr3V2MtNKdCNZRCLDz?=\n\t=?utf-8?q?701rHgKcYFPiXapnpdLbOVlQXX9DqP+J+GvRZ52J9gO1rjTcVp/R2ms9E3aqP3aBH?=\n\t=?utf-8?q?O1lypYX50IOIaXEy84+XGbS9jOGyLtdYoQuL/3xeV1cYMHKHaUlWbNKtkRvVTLUUg?=\n\t=?utf-8?q?SgX1ea9vQ12jJZbbJI++C024yi1kHsHaD5aobSTtw78o3bBQmPo7ez6/umzfsuvgC?=\n\t=?utf-8?q?P9yhZdUODpmaijIbRlcT/xzjym3AyiAJ5/ThFAOPRhz63caOO1DTmMg+7DVK7+/SK?=\n\t=?utf-8?q?jvg/CwgbEzjL4k91cqKH/JF2vCCHzeIiyPGoxy85l7sWUTHBKtjsU1tYBri2cEx6R?=\n\t=?utf-8?q?x2JhiS+/LTrZAxSndUcjDJGEBv/8aSohZ2XN4A4MsbA+TTJScGoi/Ns/ELRyKO8E5?=\n\t=?utf-8?q?FahS+2KKH7H4GWu63TQJSowoM4KGdm/vTg=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA0PR13MB4158", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Calling nfp_net_init() is only done for the corenic firmware flavor\nand it is guaranteed to always be called from the primary process,\nso the explicit check for RTE_PROC_PRIMARY can be dropped.\n\nThe calling graph of nfp_net_init() already guaranteed the free of\nresources when it fail, so remove the necessary free logics inside it.\n\nWhile at it remove the unused member is_phyport from struct nfp_net_hw.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfp_common.h | 1 -\n drivers/net/nfp/nfp_ethdev.c | 40 +++++++++++-----------------------------\n 2 files changed, 11 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h\nindex bea5f95..6af8481 100644\n--- a/drivers/net/nfp/nfp_common.h\n+++ b/drivers/net/nfp/nfp_common.h\n@@ -235,7 +235,6 @@ struct nfp_net_hw {\n \tuint8_t idx;\n \t/* Internal port number as seen from NFP */\n \tuint8_t nfp_idx;\n-\tbool\tis_phyport;\n \n \tunion eth_table_entry *eth_table;\n \ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 40d21e4..5c96f0b 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -417,7 +417,6 @@\n \tuint32_t start_q;\n \tint stride = 4;\n \tint port = 0;\n-\tint err;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -452,10 +451,6 @@\n \tPMD_INIT_LOG(DEBUG, \"Working with physical port number: %d, \"\n \t\t\t\"NFP internal port number: %d\", port, hw->nfp_idx);\n \n-\t/* For secondary processes, the primary has done all the work */\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n-\t\treturn 0;\n-\n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n \n \thw->device_id = pci_dev->id.device_id;\n@@ -506,8 +501,7 @@\n \t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(ERR, \"nfp_net: no device ID matching\");\n-\t\terr = -ENODEV;\n-\t\tgoto dev_err_ctrl_map;\n+\t\treturn -ENODEV;\n \t}\n \n \tPMD_INIT_LOG(DEBUG, \"tx_bar_off: 0x%\" PRIx64 \"\", tx_bar_off);\n@@ -573,8 +567,7 @@\n \t\t\t\t\t RTE_ETHER_ADDR_LEN, 0);\n \tif (eth_dev->data->mac_addrs == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to space for MAC address\");\n-\t\terr = -ENOMEM;\n-\t\tgoto dev_err_queues_map;\n+\t\treturn -ENOMEM;\n \t}\n \n \tnfp_net_pf_read_mac(app_fw_nic, port);\n@@ -604,24 +597,15 @@\n \t\t hw->mac_addr[0], hw->mac_addr[1], hw->mac_addr[2],\n \t\t hw->mac_addr[3], hw->mac_addr[4], hw->mac_addr[5]);\n \n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\t/* Registering LSC interrupt handler */\n-\t\trte_intr_callback_register(pci_dev->intr_handle,\n-\t\t\t\tnfp_net_dev_interrupt_handler, (void *)eth_dev);\n-\t\t/* Telling the firmware about the LSC interrupt entry */\n-\t\tnn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX);\n-\t\t/* Recording current stats counters values */\n-\t\tnfp_net_stats_reset(eth_dev);\n-\t}\n+\t/* Registering LSC interrupt handler */\n+\trte_intr_callback_register(pci_dev->intr_handle,\n+\t\t\tnfp_net_dev_interrupt_handler, (void *)eth_dev);\n+\t/* Telling the firmware about the LSC interrupt entry */\n+\tnn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX);\n+\t/* Recording current stats counters values */\n+\tnfp_net_stats_reset(eth_dev);\n \n \treturn 0;\n-\n-dev_err_queues_map:\n-\t\tnfp_cpp_area_free(hw->hwqueues_area);\n-dev_err_ctrl_map:\n-\t\tnfp_cpp_area_free(hw->ctrl_area);\n-\n-\treturn err;\n }\n \n #define DEFAULT_FW_PATH \"/lib/firmware/netronome\"\n@@ -820,7 +804,6 @@\n \t\thw->eth_dev = eth_dev;\n \t\thw->idx = i;\n \t\thw->nfp_idx = nfp_eth_table->ports[i].index;\n-\t\thw->is_phyport = true;\n \n \t\teth_dev->device = &pf_dev->pci_dev->device;\n \n@@ -886,8 +869,7 @@\n \n \tif (cpp == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"A CPP handle can not be obtained\");\n-\t\tret = -EIO;\n-\t\tgoto error;\n+\t\treturn -EIO;\n \t}\n \n \thwinfo = nfp_hwinfo_read(cpp);\n@@ -1008,7 +990,7 @@\n \tfree(hwinfo);\n cpp_cleanup:\n \tnfp_cpp_free(cpp);\n-error:\n+\n \treturn ret;\n }\n \n", "prefixes": [ "v9", "02/12" ] }