Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116129/?format=api
http://patches.dpdk.org/api/patches/116129/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220909093523.471727-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220909093523.471727-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220909093523.471727-5-bruce.richardson@intel.com", "date": "2022-09-09T09:35:14", "name": "[v3,04/13] test/telemetry_json: add test for string character escaping", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "81f520ee90b9229cc37a818550f99be2e978be91", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220909093523.471727-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 24617, "url": "http://patches.dpdk.org/api/series/24617/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24617", "date": "2022-09-09T09:35:13", "name": "telemetry JSON escaping and other enhancements", "version": 3, "mbox": "http://patches.dpdk.org/series/24617/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116129/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/116129/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 07B3CA00C5;\n\tFri, 9 Sep 2022 11:35:57 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8835E42802;\n\tFri, 9 Sep 2022 11:35:49 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id BF6B44003F\n for <dev@dpdk.org>; Fri, 9 Sep 2022 11:35:44 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Sep 2022 02:35:44 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.161])\n by orsmga004.jf.intel.com with ESMTP; 09 Sep 2022 02:35:43 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1662716144; x=1694252144;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=gZWLrdtU0OzHT+9MXNKB2CVPrd9knLEq6KTVr/zgowQ=;\n b=PfoYLQmwPrRXOIGB7tCqJrki974YhLBFgJzqcFqucdCfMR2o/IMRJbH6\n H1Y7PJIJ1zrAsB3ClNptEXYuPduJJ0I5vcbtDcStKN3PokEwKlVp7Dvs+\n 8fM6aUaTOPL/HBM/P2QHPcxl+8nXQV8rSNOfJLZ9npvG1NyeShZf1APVm\n 0hrEjV5/f2cFv5p6DnGo6Oe13eQDjeyk8wz5nCoQJ14gG9RNqU2CvT+xi\n zFXt4YLg55orhRupKSYIyjhdtmhSRFKAc3dgD1viwLEsgfG7FeDDL+s8T\n s/1TAq0psZiZCTwh1wRDidYM3VTx/H9rURO11qd+3xe+zh+fVBGcXH6ck g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10464\"; a=\"297437123\"", "E=Sophos;i=\"5.93,302,1654585200\"; d=\"scan'208\";a=\"297437123\"", "E=Sophos;i=\"5.93,302,1654585200\"; d=\"scan'208\";a=\"740996364\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Ciara Power <ciara.power@intel.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>", "Subject": "[PATCH v3 04/13] test/telemetry_json: add test for string character\n escaping", "Date": "Fri, 9 Sep 2022 10:35:14 +0100", "Message-Id": "<20220909093523.471727-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220909093523.471727-1-bruce.richardson@intel.com>", "References": "<20220623164245.561371-1-bruce.richardson@intel.com>\n <20220909093523.471727-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add unit test to validate that when creating a string response in json,\nthat characters such as \\n or quotes are properly escaped.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Ciara Power <ciara.power@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n app/test/test_telemetry_json.c | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)", "diff": "diff --git a/app/test/test_telemetry_json.c b/app/test/test_telemetry_json.c\nindex 748b7cfe5a..955c2e5b1b 100644\n--- a/app/test/test_telemetry_json.c\n+++ b/app/test/test_telemetry_json.c\n@@ -125,6 +125,22 @@ test_large_obj_element(void)\n \treturn strncmp(expected, buf, sizeof(buf));\n }\n \n+static int\n+test_string_char_escaping(void)\n+{\n+\tstatic const char str[] = \"A string across\\ntwo lines and \\\"with quotes\\\"!\";\n+\tconst char *expected = \"\\\"A string across\\\\ntwo lines and \\\\\\\"with quotes\\\\\\\"!\\\"\";\n+\tchar buf[sizeof(str) + 10];\n+\tint used = 0;\n+\n+\tused = rte_tel_json_str(buf, sizeof(buf), used, str);\n+\tprintf(\"%s: buf = '%s', expected = '%s'\\n\", __func__, buf, expected);\n+\tif (used != (int)strlen(expected))\n+\t\treturn -1;\n+\n+\treturn strncmp(expected, buf, sizeof(buf));\n+}\n+\n typedef int (*test_fn)(void);\n \n static int\n@@ -138,6 +154,7 @@ test_telemetry_json(void)\n \t\t\ttest_overflow_obj,\n \t\t\ttest_large_array_element,\n \t\t\ttest_large_obj_element,\n+\t\t\ttest_string_char_escaping,\n \t};\n \tfor (i = 0; i < RTE_DIM(fns); i++)\n \t\tif (fns[i]() == 0)\n", "prefixes": [ "v3", "04/13" ] }{ "id": 116129, "url": "