Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116109/?format=api
{ "id": 116109, "url": "http://patches.dpdk.org/api/patches/116109/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1662674301-30146-1-git-send-email-longli@linuxonhyperv.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1662674301-30146-1-git-send-email-longli@linuxonhyperv.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1662674301-30146-1-git-send-email-longli@linuxonhyperv.com", "date": "2022-09-08T21:58:21", "name": "[v8,07/18] net/mana: add function to configure RSS", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "95dea98959d1657f5a8a7f4a1b30de769eadf989", "submitter": { "id": 1784, "url": "http://patches.dpdk.org/api/people/1784/?format=api", "name": "Long Li", "email": "longli@linuxonhyperv.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1662674301-30146-1-git-send-email-longli@linuxonhyperv.com/mbox/", "series": [ { "id": 24612, "url": "http://patches.dpdk.org/api/series/24612/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24612", "date": "2022-09-08T21:54:40", "name": "Introduce Microsoft Azure Network Adatper (MANA) PMD", "version": 8, "mbox": "http://patches.dpdk.org/series/24612/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116109/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/116109/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6466CA0548;\n\tThu, 8 Sep 2022 23:58:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 57EC342836;\n\tThu, 8 Sep 2022 23:58:24 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 2FDA742829\n for <dev@dpdk.org>; Thu, 8 Sep 2022 23:58:23 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1004)\n id 902E920B929D; Thu, 8 Sep 2022 14:58:22 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 902E920B929D", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com;\n s=default; t=1662674302;\n bh=noA5dm8OPbiDcaKp0GsqJIOTNSvNkeCVui3aR2JJksE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:Reply-To:From;\n b=J2GkmhZaROit2jltVGL8/BN3QMKkq0GFXn2/6PdXdLU9+WfCkxhARDZOl7Sfl09yu\n mWHX4K4bRsF8TNeCLSnF7tmCF2o806Ywg5yJ2C7jeyYt79ba0WS6zLdr03Lq+QmmCf\n vMM1Bxv5LAQrfxD9fzJiuhzSfxNtWLQjy18ND24Q=", "From": "longli@linuxonhyperv.com", "To": "Ferruh Yigit <ferruh.yigit@xilinx.com>", "Cc": "dev@dpdk.org, Ajay Sharma <sharmaajay@microsoft.com>,\n Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>", "Subject": "[Patch v8 07/18] net/mana: add function to configure RSS", "Date": "Thu, 8 Sep 2022 14:58:21 -0700", "Message-Id": "<1662674301-30146-1-git-send-email-longli@linuxonhyperv.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1662169260-4953-8-git-send-email-longli@linuxonhyperv.com>", "References": "<1662169260-4953-8-git-send-email-longli@linuxonhyperv.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Reply-To": "longli@microsoft.com", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Li <longli@microsoft.com>\n\nCurrently this PMD supports RSS configuration when the device is stopped.\nConfiguring RSS in running state will be supported in the future.\n\nSigned-off-by: Long Li <longli@microsoft.com>\n---\nchange log:\nv8:\nfix coding sytle to function definitions\n\n doc/guides/nics/features/mana.ini | 1 +\n drivers/net/mana/mana.c | 65 ++++++++++++++++++++++++++++++-\n drivers/net/mana/mana.h | 1 +\n 3 files changed, 66 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/features/mana.ini\nindex 566b3e8770..a59c21cc10 100644\n--- a/doc/guides/nics/features/mana.ini\n+++ b/doc/guides/nics/features/mana.ini\n@@ -8,6 +8,7 @@ Link status = P\n Linux = Y\n Multiprocess aware = Y\n Removal event = Y\n+RSS hash = Y\n Speed capabilities = P\n Usage doc = Y\n x86-64 = Y\ndiff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c\nindex 9610782d6f..fe7eb19626 100644\n--- a/drivers/net/mana/mana.c\n+++ b/drivers/net/mana/mana.c\n@@ -221,9 +221,70 @@ mana_supported_ptypes(struct rte_eth_dev *dev __rte_unused)\n \treturn ptypes;\n }\n \n+static int\n+mana_rss_hash_update(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct mana_priv *priv = dev->data->dev_private;\n+\n+\t/* Currently can only update RSS hash when device is stopped */\n+\tif (dev->data->dev_started) {\n+\t\tDRV_LOG(ERR, \"Can't update RSS after device has started\");\n+\t\treturn -ENODEV;\n+\t}\n+\n+\tif (rss_conf->rss_hf & ~MANA_ETH_RSS_SUPPORT) {\n+\t\tDRV_LOG(ERR, \"Port %u invalid RSS HF 0x%\" PRIx64,\n+\t\t\tdev->data->port_id, rss_conf->rss_hf);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (rss_conf->rss_key && rss_conf->rss_key_len) {\n+\t\tif (rss_conf->rss_key_len != TOEPLITZ_HASH_KEY_SIZE_IN_BYTES) {\n+\t\t\tDRV_LOG(ERR, \"Port %u key len must be %u long\",\n+\t\t\t\tdev->data->port_id,\n+\t\t\t\tTOEPLITZ_HASH_KEY_SIZE_IN_BYTES);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tpriv->rss_conf.rss_key_len = rss_conf->rss_key_len;\n+\t\tpriv->rss_conf.rss_key =\n+\t\t\trte_zmalloc(\"mana_rss\", rss_conf->rss_key_len,\n+\t\t\t\t RTE_CACHE_LINE_SIZE);\n+\t\tif (!priv->rss_conf.rss_key)\n+\t\t\treturn -ENOMEM;\n+\t\tmemcpy(priv->rss_conf.rss_key, rss_conf->rss_key,\n+\t\t rss_conf->rss_key_len);\n+\t}\n+\tpriv->rss_conf.rss_hf = rss_conf->rss_hf;\n+\n+\treturn 0;\n+}\n+\n+static int\n+mana_rss_hash_conf_get(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct mana_priv *priv = dev->data->dev_private;\n+\n+\tif (!rss_conf)\n+\t\treturn -EINVAL;\n+\n+\tif (rss_conf->rss_key &&\n+\t rss_conf->rss_key_len >= priv->rss_conf.rss_key_len) {\n+\t\tmemcpy(rss_conf->rss_key, priv->rss_conf.rss_key,\n+\t\t priv->rss_conf.rss_key_len);\n+\t}\n+\n+\trss_conf->rss_key_len = priv->rss_conf.rss_key_len;\n+\trss_conf->rss_hf = priv->rss_conf.rss_hf;\n+\n+\treturn 0;\n+}\n+\n static int\n mana_dev_link_update(struct rte_eth_dev *dev,\n-\t\t int wait_to_complete __rte_unused)\n+\t\t\t\tint wait_to_complete __rte_unused)\n {\n \tstruct rte_eth_link link;\n \n@@ -243,6 +304,8 @@ static const struct eth_dev_ops mana_dev_ops = {\n \t.dev_close\t\t= mana_dev_close,\n \t.dev_infos_get\t\t= mana_dev_info_get,\n \t.dev_supported_ptypes_get = mana_supported_ptypes,\n+\t.rss_hash_update\t= mana_rss_hash_update,\n+\t.rss_hash_conf_get\t= mana_rss_hash_conf_get,\n \t.link_update\t\t= mana_dev_link_update,\n };\n \ndiff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h\nindex 4a84c6e778..04ccdfa0d1 100644\n--- a/drivers/net/mana/mana.h\n+++ b/drivers/net/mana/mana.h\n@@ -71,6 +71,7 @@ struct mana_priv {\n \tuint8_t ind_table_key[40];\n \tstruct ibv_qp *rwq_qp;\n \tvoid *db_page;\n+\tstruct rte_eth_rss_conf rss_conf;\n \tstruct rte_intr_handle *intr_handle;\n \tint max_rx_queues;\n \tint max_tx_queues;\n", "prefixes": [ "v8", "07/18" ] }