Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116104/?format=api
{ "id": 116104, "url": "http://patches.dpdk.org/api/patches/116104/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1662674247-29741-1-git-send-email-longli@linuxonhyperv.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1662674247-29741-1-git-send-email-longli@linuxonhyperv.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1662674247-29741-1-git-send-email-longli@linuxonhyperv.com", "date": "2022-09-08T21:57:27", "name": "[v8,02/18] net/mana: add device configuration and stop", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1de0d98cfed6964c02f7f7db747bc598b4f86198", "submitter": { "id": 1784, "url": "http://patches.dpdk.org/api/people/1784/?format=api", "name": "Long Li", "email": "longli@linuxonhyperv.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1662674247-29741-1-git-send-email-longli@linuxonhyperv.com/mbox/", "series": [ { "id": 24612, "url": "http://patches.dpdk.org/api/series/24612/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24612", "date": "2022-09-08T21:54:40", "name": "Introduce Microsoft Azure Network Adatper (MANA) PMD", "version": 8, "mbox": "http://patches.dpdk.org/series/24612/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116104/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/116104/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 33529A0548;\n\tThu, 8 Sep 2022 23:57:31 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 21BAF42685;\n\tThu, 8 Sep 2022 23:57:31 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id B7567410FB\n for <dev@dpdk.org>; Thu, 8 Sep 2022 23:57:28 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1004)\n id 1B336204A59D; Thu, 8 Sep 2022 14:57:28 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 1B336204A59D", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com;\n s=default; t=1662674248;\n bh=0Prn5OkOUzMztPvHRzd8hzjdwpA0AxBiUDR3Mp5GvWM=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:Reply-To:From;\n b=Kw9JKlXIOmnwp5g7wer7MWiUQGZbjC5Ku5H/ZYPdHioWOzK807Solapeca5FA/0K2\n 0vpgXaJ282DM7Y7J5qtKl+X2YIaHNxHwqUX97U/DsEBLvwL+DNVNUTW9z0nmBDS7SZ\n Vuk6oidMgVo2aRxAkk9kYivOVAKOWYcXe7lIji/c=", "From": "longli@linuxonhyperv.com", "To": "Ferruh Yigit <ferruh.yigit@xilinx.com>", "Cc": "dev@dpdk.org, Ajay Sharma <sharmaajay@microsoft.com>,\n Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>", "Subject": "[Patch v8 02/18] net/mana: add device configuration and stop", "Date": "Thu, 8 Sep 2022 14:57:27 -0700", "Message-Id": "<1662674247-29741-1-git-send-email-longli@linuxonhyperv.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1662169260-4953-3-git-send-email-longli@linuxonhyperv.com>", "References": "<1662169260-4953-3-git-send-email-longli@linuxonhyperv.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Reply-To": "longli@microsoft.com", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Li <longli@microsoft.com>\n\nMANA defines its memory allocation functions to override IB layer default\nfunctions to allocate device queues. This patch adds the code for device\nconfiguration and stop.\n\nSigned-off-by: Long Li <longli@microsoft.com>\n---\nv2:\nRemoved validation for offload settings in mana_dev_configure().\nv8:\nFix coding style to function definitions.\n\n drivers/net/mana/mana.c | 81 ++++++++++++++++++++++++++++++++++++++++-\n drivers/net/mana/mana.h | 3 ++\n 2 files changed, 82 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c\nindex 8b9fa9bd07..d522294bd0 100644\n--- a/drivers/net/mana/mana.c\n+++ b/drivers/net/mana/mana.c\n@@ -42,7 +42,85 @@ static rte_spinlock_t mana_shared_data_lock = RTE_SPINLOCK_INITIALIZER;\n int mana_logtype_driver;\n int mana_logtype_init;\n \n+/*\n+ * Callback from rdma-core to allocate a buffer for a queue.\n+ */\n+void *\n+mana_alloc_verbs_buf(size_t size, void *data)\n+{\n+\tvoid *ret;\n+\tsize_t alignment = rte_mem_page_size();\n+\tint socket = (int)(uintptr_t)data;\n+\n+\tDRV_LOG(DEBUG, \"size=%zu socket=%d\", size, socket);\n+\n+\tif (alignment == (size_t)-1) {\n+\t\tDRV_LOG(ERR, \"Failed to get mem page size\");\n+\t\trte_errno = ENOMEM;\n+\t\treturn NULL;\n+\t}\n+\n+\tret = rte_zmalloc_socket(\"mana_verb_buf\", size, alignment, socket);\n+\tif (!ret && size)\n+\t\trte_errno = ENOMEM;\n+\treturn ret;\n+}\n+\n+void\n+mana_free_verbs_buf(void *ptr, void *data __rte_unused)\n+{\n+\trte_free(ptr);\n+}\n+\n+static int\n+mana_dev_configure(struct rte_eth_dev *dev)\n+{\n+\tstruct mana_priv *priv = dev->data->dev_private;\n+\tstruct rte_eth_conf *dev_conf = &dev->data->dev_conf;\n+\n+\tif (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)\n+\t\tdev_conf->rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;\n+\n+\tif (dev->data->nb_rx_queues != dev->data->nb_tx_queues) {\n+\t\tDRV_LOG(ERR, \"Only support equal number of rx/tx queues\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (!rte_is_power_of_2(dev->data->nb_rx_queues)) {\n+\t\tDRV_LOG(ERR, \"number of TX/RX queues must be power of 2\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tpriv->num_queues = dev->data->nb_rx_queues;\n+\n+\tmanadv_set_context_attr(priv->ib_ctx, MANADV_CTX_ATTR_BUF_ALLOCATORS,\n+\t\t\t\t(void *)((uintptr_t)&(struct manadv_ctx_allocators){\n+\t\t\t\t\t.alloc = &mana_alloc_verbs_buf,\n+\t\t\t\t\t.free = &mana_free_verbs_buf,\n+\t\t\t\t\t.data = 0,\n+\t\t\t\t}));\n+\n+\treturn 0;\n+}\n+\n+static int\n+mana_dev_close(struct rte_eth_dev *dev)\n+{\n+\tstruct mana_priv *priv = dev->data->dev_private;\n+\tint ret;\n+\n+\tret = ibv_close_device(priv->ib_ctx);\n+\tif (ret) {\n+\t\tret = errno;\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static const struct eth_dev_ops mana_dev_ops = {\n+\t.dev_configure\t\t= mana_dev_configure,\n+\t.dev_close\t\t= mana_dev_close,\n };\n \n static const struct eth_dev_ops mana_dev_secondary_ops = {\n@@ -649,8 +727,7 @@ mana_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n static int\n mana_dev_uninit(struct rte_eth_dev *dev)\n {\n-\tRTE_SET_USED(dev);\n-\treturn 0;\n+\treturn mana_dev_close(dev);\n }\n \n /*\ndiff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h\nindex 098819e61e..d4a2fe7603 100644\n--- a/drivers/net/mana/mana.h\n+++ b/drivers/net/mana/mana.h\n@@ -204,4 +204,7 @@ int mana_mp_req_verbs_cmd_fd(struct rte_eth_dev *dev);\n \n void mana_mp_req_on_rxtx(struct rte_eth_dev *dev, enum mana_mp_req_type type);\n \n+void *mana_alloc_verbs_buf(size_t size, void *data);\n+void mana_free_verbs_buf(void *ptr, void *data __rte_unused);\n+\n #endif\n", "prefixes": [ "v8", "02/18" ] }