Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116085/?format=api
{ "id": 116085, "url": "http://patches.dpdk.org/api/patches/116085/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1662626702-17254-3-git-send-email-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1662626702-17254-3-git-send-email-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1662626702-17254-3-git-send-email-chaoyong.he@corigine.com", "date": "2022-09-08T08:44:52", "name": "[v8,02/12] net/nfp: simplify initialization and remove dead code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "91110f55f952e05c5859126410a9b806c452c426", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1662626702-17254-3-git-send-email-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 24607, "url": "http://patches.dpdk.org/api/series/24607/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24607", "date": "2022-09-08T08:44:50", "name": "preparation for the rte_flow offload of nfp PMD", "version": 8, "mbox": "http://patches.dpdk.org/series/24607/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/116085/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/116085/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 56B2BA0548;\n\tThu, 8 Sep 2022 10:45:44 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7269142825;\n\tThu, 8 Sep 2022 10:45:33 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2099.outbound.protection.outlook.com [40.107.223.99])\n by mails.dpdk.org (Postfix) with ESMTP id 37E5A40DDC\n for <dev@dpdk.org>; Thu, 8 Sep 2022 10:45:31 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MW4PR13MB5940.namprd13.prod.outlook.com (2603:10b6:303:1b8::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.3; Thu, 8 Sep\n 2022 08:45:29 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::402d:6abc:83a8:2431]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::402d:6abc:83a8:2431%6]) with mapi id 15.20.5612.009; Thu, 8 Sep 2022\n 08:45:29 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=HqYUWCh+Ean9laJJE0ZPBnLdyIVjaMOf5P9OBBw3ADckx+Q/9+HSlN9YRO3cyCid6orIdZYoWRad9DgUr8is2YAGmE5yK9dAOpaZdcxGbtulQ/ssWvQ/2omWXK0f4JbyXQQOVRCBWNLkhhAU5BiaVcTK95amT3YsLAbdDXDy4ttLyo4XuoxtD6ZtmaChkAaFbuLyvcnYeM74Gka8PdAirtRgKPLiuWf/tBHZ11NLy+nAnKRzRBxsGEM5a4vUafUv8QqEmSjpz/PyXRJD5EOiQGDKpxaiR4x/N49T5mL4Wd+pYiS1JmQq2QmttDUhmLNWLqjGI8vnm22wg56SuP+44A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=xP/CmDEncw6XGBuIdANFTIgXXl67DvdBTi7ml6Xme/g=;\n b=W1+Q3oCAjk7h1qPqghcBe7742HWTU+YEJpsqkqtc2a6H4WdQpH/llUAbkETuEFuhBuOb338oBJtwdf4slUkaKWdI8UTVNblt2bTzbDIcHV4EF+lEU+bs11Baq4Nb8WxMXTMzD2AWd6ydY509mpptKAbA44QsllWXyCB/gyJUz+CMBYUBvu+zOCWXOstHuaz3xpBmOt5qgLXH5Ha0STnpUVjmXjIb6BlrNFxnqmyL5uuFE4rGQk5ZJpnfimSpaFj04Z/mmGfx2sbfU/ansCVXaYGC5LUaWMy2tAL/Lobd30tDjTnbi6iHnXXmRg3xI+rvhNxHkh372GjrNxtaemhKHQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xP/CmDEncw6XGBuIdANFTIgXXl67DvdBTi7ml6Xme/g=;\n b=Jnqrvn3SgW7rAexs8cNXWGnakjZM6e7PYluR8gt4OaO/Di2443MIj/Ec2tznPceydu7ahPLAcxUBR5A/S/UwC8d7Z8pc9VppvLXj0DpLXfzzEb2JBCnV9m82eHKobFQPDr5KCSzsaZ8mDkIkFFFFfarES6AE4k2nSqJBs7juwhQ=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, niklas.soderlund@corigine.com,\n Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH v8 02/12] net/nfp: simplify initialization and remove dead\n code", "Date": "Thu, 8 Sep 2022 16:44:52 +0800", "Message-Id": "<1662626702-17254-3-git-send-email-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1662626702-17254-1-git-send-email-chaoyong.he@corigine.com>", "References": "<1662626702-17254-1-git-send-email-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "SI2PR01CA0023.apcprd01.prod.exchangelabs.com\n (2603:1096:4:192::17) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|MW4PR13MB5940:EE_", "X-MS-Office365-Filtering-Correlation-Id": "978360b9-21ee-491a-6fa2-08da91767bc1", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n UwgQquiyhnEd4JS4jsQ9X+NLqYX5OHErCu5W1kXOk7CFwythRclnbJ7bHPeORKdlUuAeH21DtFkD1fqzcS24b78MBT5mDMmr/1+LKahV/YovKgP3ow1nouroM2cIXuEyhd2uN5YOcwGoDaVhSJVkzS2jWLXlspwxs2SmiJo5JxjkzDA4+1ihNvQzK9eUDPoUsLcKY/qnPHgWrx7kEa5aPuXMov0S9nhLeDfRZ9ii1o82hiUOSxzwVBQPJqROJgKYSlRAM4By0U/KQCJE/GLWlLzHuYNFidIl6mvvZGMvzuBhQBwgnZMW8Pq3t3pjTMrQsKBPazUOzviukgbGolcuWS0nGAnM854AuXLiBcjhs9S/LEU4DlBT4ciW4pRYkJjDHk522UoNJmiMkdYJmmg22EBHepbcFcVbc01f2UUVc3i1NihUpbMohKDSfrUsuJAxqznUbZA6GcbsD13sBlowkI4TF8r4qx4Z2APJGiz6tzT18aBS5vjrfPwIQuV3g8oExmzmaV/+HpIQZGABdkWRSEUNdpdsIckIc5UaQdL3lhDhgevAfI8mILaovpTfEYENCl6Gx42pZeBp/hGwYISgQZOzH7tp/1NeSId3v7cKjOgPimn8dZUl75p6Rvqt7jntukh4pZ225ZpXJmeqaunU4Eq/w8lvSv6L6I4+g/b/vy1CQqNTutHbkN3f0vlMAeBCzd8LS0UI5hKiye3vSJvg69ibQV8qsXedFiuYbdOuqfbGJEcj/7qWqbyysyGqAsBXpRPIxkuW8UiXyzpIk4pwKA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230016)(4636009)(396003)(366004)(39840400004)(346002)(376002)(136003)(107886003)(44832011)(2616005)(41300700001)(6916009)(38350700002)(83380400001)(26005)(6512007)(186003)(36756003)(38100700002)(4326008)(2906002)(6506007)(316002)(66946007)(478600001)(86362001)(5660300002)(66476007)(52116002)(6486002)(6666004)(8936002)(8676002)(66556008);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?jvN9jTzJta/itJQC/rQNbwcM0bW/?=\n\t=?utf-8?q?fpNxhucBnmg8Q+JPbRAgecY8eHhVHf3CiA4CvjnFM9+Npxo6F3kcowf53/n4GarHM?=\n\t=?utf-8?q?OOkuU17S7XBuRPMmS23BOfT9icJCVfIEWK/wFfItnMS0PO2w+bevtcT1PrptDSoi3?=\n\t=?utf-8?q?hnm0s2K1anoRa6HBAv4QLE4pTrMIc043RDVMlgNeJiz/C0YG+A7Sd8g8W2clGnxnV?=\n\t=?utf-8?q?oXyBb9nD7DXslY/DLKC/78eKkXucC52kDPtu3+Jy4tRu7bS10yfhIqdP/5Phfb85M?=\n\t=?utf-8?q?0hLA2AT6KJ8VIekdQ3dGWEf88dnJWJUO1WkJZp7WDAM5GS3aBLCoOq37M0xGf+GBP?=\n\t=?utf-8?q?WvcJQ7iIMRt2Sc3yKEkG2jzPWM2xBlQQ+lzBfJeA4QziRAkYgoCCg1H0xQGeXrJdq?=\n\t=?utf-8?q?02W4gnUwhSH1ZXsqjd6yRgF65pkVtAW1Bc0FkvUwPhgyWrVq0GQhOjwVPhreoMvJU?=\n\t=?utf-8?q?dNk5tfEHkA9dC/yQYGF1gHnwpnsgFFumEQzgSn1w8kmSynUFtKYjx5na5OkGyLe3w?=\n\t=?utf-8?q?pRT9WHSGeEcG7y1ywAJUhQRMaqUTvRJVPIksjN1RK7UCNLrX6lwajEJz0oe/enSc9?=\n\t=?utf-8?q?RxIuvAoemyhRGCte2f8sU93lY9J9KRDFD2hVi3PE7OyYHZiBcKTFuc/hzhzkAKfwo?=\n\t=?utf-8?q?6h+4YhKE4K4ZiT6DWZJz2zyifT9jI7UhjD7f/WkmQMhqNXckxYizabmk2TBb3/fRY?=\n\t=?utf-8?q?bdIpjB0C8JdE37tyCba9Aa9Bz/55iJ3Sle/ivIwG+DMIfEYdJMaXF69nD3eY1KUJT?=\n\t=?utf-8?q?GW9k1XVwmdoyVyGSq3cIadoYkkGkryUBTmjAVLg1Tc4NhGtHbNXTCQaxG6SEdtBNI?=\n\t=?utf-8?q?lXJ3GsWEnXp5SJ/eA4zz7NCm7ONTRb9o1eBXpIdmfbH2OsAUGsMu9i85HpDF4Je12?=\n\t=?utf-8?q?GHEnJ8AsZj7OO+TG7c3FEmGt573AUZ1j0N1D1u/aflaizcYCa00szVlYp/K0dj/AW?=\n\t=?utf-8?q?QWM1DXB1C3I2rxB9eWd0LG47ldxx/P2Y2xb1l3zzI784gn6zd9tUYe9Oro8dXfUQL?=\n\t=?utf-8?q?rzZI9a0Ee8pNbQksAD1tAM2goJAwyr/PkJXaTWOMpAykKyBGle5B4EGpA9TKgpQAb?=\n\t=?utf-8?q?v2kIjBhYGbu4RkciNURIy2CDP4PXmRDOY1BDAYwXK4G49ld/lD/akHwR2ib8k/YiD?=\n\t=?utf-8?q?eCebYVpiUNmLidKHUFxw4DY36QKWWkgG7m7KuaU7KbQ5BlCEYWviAAX+LnskUHqaB?=\n\t=?utf-8?q?YJZ79r8b+9LG0nwx98k27A7b7qs4IFPF3IcQKtdddVRd1t+PTHwZZodau0AU3sGad?=\n\t=?utf-8?q?a1n8QQtGvCnPCIxp712eXmFrKQIYRRubdlY8twc+eSIrBOLUz9wPnwWzyxvUXe7ia?=\n\t=?utf-8?q?hC2tpliJVowZbukE9pSnMQUEn2zKRLkWGNrVa2mrYZMuElodMlkY0M6EPEPfjqh1l?=\n\t=?utf-8?q?jL3kCmOvYh4ZRfHDdBFz8B2Sp8oFFpFqREm+vRKzDBg8GkTw0QnzveFGPQUckIptN?=\n\t=?utf-8?q?toAgjrSHs4Rb20rToqUvyGyAil87xhAROeAo4jsfzJY/whVOewjU8j8nnl/ZWPEfr?=\n\t=?utf-8?q?O3JhN1Cys8tq+JBpZkx+6gDluys8HmzNmg=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW4PR13MB5940", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Calling nfp_net_init() is only done for the corenic firmware flavor\nand it is guaranteed to always be called from the primary process,\nso the explicit check for RTE_PROC_PRIMARY can be dropped.\n\nThe calling graph of nfp_net_init() already guaranteed the free of\nresources when it fail, so remove the necessary free logics inside it.\n\nWhile at it remove the unused member is_phyport from struct nfp_net_hw.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfp_common.h | 1 -\n drivers/net/nfp/nfp_ethdev.c | 40 +++++++++++-----------------------------\n 2 files changed, 11 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h\nindex bea5f95..6af8481 100644\n--- a/drivers/net/nfp/nfp_common.h\n+++ b/drivers/net/nfp/nfp_common.h\n@@ -235,7 +235,6 @@ struct nfp_net_hw {\n \tuint8_t idx;\n \t/* Internal port number as seen from NFP */\n \tuint8_t nfp_idx;\n-\tbool\tis_phyport;\n \n \tunion eth_table_entry *eth_table;\n \ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex bd9cf67..955b214 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -417,7 +417,6 @@\n \tuint32_t start_q;\n \tint stride = 4;\n \tint port = 0;\n-\tint err;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -452,10 +451,6 @@\n \tPMD_INIT_LOG(DEBUG, \"Working with physical port number: %d, \"\n \t\t\t\"NFP internal port number: %d\", port, hw->nfp_idx);\n \n-\t/* For secondary processes, the primary has done all the work */\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n-\t\treturn 0;\n-\n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n \n \thw->device_id = pci_dev->id.device_id;\n@@ -506,8 +501,7 @@\n \t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(ERR, \"nfp_net: no device ID matching\");\n-\t\terr = -ENODEV;\n-\t\tgoto dev_err_ctrl_map;\n+\t\treturn -ENODEV;\n \t}\n \n \tPMD_INIT_LOG(DEBUG, \"tx_bar_off: 0x%\" PRIx64 \"\", tx_bar_off);\n@@ -573,8 +567,7 @@\n \t\t\t\t\t RTE_ETHER_ADDR_LEN, 0);\n \tif (eth_dev->data->mac_addrs == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to space for MAC address\");\n-\t\terr = -ENOMEM;\n-\t\tgoto dev_err_queues_map;\n+\t\treturn -ENOMEM;\n \t}\n \n \tnfp_net_pf_read_mac(app_hw_nic, port);\n@@ -604,24 +597,15 @@\n \t\t hw->mac_addr[0], hw->mac_addr[1], hw->mac_addr[2],\n \t\t hw->mac_addr[3], hw->mac_addr[4], hw->mac_addr[5]);\n \n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\t/* Registering LSC interrupt handler */\n-\t\trte_intr_callback_register(pci_dev->intr_handle,\n-\t\t\t\tnfp_net_dev_interrupt_handler, (void *)eth_dev);\n-\t\t/* Telling the firmware about the LSC interrupt entry */\n-\t\tnn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX);\n-\t\t/* Recording current stats counters values */\n-\t\tnfp_net_stats_reset(eth_dev);\n-\t}\n+\t/* Registering LSC interrupt handler */\n+\trte_intr_callback_register(pci_dev->intr_handle,\n+\t\t\tnfp_net_dev_interrupt_handler, (void *)eth_dev);\n+\t/* Telling the firmware about the LSC interrupt entry */\n+\tnn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX);\n+\t/* Recording current stats counters values */\n+\tnfp_net_stats_reset(eth_dev);\n \n \treturn 0;\n-\n-dev_err_queues_map:\n-\t\tnfp_cpp_area_free(hw->hwqueues_area);\n-dev_err_ctrl_map:\n-\t\tnfp_cpp_area_free(hw->ctrl_area);\n-\n-\treturn err;\n }\n \n #define DEFAULT_FW_PATH \"/lib/firmware/netronome\"\n@@ -820,7 +804,6 @@\n \t\thw->eth_dev = eth_dev;\n \t\thw->idx = i;\n \t\thw->nfp_idx = nfp_eth_table->ports[i].index;\n-\t\thw->is_phyport = true;\n \n \t\teth_dev->device = &pf_dev->pci_dev->device;\n \n@@ -886,8 +869,7 @@\n \n \tif (cpp == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"A CPP handle can not be obtained\");\n-\t\tret = -EIO;\n-\t\tgoto error;\n+\t\treturn -EIO;\n \t}\n \n \thwinfo = nfp_hwinfo_read(cpp);\n@@ -1008,7 +990,7 @@\n \tfree(hwinfo);\n cpp_cleanup:\n \tnfp_cpp_free(cpp);\n-error:\n+\n \treturn ret;\n }\n \n", "prefixes": [ "v8", "02/12" ] }