Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 115880,
    "url": "http://patches.dpdk.org/api/patches/115880/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220905085939.22236-12-liudongdong3@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220905085939.22236-12-liudongdong3@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220905085939.22236-12-liudongdong3@huawei.com",
    "date": "2022-09-05T08:59:37",
    "name": "[RESEND,11/13] net/hns3: delete rte unused tag",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "da50ed79c06108e05e2f9b77d45c1272db8213c1",
    "submitter": {
        "id": 2718,
        "url": "http://patches.dpdk.org/api/people/2718/?format=api",
        "name": "Dongdong Liu",
        "email": "liudongdong3@huawei.com"
    },
    "delegate": {
        "id": 3961,
        "url": "http://patches.dpdk.org/api/users/3961/?format=api",
        "username": "arybchenko",
        "first_name": "Andrew",
        "last_name": "Rybchenko",
        "email": "andrew.rybchenko@oktetlabs.ru"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220905085939.22236-12-liudongdong3@huawei.com/mbox/",
    "series": [
        {
            "id": 24533,
            "url": "http://patches.dpdk.org/api/series/24533/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24533",
            "date": "2022-09-05T08:59:26",
            "name": "some bugfixes and clean code for hns3",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/24533/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/115880/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/115880/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 873BCA054A;\n\tMon,  5 Sep 2022 11:02:19 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B1F2042B8C;\n\tMon,  5 Sep 2022 11:01:17 +0200 (CEST)",
            "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 064AB42BB0;\n Mon,  5 Sep 2022 11:01:16 +0200 (CEST)",
            "from kwepemi500017.china.huawei.com (unknown [172.30.72.56])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MLj885Z0vz1P6hB;\n Mon,  5 Sep 2022 16:57:28 +0800 (CST)",
            "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Mon, 5 Sep 2022 17:01:13 +0800"
        ],
        "From": "Dongdong Liu <liudongdong3@huawei.com>",
        "To": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>,\n <ferruh.yigit@xilinx.com>, <thomas@monjalon.net>, <liudongdong3@huawei.com>,\n <lihuisong@huawei.com>, <haijie1@huawei.com>",
        "CC": "<stable@dpdk.org>, <fengchengwen@huawei.com>, <yisen.zhuang@huawei.com>,\n <humin29@huawei.com>",
        "Subject": "[PATCH RESEND 11/13] net/hns3: delete rte unused tag",
        "Date": "Mon, 5 Sep 2022 16:59:37 +0800",
        "Message-ID": "<20220905085939.22236-12-liudongdong3@huawei.com>",
        "X-Mailer": "git-send-email 2.22.0",
        "In-Reply-To": "<20220905085939.22236-1-liudongdong3@huawei.com>",
        "References": "<20220905085939.22236-1-liudongdong3@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.28.79.22]",
        "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n kwepemi500017.china.huawei.com (7.221.188.110)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThe '__rte_unused' tag in the input parameter  of 'hns3_mac_stats_reset'\nis redundant. This patch remove this tag. In addition, this function is\naimed to clear MAC statics. So using 'struct hns3_hw' as input parameter\nis better than 'struct rte_eth_dev', and it also facilitates the call of\nthis function.\n\nFixes: 8839c5e202f3 (\"net/hns3: support device stats\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_stats.c | 22 +++++-----------------\n 1 file changed, 5 insertions(+), 17 deletions(-)",
    "diff": "diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c\nindex 4ec0911522..2ec7a9635e 100644\n--- a/drivers/net/hns3/hns3_stats.c\n+++ b/drivers/net/hns3/hns3_stats.c\n@@ -406,15 +406,6 @@ hns3_query_mac_stats_reg_num(struct hns3_hw *hw)\n \treturn 0;\n }\n \n-static int\n-hns3_query_update_mac_stats(struct rte_eth_dev *dev)\n-{\n-\tstruct hns3_adapter *hns = dev->data->dev_private;\n-\tstruct hns3_hw *hw = &hns->hw;\n-\n-\treturn hns3_update_mac_stats(hw);\n-}\n-\n static int\n hns3_update_port_rpu_drop_stats(struct hns3_hw *hw)\n {\n@@ -763,14 +754,13 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n }\n \n static int\n-hns3_mac_stats_reset(__rte_unused struct rte_eth_dev *dev)\n+hns3_mac_stats_reset(struct hns3_hw *hw)\n {\n-\tstruct hns3_adapter *hns = dev->data->dev_private;\n-\tstruct hns3_hw *hw = &hns->hw;\n \tstruct hns3_mac_stats *mac_stats = &hw->mac_stats;\n \tint ret;\n \n-\tret = hns3_query_update_mac_stats(dev);\n+\t/* Clear hardware MAC statistics by reading it. */\n+\tret = hns3_update_mac_stats(hw);\n \tif (ret) {\n \t\thns3_err(hw, \"Clear Mac stats fail : %d\", ret);\n \t\treturn ret;\n@@ -1063,8 +1053,7 @@ hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \thns3_tqp_basic_stats_get(dev, xstats, &count);\n \n \tif (!hns->is_vf) {\n-\t\t/* Update Mac stats */\n-\t\tret = hns3_query_update_mac_stats(dev);\n+\t\tret = hns3_update_mac_stats(hw);\n \t\tif (ret < 0) {\n \t\t\thns3_err(hw, \"Update Mac stats fail : %d\", ret);\n \t\t\trte_spinlock_unlock(&hw->stats_lock);\n@@ -1482,8 +1471,7 @@ hns3_dev_xstats_reset(struct rte_eth_dev *dev)\n \tif (hns->is_vf)\n \t\tgoto out;\n \n-\t/* HW registers are cleared on read */\n-\tret = hns3_mac_stats_reset(dev);\n+\tret = hns3_mac_stats_reset(hw);\n \n out:\n \trte_spinlock_unlock(&hw->stats_lock);\n",
    "prefixes": [
        "RESEND",
        "11/13"
    ]
}