Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115877/?format=api
{ "id": 115877, "url": "http://patches.dpdk.org/api/patches/115877/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220905085939.22236-8-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220905085939.22236-8-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220905085939.22236-8-liudongdong3@huawei.com", "date": "2022-09-05T08:59:33", "name": "[RESEND,07/13] net/hns3: fix next-to-use overflow when using SVE xmit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ad4ad1df7f0b689939b59e5cd4c65d385c84fad4", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220905085939.22236-8-liudongdong3@huawei.com/mbox/", "series": [ { "id": 24533, "url": "http://patches.dpdk.org/api/series/24533/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24533", "date": "2022-09-05T08:59:26", "name": "some bugfixes and clean code for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/24533/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115877/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115877/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5AAB4A054A;\n\tMon, 5 Sep 2022 11:01:54 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5DB2142B93;\n\tMon, 5 Sep 2022 11:01:13 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 6C5C84281B;\n Mon, 5 Sep 2022 11:01:09 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.55])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MLj82000vzkWxw;\n Mon, 5 Sep 2022 16:57:21 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Mon, 5 Sep 2022 17:01:07 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>,\n <ferruh.yigit@xilinx.com>, <thomas@monjalon.net>, <liudongdong3@huawei.com>,\n <lihuisong@huawei.com>, <haijie1@huawei.com>", "CC": "<stable@dpdk.org>, <fengchengwen@huawei.com>, <yisen.zhuang@huawei.com>,\n <humin29@huawei.com>", "Subject": "[PATCH RESEND 07/13] net/hns3: fix next-to-use overflow when using\n SVE xmit", "Date": "Mon, 5 Sep 2022 16:59:33 +0800", "Message-ID": "<20220905085939.22236-8-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220905085939.22236-1-liudongdong3@huawei.com>", "References": "<20220905085939.22236-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nIf txq's next-to-use plus nb_pkts equal txq's nb_tx_desc when using\nSVE xmit algorithm, the txq's next-to-use will equal nb_tx_desc after\nthe xmit, this does not cause Tx exceptions, but may affect other ops\nthat depend on this field, such as tx_descriptor_status.\n\nThis patch fixes it.\n\nFixes: f0c243a6cb6f (\"net/hns3: support SVE Tx\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx_vec_sve.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c\nindex b0dfb052bb..f09a81dbd5 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec_sve.c\n+++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c\n@@ -464,14 +464,16 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict tx_queue,\n \t\treturn 0;\n \t}\n \n-\tif (txq->next_to_use + nb_pkts > txq->nb_tx_desc) {\n+\tif (txq->next_to_use + nb_pkts >= txq->nb_tx_desc) {\n \t\tnb_tx = txq->nb_tx_desc - txq->next_to_use;\n \t\thns3_tx_fill_hw_ring_sve(txq, tx_pkts, nb_tx);\n \t\ttxq->next_to_use = 0;\n \t}\n \n-\thns3_tx_fill_hw_ring_sve(txq, tx_pkts + nb_tx, nb_pkts - nb_tx);\n-\ttxq->next_to_use += nb_pkts - nb_tx;\n+\tif (nb_pkts > nb_tx) {\n+\t\thns3_tx_fill_hw_ring_sve(txq, tx_pkts + nb_tx, nb_pkts - nb_tx);\n+\t\ttxq->next_to_use += nb_pkts - nb_tx;\n+\t}\n \n \ttxq->tx_bd_ready -= nb_pkts;\n \thns3_write_txq_tail_reg(txq, nb_pkts);\n", "prefixes": [ "RESEND", "07/13" ] }