Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115862/?format=api
{ "id": 115862, "url": "http://patches.dpdk.org/api/patches/115862/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220905083933.2506819-23-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220905083933.2506819-23-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220905083933.2506819-23-david.marchand@redhat.com", "date": "2022-09-05T08:39:28", "name": "[v5,22/27] dev: introduce driver accessors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "05560bcd8c0c8b24379c010db301b92ba78cb921", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220905083933.2506819-23-david.marchand@redhat.com/mbox/", "series": [ { "id": 24531, "url": "http://patches.dpdk.org/api/series/24531/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24531", "date": "2022-09-05T08:39:07", "name": "[v5,01/27] devtools: forbid inclusions of driver only headers", "version": 5, "mbox": "http://patches.dpdk.org/series/24531/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115862/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115862/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BF266A054A;\n\tMon, 5 Sep 2022 10:42:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A0A2342BAB;\n\tMon, 5 Sep 2022 10:41:25 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 3936B42BAB\n for <dev@dpdk.org>; Mon, 5 Sep 2022 10:41:24 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-593-ntf18eoYON-94dz3rB-7ZA-1; Mon, 05 Sep 2022 04:41:20 -0400", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com\n [10.11.54.5])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2FE6F84AF83;\n Mon, 5 Sep 2022 08:41:20 +0000 (UTC)", "from fchome.redhat.com (unknown [10.40.193.251])\n by smtp.corp.redhat.com (Postfix) with ESMTP id A91C89458A;\n Mon, 5 Sep 2022 08:41:18 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1662367283;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=fF6xC36YNmEG449oSchF93jcfFNNWhENlo+2dnTezXM=;\n b=VG0uob/7WWfVMJcNVMgOwnijIRO/YRe3tlSH6ckXA15qeI3zblQfOIL8TVeahDh9RR45TK\n CL0jlpFjaKPKGgWN+i9ZEYGScNkZ2miC4JuIbTshJmOquaYQd98adooEbmN2kQimxFnjWL\n PHQMYxNUjp3Aa7LGSscHp1UbS+YeryI=", "X-MC-Unique": "ntf18eoYON-94dz3rB-7ZA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com,\n Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>, Ray Kinsella <mdr@ashroe.eu>,\n Ferruh Yigit <ferruh.yigit@xilinx.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[PATCH v5 22/27] dev: introduce driver accessors", "Date": "Mon, 5 Sep 2022 10:39:28 +0200", "Message-Id": "<20220905083933.2506819-23-david.marchand@redhat.com>", "In-Reply-To": "<20220905083933.2506819-1-david.marchand@redhat.com>", "References": "<20220628144643.1213026-1-david.marchand@redhat.com>\n <20220905083933.2506819-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.11.54.5", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Prepare for making the driver object opaque by adding accessors.\nUpdate existing \"external\" users.\nInternal users may still dereference a rte_driver object.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test-pmd/config.c | 2 +-\n lib/eal/common/eal_common_dev.c | 6 ++++++\n lib/eal/include/rte_dev.h | 15 +++++++++++++++\n lib/eal/version.map | 3 +++\n lib/ethdev/rte_ethdev.h | 2 +-\n 5 files changed, 26 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 7bd28ee3e8..6510f29c76 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -654,7 +654,7 @@ device_infos_display(const char *identifier)\n \t\t\tprintf(\"\\n%s Infos for device %s %s\\n\",\n \t\t\t info_border, dev->name, info_border);\n \t\t\tprintf(\"Bus name: %s\", rte_bus_name(dev->bus));\n-\t\t\tprintf(\"\\nDriver name: %s\", dev->driver->name);\n+\t\t\tprintf(\"\\nDriver name: %s\", rte_driver_name(dev->driver));\n \t\t\tprintf(\"\\nDevargs: %s\",\n \t\t\t dev->devargs ? dev->devargs->args : \"\");\n \t\t\tprintf(\"\\nConnect to socket: %d\", dev->numa_node);\ndiff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c\nindex 62a598957c..16c5aef1d8 100644\n--- a/lib/eal/common/eal_common_dev.c\n+++ b/lib/eal/common/eal_common_dev.c\n@@ -19,6 +19,12 @@\n #include \"eal_private.h\"\n #include \"hotplug_mp.h\"\n \n+const char *\n+rte_driver_name(const struct rte_driver *driver)\n+{\n+\treturn driver->name;\n+}\n+\n /**\n * The device event callback description.\n *\ndiff --git a/lib/eal/include/rte_dev.h b/lib/eal/include/rte_dev.h\nindex 2743c09320..ddea163cca 100644\n--- a/lib/eal/include/rte_dev.h\n+++ b/lib/eal/include/rte_dev.h\n@@ -76,6 +76,21 @@ struct rte_driver {\n \tconst char *alias; /**< Driver alias. */\n };\n \n+/**\n+ * Retrieve a driver name.\n+ *\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n+ * @param driver\n+ * A pointer to a driver structure.\n+ * @return\n+ * A pointer to the driver name string.\n+ */\n+__rte_experimental\n+const char *\n+rte_driver_name(const struct rte_driver *driver);\n+\n /*\n * Internal identifier length\n * Sufficiently large to allow for UUID or PCI address\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex 6ec15f1147..d10fd89458 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -423,6 +423,9 @@ EXPERIMENTAL {\n \trte_thread_self;\n \trte_thread_set_affinity_by_id;\n \trte_thread_set_priority;\n+\n+\t# added in 22.11\n+\trte_driver_name;\n };\n \n INTERNAL {\ndiff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 41d37e41b5..7556b94602 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -3380,7 +3380,7 @@ int rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr *ma,\n * exists for the device and the rte_eth_dev 'dev' has been populated\n * successfully with a call to it:\n *\n- * driver_name = dev->device->driver->name\n+ * driver_name = rte_driver_name(dev->device->driver)\n * nb_rx_queues = dev->data->nb_rx_queues\n * nb_tx_queues = dev->data->nb_tx_queues\n * dev_flags = &dev->data->dev_flags\n", "prefixes": [ "v5", "22/27" ] }