Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115854/?format=api
{ "id": 115854, "url": "http://patches.dpdk.org/api/patches/115854/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220905083933.2506819-15-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220905083933.2506819-15-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220905083933.2506819-15-david.marchand@redhat.com", "date": "2022-09-05T08:39:20", "name": "[v5,14/27] bus/ifpga: cleanup exported symbols", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "92aa369399f6f00f20657a6edabcff34e569a965", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220905083933.2506819-15-david.marchand@redhat.com/mbox/", "series": [ { "id": 24531, "url": "http://patches.dpdk.org/api/series/24531/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24531", "date": "2022-09-05T08:39:07", "name": "[v5,01/27] devtools: forbid inclusions of driver only headers", "version": 5, "mbox": "http://patches.dpdk.org/series/24531/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115854/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115854/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 17F32A054A;\n\tMon, 5 Sep 2022 10:41:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0D8CF42B92;\n\tMon, 5 Sep 2022 10:40:33 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id EDC5F42B8A\n for <dev@dpdk.org>; Mon, 5 Sep 2022 10:40:31 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-235-JGJgDggFMKWeAtDDJzA0Ng-1; Mon, 05 Sep 2022 04:40:28 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 12BD118812C7;\n Mon, 5 Sep 2022 08:40:28 +0000 (UTC)", "from fchome.redhat.com (unknown [10.40.193.251])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D0F641410DD5;\n Mon, 5 Sep 2022 08:40:26 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1662367231;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=JoozlyG1gOXPtOSdSVOas9PrxP0Ix3rkAFuIe5U+vYs=;\n b=LlMtoIJDicmPb9uMe22SIfqDmuA+RvQSsRHhTozcPqPDrasWvZ+WHkzBna2rB1OUcbgUt9\n 9BX32TwZvU3YNqnfjttd8O0S/uiRi/CLG2yXQuWiY3x/WiLpOCgdKRZSum4gtocqnkVywa\n ljm75ENqOwM6XQU6l20LXf/anYwCkp8=", "X-MC-Unique": "JGJgDggFMKWeAtDDJzA0Ng-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com,\n Rosen Xu <rosen.xu@intel.com>, Ray Kinsella <mdr@ashroe.eu>,\n Tianfei zhang <tianfei.zhang@intel.com>", "Subject": "[PATCH v5 14/27] bus/ifpga: cleanup exported symbols", "Date": "Mon, 5 Sep 2022 10:39:20 +0200", "Message-Id": "<20220905083933.2506819-15-david.marchand@redhat.com>", "In-Reply-To": "<20220905083933.2506819-1-david.marchand@redhat.com>", "References": "<20220628144643.1213026-1-david.marchand@redhat.com>\n <20220905083933.2506819-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove unused symbols (exposed only in an internal header which\nguarantees that no application out there relied on them).\n\nRemove rte_ prefix and inline the rest to avoid having to expose them as\nglobal symbols for a relatively small added value.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Rosen Xu <rosen.xu@intel.com>\n---\n drivers/bus/ifpga/ifpga_bus.c | 13 +++--\n drivers/bus/ifpga/ifpga_common.c | 88 --------------------------------\n drivers/bus/ifpga/ifpga_common.h | 54 ++++++++++++++++----\n drivers/bus/ifpga/meson.build | 2 +-\n drivers/bus/ifpga/version.map | 2 -\n drivers/raw/ifpga/ifpga_rawdev.c | 2 +-\n 6 files changed, 53 insertions(+), 108 deletions(-)\n delete mode 100644 drivers/bus/ifpga/ifpga_common.c", "diff": "diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c\nindex e005f2cb70..b1e9eb7cc4 100644\n--- a/drivers/bus/ifpga/ifpga_bus.c\n+++ b/drivers/bus/ifpga/ifpga_bus.c\n@@ -117,9 +117,9 @@ ifpga_scan_one(struct rte_rawdev *rawdev,\n \n \tif (rte_kvargs_count(kvlist, IFPGA_ARG_PORT) == 1) {\n \t\tif (rte_kvargs_process(kvlist, IFPGA_ARG_PORT,\n-\t\t&rte_ifpga_get_integer32_arg, &afu_pr_conf.afu_id.port) < 0) {\n-\t\t\tIFPGA_BUS_ERR(\"error to parse %s\",\n-\t\t\t\t IFPGA_ARG_PORT);\n+\t\t\t\tifpga_get_integer32_arg,\n+\t\t\t\t&afu_pr_conf.afu_id.port) < 0) {\n+\t\t\tIFPGA_BUS_ERR(\"error to parse %s\", IFPGA_ARG_PORT);\n \t\t\tgoto end;\n \t\t}\n \t} else {\n@@ -130,9 +130,8 @@ ifpga_scan_one(struct rte_rawdev *rawdev,\n \n \tif (rte_kvargs_count(kvlist, IFPGA_AFU_BTS) == 1) {\n \t\tif (rte_kvargs_process(kvlist, IFPGA_AFU_BTS,\n-\t\t\t\t &rte_ifpga_get_string_arg, &path) < 0) {\n-\t\t\tIFPGA_BUS_ERR(\"Failed to parse %s\",\n-\t\t\t\t IFPGA_AFU_BTS);\n+\t\t\t\tifpga_get_string_arg, &path) < 0) {\n+\t\t\tIFPGA_BUS_ERR(\"Failed to parse %s\", IFPGA_AFU_BTS);\n \t\t\tgoto end;\n \t\t}\n \t\tafu_pr_conf.pr_enable = 1;\n@@ -228,7 +227,7 @@ ifpga_scan(void)\n \n \t\tif (rte_kvargs_count(kvlist, IFPGA_ARG_NAME) == 1) {\n \t\t\tif (rte_kvargs_process(kvlist, IFPGA_ARG_NAME,\n-\t\t\t\t &rte_ifpga_get_string_arg, &name) < 0) {\n+\t\t\t\t\tifpga_get_string_arg, &name) < 0) {\n \t\t\t\tIFPGA_BUS_ERR(\"error to parse %s\",\n \t\t\t\t IFPGA_ARG_NAME);\n \t\t\t\tgoto end;\ndiff --git a/drivers/bus/ifpga/ifpga_common.c b/drivers/bus/ifpga/ifpga_common.c\ndeleted file mode 100644\nindex 78e2eaee4e..0000000000\n--- a/drivers/bus/ifpga/ifpga_common.c\n+++ /dev/null\n@@ -1,88 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2010-2018 Intel Corporation\n- */\n-\n-#include <string.h>\n-#include <inttypes.h>\n-#include <stdint.h>\n-#include <stdlib.h>\n-#include <stdio.h>\n-#include <sys/queue.h>\n-#include <sys/mman.h>\n-#include <sys/types.h>\n-#include <unistd.h>\n-#include <fcntl.h>\n-\n-#include <rte_errno.h>\n-#include <rte_bus.h>\n-#include <rte_per_lcore.h>\n-#include <rte_memory.h>\n-#include <rte_memzone.h>\n-#include <rte_eal.h>\n-#include <rte_common.h>\n-\n-#include <rte_devargs.h>\n-#include <rte_kvargs.h>\n-#include <rte_alarm.h>\n-\n-#include \"rte_bus_ifpga.h\"\n-#include \"ifpga_logs.h\"\n-#include \"ifpga_common.h\"\n-\n-int rte_ifpga_get_string_arg(const char *key __rte_unused,\n-\tconst char *value, void *extra_args)\n-{\n-\tif (!value || !extra_args)\n-\t\treturn -EINVAL;\n-\n-\t*(char **)extra_args = strdup(value);\n-\n-\tif (!*(char **)extra_args)\n-\t\treturn -ENOMEM;\n-\n-\treturn 0;\n-}\n-int rte_ifpga_get_integer32_arg(const char *key __rte_unused,\n-\tconst char *value, void *extra_args)\n-{\n-\tif (!value || !extra_args)\n-\t\treturn -EINVAL;\n-\n-\t*(int *)extra_args = strtoull(value, NULL, 0);\n-\n-\treturn 0;\n-}\n-int ifpga_get_integer64_arg(const char *key __rte_unused,\n-\tconst char *value, void *extra_args)\n-{\n-\tif (!value || !extra_args)\n-\t\treturn -EINVAL;\n-\n-\t*(uint64_t *)extra_args = strtoull(value, NULL, 0);\n-\n-\treturn 0;\n-}\n-int ifpga_get_unsigned_long(const char *str, int base)\n-{\n-\tunsigned long num;\n-\tchar *end = NULL;\n-\n-\terrno = 0;\n-\n-\tnum = strtoul(str, &end, base);\n-\tif ((str[0] == '\\0') || (end == NULL) || (*end != '\\0') || (errno != 0))\n-\t\treturn -1;\n-\n-\treturn num;\n-}\n-\n-int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0,\n-\tconst struct rte_afu_id *afu_id1)\n-{\n-\tif ((afu_id0->uuid.uuid_low == afu_id1->uuid.uuid_low) &&\n-\t\t(afu_id0->uuid.uuid_high == afu_id1->uuid.uuid_high) &&\n-\t\t(afu_id0->port == afu_id1->port)) {\n-\t\treturn 0;\n-\t} else\n-\t\treturn 1;\n-}\ndiff --git a/drivers/bus/ifpga/ifpga_common.h b/drivers/bus/ifpga/ifpga_common.h\nindex f9254b9d5d..bb6524030f 100644\n--- a/drivers/bus/ifpga/ifpga_common.h\n+++ b/drivers/bus/ifpga/ifpga_common.h\n@@ -5,14 +5,50 @@\n #ifndef _IFPGA_COMMON_H_\n #define _IFPGA_COMMON_H_\n \n-int rte_ifpga_get_string_arg(const char *key __rte_unused,\n-\tconst char *value, void *extra_args);\n-int rte_ifpga_get_integer32_arg(const char *key __rte_unused,\n-\tconst char *value, void *extra_args);\n-int ifpga_get_integer64_arg(const char *key __rte_unused,\n-\tconst char *value, void *extra_args);\n-int ifpga_get_unsigned_long(const char *str, int base);\n-int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0,\n-\tconst struct rte_afu_id *afu_id1);\n+#include <errno.h>\n+#include <stdlib.h>\n+#include <string.h>\n+\n+#include <rte_bus_ifpga.h>\n+#include <rte_common.h>\n+\n+static inline int\n+ifpga_get_string_arg(const char *key __rte_unused, const char *value,\n+\tvoid *extra_args)\n+{\n+\tif (!value || !extra_args)\n+\t\treturn -EINVAL;\n+\n+\t*(char **)extra_args = strdup(value);\n+\n+\tif (!*(char **)extra_args)\n+\t\treturn -ENOMEM;\n+\n+\treturn 0;\n+}\n+\n+static inline int\n+ifpga_get_integer32_arg(const char *key __rte_unused, const char *value,\n+\tvoid *extra_args)\n+{\n+\tif (!value || !extra_args)\n+\t\treturn -EINVAL;\n+\n+\t*(int *)extra_args = strtoull(value, NULL, 0);\n+\n+\treturn 0;\n+}\n+\n+static inline int\n+ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0,\n+\tconst struct rte_afu_id *afu_id1)\n+{\n+\tif ((afu_id0->uuid.uuid_low == afu_id1->uuid.uuid_low) &&\n+\t\t(afu_id0->uuid.uuid_high == afu_id1->uuid.uuid_high) &&\n+\t\t(afu_id0->port == afu_id1->port)) {\n+\t\treturn 0;\n+\t} else\n+\t\treturn 1;\n+}\n \n #endif /* _IFPGA_COMMON_H_ */\ndiff --git a/drivers/bus/ifpga/meson.build b/drivers/bus/ifpga/meson.build\nindex cc5047e3ce..9d56a4bb2b 100644\n--- a/drivers/bus/ifpga/meson.build\n+++ b/drivers/bus/ifpga/meson.build\n@@ -9,4 +9,4 @@ endif\n \n deps += ['pci', 'kvargs', 'rawdev']\n headers = files('rte_bus_ifpga.h')\n-sources = files('ifpga_common.c', 'ifpga_bus.c')\n+sources = files('ifpga_bus.c')\ndiff --git a/drivers/bus/ifpga/version.map b/drivers/bus/ifpga/version.map\nindex c0a1eecae8..da7f92c2a0 100644\n--- a/drivers/bus/ifpga/version.map\n+++ b/drivers/bus/ifpga/version.map\n@@ -4,8 +4,6 @@ DPDK_23 {\n \trte_ifpga_driver_register;\n \trte_ifpga_driver_unregister;\n \trte_ifpga_find_afu_by_name;\n-\trte_ifpga_get_integer32_arg;\n-\trte_ifpga_get_string_arg;\n \n \tlocal: *;\n };\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex 3b616c45ff..153203a42f 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -1754,7 +1754,7 @@ ifpga_vdev_parse_devargs(struct rte_devargs *devargs,\n \n \tif (rte_kvargs_count(kvlist, IFPGA_ARG_PORT) == 1) {\n \t\tif (rte_kvargs_process(kvlist, IFPGA_ARG_PORT,\n-\t\t\t&rte_ifpga_get_integer32_arg, &port) < 0) {\n+\t\t\t\tifpga_get_integer32_arg, &port) < 0) {\n \t\t\tIFPGA_RAWDEV_PMD_ERR(\"error to parse %s\",\n \t\t\t\tIFPGA_ARG_PORT);\n \t\t\tgoto end;\n", "prefixes": [ "v5", "14/27" ] }