Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115846/?format=api
{ "id": 115846, "url": "http://patches.dpdk.org/api/patches/115846/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220905083933.2506819-7-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220905083933.2506819-7-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220905083933.2506819-7-david.marchand@redhat.com", "date": "2022-09-05T08:39:12", "name": "[v5,06/27] examples/ethtool: prefer device name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2a984f10d4ff9b3851bd10dcc4d876b68b30f736", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220905083933.2506819-7-david.marchand@redhat.com/mbox/", "series": [ { "id": 24531, "url": "http://patches.dpdk.org/api/series/24531/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24531", "date": "2022-09-05T08:39:07", "name": "[v5,01/27] devtools: forbid inclusions of driver only headers", "version": 5, "mbox": "http://patches.dpdk.org/series/24531/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115846/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115846/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DFA61A0547;\n\tMon, 5 Sep 2022 10:40:19 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5862442B6D;\n\tMon, 5 Sep 2022 10:40:04 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id D54864284D\n for <dev@dpdk.org>; Mon, 5 Sep 2022 10:40:01 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-562-E9T3P-NxOS61zFwSnJHQiA-1; Mon, 05 Sep 2022 04:39:58 -0400", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com\n [10.11.54.2])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B47A821BF3;\n Mon, 5 Sep 2022 08:39:58 +0000 (UTC)", "from fchome.redhat.com (unknown [10.40.193.251])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8889C403D0D9;\n Mon, 5 Sep 2022 08:39:57 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1662367201;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7ppVe9gXX6tpk+d6Zh5/dhx/pla8ivJhmHutM4G+Cw8=;\n b=WY99dHrp3le4DLwrUj9scqUCUN61nJuyBMdE6524xypTSDtdJh039nWQ8ZrxOmzBI4lsIH\n z2P3pVmD5aRllKmkyvkxEQ4t4Y0q+4f4ZCVt4BY7tuJCkPaEDupIaVy+/qaDCmAMX1JWDq\n EYaSFL0JVUxuhzr22T7AZ2OWhupq/ns=", "X-MC-Unique": "E9T3P-NxOS61zFwSnJHQiA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tbruce.richardson@intel.com", "Subject": "[PATCH v5 06/27] examples/ethtool: prefer device name", "Date": "Mon, 5 Sep 2022 10:39:12 +0200", "Message-Id": "<20220905083933.2506819-7-david.marchand@redhat.com>", "In-Reply-To": "<20220905083933.2506819-1-david.marchand@redhat.com>", "References": "<20220628144643.1213026-1-david.marchand@redhat.com>\n <20220905083933.2506819-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.11.54.2", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Rely on the generic device name rather than restrict to only supporting\nPCI devices.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n examples/ethtool/lib/rte_ethtool.c | 17 ++---------------\n 1 file changed, 2 insertions(+), 15 deletions(-)", "diff": "diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c\nindex ffaad96498..88dc917b73 100644\n--- a/examples/ethtool/lib/rte_ethtool.c\n+++ b/examples/ethtool/lib/rte_ethtool.c\n@@ -8,7 +8,6 @@\n #include <rte_version.h>\n #include <rte_ethdev.h>\n #include <rte_ether.h>\n-#include <rte_bus_pci.h>\n #ifdef RTE_NET_IXGBE\n #include <rte_pmd_ixgbe.h>\n #endif\n@@ -23,8 +22,6 @@ rte_ethtool_get_drvinfo(uint16_t port_id, struct ethtool_drvinfo *drvinfo)\n {\n \tstruct rte_eth_dev_info dev_info;\n \tstruct rte_dev_reg_info reg_info;\n-\tconst struct rte_pci_device *pci_dev;\n-\tconst struct rte_bus *bus = NULL;\n \tint n;\n \tint ret;\n \n@@ -52,18 +49,8 @@ rte_ethtool_get_drvinfo(uint16_t port_id, struct ethtool_drvinfo *drvinfo)\n \tstrlcpy(drvinfo->driver, dev_info.driver_name,\n \t\tsizeof(drvinfo->driver));\n \tstrlcpy(drvinfo->version, rte_version(), sizeof(drvinfo->version));\n-\t/* TODO: replace bus_info by rte_devargs.name */\n-\tif (dev_info.device)\n-\t\tbus = rte_bus_find_by_device(dev_info.device);\n-\tif (bus && !strcmp(bus->name, \"pci\")) {\n-\t\tpci_dev = RTE_DEV_TO_PCI(dev_info.device);\n-\t\tsnprintf(drvinfo->bus_info, sizeof(drvinfo->bus_info),\n-\t\t\t\"%04x:%02x:%02x.%x\",\n-\t\t\tpci_dev->addr.domain, pci_dev->addr.bus,\n-\t\t\tpci_dev->addr.devid, pci_dev->addr.function);\n-\t} else {\n-\t\tsnprintf(drvinfo->bus_info, sizeof(drvinfo->bus_info), \"N/A\");\n-\t}\n+\tstrlcpy(drvinfo->bus_info, dev_info.device->name,\n+\t\tsizeof(drvinfo->bus_info));\n \n \tmemset(®_info, 0, sizeof(reg_info));\n \trte_eth_dev_get_reg_info(port_id, ®_info);\n", "prefixes": [ "v5", "06/27" ] }