Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115843/?format=api
{ "id": 115843, "url": "http://patches.dpdk.org/api/patches/115843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220905083933.2506819-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220905083933.2506819-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220905083933.2506819-4-david.marchand@redhat.com", "date": "2022-09-05T08:39:09", "name": "[v5,03/27] raw/ifpga: remove PCI bus accessor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "825199503fc6f65c6aeb8417899f3282e358623a", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220905083933.2506819-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 24531, "url": "http://patches.dpdk.org/api/series/24531/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24531", "date": "2022-09-05T08:39:07", "name": "[v5,01/27] devtools: forbid inclusions of driver only headers", "version": 5, "mbox": "http://patches.dpdk.org/series/24531/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115843/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 750B7A0547;\n\tMon, 5 Sep 2022 10:39:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 50612427ED;\n\tMon, 5 Sep 2022 10:39:52 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id D32A642825\n for <dev@dpdk.org>; Mon, 5 Sep 2022 10:39:50 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-35-DEsMlSzBNl-kYSa7P4hsgw-1; Mon, 05 Sep 2022 04:39:49 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C906A84B06D;\n Mon, 5 Sep 2022 08:39:48 +0000 (UTC)", "from fchome.redhat.com (unknown [10.40.193.251])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 91A371121314;\n Mon, 5 Sep 2022 08:39:47 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1662367190;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=TkT71EOBRUiszkOnVO8GzFsMOra6AiAce553P99/kqs=;\n b=SkVl6QG0WEmwgCy1LyApdsXufyx68q0p8fHmQuvdpZJAza3c3HX2v8QlzaIMdTAPlnaMHb\n +vgl3Jibe523DtHjgRbigcwp6ZIACqppdmI5eHyTKPyzei4Fs1R8wpBItPQG5AcN8hALid\n Lr1EbUqEHe5+Lhw4Ka0XTtsx7dSBIyM=", "X-MC-Unique": "DEsMlSzBNl-kYSa7P4hsgw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com,\n Rosen Xu <rosen.xu@intel.com>, Ray Kinsella <mdr@ashroe.eu>,\n Tianfei zhang <tianfei.zhang@intel.com>", "Subject": "[PATCH v5 03/27] raw/ifpga: remove PCI bus accessor", "Date": "Mon, 5 Sep 2022 10:39:09 +0200", "Message-Id": "<20220905083933.2506819-4-david.marchand@redhat.com>", "In-Reply-To": "<20220905083933.2506819-1-david.marchand@redhat.com>", "References": "<20220628144643.1213026-1-david.marchand@redhat.com>\n <20220905083933.2506819-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is no in-tree user for this accessor that returns the PCI bus\nobject.\nOn the other hand, a bus object can be retrieved by name using\nrte_bus_find_by_name.\nWe can remove this driver specific API.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Rosen Xu <rosen.xu@intel.com>\n---\nChanges since RFC v2:\n- updated release notes,\n\n---\n doc/guides/rel_notes/deprecation.rst | 3 ---\n doc/guides/rel_notes/release_22_11.rst | 2 ++\n drivers/raw/ifpga/ifpga_rawdev.c | 7 +------\n drivers/raw/ifpga/ifpga_rawdev.h | 1 -\n drivers/raw/ifpga/rte_pmd_ifpga.c | 6 ------\n drivers/raw/ifpga/rte_pmd_ifpga.h | 10 ----------\n drivers/raw/ifpga/version.map | 1 -\n 7 files changed, 3 insertions(+), 27 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex e7583cae4c..dba252067c 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -228,9 +228,6 @@ Deprecation Notices\n * raw/dpaa2_cmdif: The ``dpaa2_cmdif`` rawdev driver will be deprecated\n in DPDK 22.11, as it is no longer in use, no active user known.\n \n-* raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` will be removed\n- in DPDK 22.11.\n-\n * raw/ioat: The ``ioat`` rawdev driver has been deprecated, since it's\n functionality is provided through the new ``dmadev`` infrastructure.\n To continue to use hardware previously supported by the ``ioat`` rawdev driver,\ndiff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst\nindex 8c021cf050..3cea3aa8eb 100644\n--- a/doc/guides/rel_notes/release_22_11.rst\n+++ b/doc/guides/rel_notes/release_22_11.rst\n@@ -84,6 +84,8 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+* raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed.\n+\n \n ABI Changes\n -----------\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex 8c05302a65..78a7123528 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -10,8 +10,8 @@\n #include <fcntl.h>\n #include <sys/ioctl.h>\n #include <sys/epoll.h>\n+\n #include <rte_log.h>\n-#include <rte_bus.h>\n #include <rte_malloc.h>\n #include <rte_devargs.h>\n #include <rte_memcpy.h>\n@@ -1888,11 +1888,6 @@ RTE_PMD_REGISTER_PARAM_STRING(ifpga_rawdev_cfg,\n \t\"port=<int> \"\n \t\"afu_bts=<path>\");\n \n-struct rte_pci_bus *ifpga_get_pci_bus(void)\n-{\n-\treturn rte_ifpga_rawdev_pmd.bus;\n-}\n-\n int ifpga_rawdev_partial_reconfigure(struct rte_rawdev *dev, int port,\n \tconst char *file)\n {\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.h b/drivers/raw/ifpga/ifpga_rawdev.h\nindex 4c191190ca..0fb66cbaae 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.h\n+++ b/drivers/raw/ifpga/ifpga_rawdev.h\n@@ -91,7 +91,6 @@ int\n ifpga_unregister_msix_irq(struct ifpga_rawdev *dev, enum ifpga_irq_type type,\n \t\tint vec_start, rte_intr_callback_fn handler, void *arg);\n \n-struct rte_pci_bus *ifpga_get_pci_bus(void);\n int ifpga_rawdev_partial_reconfigure(struct rte_rawdev *dev, int port,\n \tconst char *file);\n void ifpga_rawdev_cleanup(void);\ndiff --git a/drivers/raw/ifpga/rte_pmd_ifpga.c b/drivers/raw/ifpga/rte_pmd_ifpga.c\nindex 23146432c2..1ca248123b 100644\n--- a/drivers/raw/ifpga/rte_pmd_ifpga.c\n+++ b/drivers/raw/ifpga/rte_pmd_ifpga.c\n@@ -402,12 +402,6 @@ rte_pmd_ifpga_reload(uint16_t dev_id, int type, int page)\n \treturn opae_mgr_reload(adapter->mgr, type, page);\n }\n \n-const struct rte_pci_bus *\n-rte_pmd_ifpga_get_pci_bus(void)\n-{\n-\treturn ifpga_get_pci_bus();\n-}\n-\n int\n rte_pmd_ifpga_partial_reconfigure(uint16_t dev_id, int port, const char *file)\n {\ndiff --git a/drivers/raw/ifpga/rte_pmd_ifpga.h b/drivers/raw/ifpga/rte_pmd_ifpga.h\nindex 3fa5d3435a..791543f2cd 100644\n--- a/drivers/raw/ifpga/rte_pmd_ifpga.h\n+++ b/drivers/raw/ifpga/rte_pmd_ifpga.h\n@@ -220,16 +220,6 @@ rte_pmd_ifpga_reboot_try(uint16_t dev_id);\n int\n rte_pmd_ifpga_reload(uint16_t dev_id, int type, int page);\n \n-/**\n- * Get PCI bus the Intel FPGA driver register to\n- *\n- * @return\n- * - (valid pointer) if successful.\n- * - (NULL) if the Intel FPGA driver is not registered to any PCI bus.\n- */\n-const struct rte_pci_bus *\n-rte_pmd_ifpga_get_pci_bus(void);\n-\n /**\n * Perform PR (partial reconfiguration) on specified Intel FPGA device\n *\ndiff --git a/drivers/raw/ifpga/version.map b/drivers/raw/ifpga/version.map\nindex f5c3959b7f..916da8a4f2 100644\n--- a/drivers/raw/ifpga/version.map\n+++ b/drivers/raw/ifpga/version.map\n@@ -3,7 +3,6 @@ DPDK_23 {\n \n \trte_pmd_ifpga_cleanup;\n \trte_pmd_ifpga_get_dev_id;\n-\trte_pmd_ifpga_get_pci_bus;\n \trte_pmd_ifpga_get_phy_info;\n \trte_pmd_ifpga_get_property;\n \trte_pmd_ifpga_get_rsu_status;\n", "prefixes": [ "v5", "03/27" ] }