Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115836/?format=api
{ "id": 115836, "url": "http://patches.dpdk.org/api/patches/115836/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220905083540.2506490-6-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220905083540.2506490-6-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220905083540.2506490-6-david.marchand@redhat.com", "date": "2022-09-05T08:35:18", "name": "[v5,05/27] kni: stop populating PCI info in examples", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "5a0fbb5b2862ee66826f9995e4df7a960a03db5f", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220905083540.2506490-6-david.marchand@redhat.com/mbox/", "series": [ { "id": 24530, "url": "http://patches.dpdk.org/api/series/24530/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24530", "date": "2022-09-05T08:35:13", "name": "Bus and device cleanup for 22.11", "version": 5, "mbox": "http://patches.dpdk.org/series/24530/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115836/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115836/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D29D9A0547;\n\tMon, 5 Sep 2022 10:36:25 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3D2DC4282F;\n\tMon, 5 Sep 2022 10:36:10 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id A444E42836\n for <dev@dpdk.org>; Mon, 5 Sep 2022 10:36:08 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-251-uzcY95JwMSCpqjZsUE5g8Q-1; Mon, 05 Sep 2022 04:36:03 -0400", "from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com\n [10.11.54.9])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F031581F46A;\n Mon, 5 Sep 2022 08:36:02 +0000 (UTC)", "from fchome.redhat.com (unknown [10.40.193.251])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 1105D492CA2;\n Mon, 5 Sep 2022 08:36:01 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1662366968;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=PsCgZJdiIuD9RWTikTQSy3LBVgG62redinUuf7eDaUU=;\n b=glEXt3tnpbcWuRUHnzDrab7GBhtz6/7UbZ0Q/GlekTkfvMMhnEWHggIbuQtOH+31xrxPnm\n LzBbd4HUVIpkelFDDVMvBQGNuET8gvgbPhhRPIQHB9x277MYTsjL/cyNPtD0bNyGpM/8NJ\n KPDc4ycjiGd5srzXtpL3lg8iNGUabXE=", "X-MC-Unique": "uzcY95JwMSCpqjZsUE5g8Q-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Subject": "[PATCH v5 05/27] kni: stop populating PCI info in examples", "Date": "Mon, 5 Sep 2022 10:35:18 +0200", "Message-Id": "<20220905083540.2506490-6-david.marchand@redhat.com>", "In-Reply-To": "<20220905083540.2506490-1-david.marchand@redhat.com>", "References": "<20220628144643.1213026-1-david.marchand@redhat.com>\n <20220905083540.2506490-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.9", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "addr and id fields are deprecated and are not used in the kni library.\nStop populating them in the in-tree examples.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_kni.c | 30 ------------------------------\n examples/ip_pipeline/kni.c | 10 ----------\n 2 files changed, 40 deletions(-)", "diff": "diff --git a/app/test/test_kni.c b/app/test/test_kni.c\nindex 622315c8b1..4039da0b08 100644\n--- a/app/test/test_kni.c\n+++ b/app/test/test_kni.c\n@@ -25,7 +25,6 @@ test_kni(void)\n #include <rte_string_fns.h>\n #include <rte_mempool.h>\n #include <rte_ethdev.h>\n-#include <rte_bus_pci.h>\n #include <rte_cycles.h>\n #include <rte_kni.h>\n \n@@ -426,8 +425,6 @@ test_kni_processing(uint16_t port_id, struct rte_mempool *mp)\n \tstruct rte_kni_conf conf;\n \tstruct rte_eth_dev_info info;\n \tstruct rte_kni_ops ops;\n-\tconst struct rte_pci_device *pci_dev;\n-\tconst struct rte_bus *bus = NULL;\n \n \tif (!mp)\n \t\treturn -1;\n@@ -443,13 +440,6 @@ test_kni_processing(uint16_t port_id, struct rte_mempool *mp)\n \t\treturn -1;\n \t}\n \n-\tif (info.device)\n-\t\tbus = rte_bus_find_by_device(info.device);\n-\tif (bus && !strcmp(bus->name, \"pci\")) {\n-\t\tpci_dev = RTE_DEV_TO_PCI(info.device);\n-\t\tconf.addr = pci_dev->addr;\n-\t\tconf.id = pci_dev->id;\n-\t}\n \tsnprintf(conf.name, sizeof(conf.name), TEST_KNI_PORT);\n \n \t/* core id 1 configured for kernel thread */\n@@ -545,8 +535,6 @@ test_kni(void)\n \tstruct rte_kni_conf conf;\n \tstruct rte_eth_dev_info info;\n \tstruct rte_kni_ops ops;\n-\tconst struct rte_pci_device *pci_dev;\n-\tconst struct rte_bus *bus;\n \tFILE *fd;\n \tDIR *dir;\n \tchar buf[16];\n@@ -645,15 +633,6 @@ test_kni(void)\n \t\treturn -1;\n \t}\n \n-\tif (info.device)\n-\t\tbus = rte_bus_find_by_device(info.device);\n-\telse\n-\t\tbus = NULL;\n-\tif (bus && !strcmp(bus->name, \"pci\")) {\n-\t\tpci_dev = RTE_DEV_TO_PCI(info.device);\n-\t\tconf.addr = pci_dev->addr;\n-\t\tconf.id = pci_dev->id;\n-\t}\n \tconf.group_id = port_id;\n \tconf.mbuf_size = MAX_PACKET_SZ;\n \n@@ -689,15 +668,6 @@ test_kni(void)\n \t\tgoto fail;\n \t}\n \n-\tif (info.device)\n-\t\tbus = rte_bus_find_by_device(info.device);\n-\telse\n-\t\tbus = NULL;\n-\tif (bus && !strcmp(bus->name, \"pci\")) {\n-\t\tpci_dev = RTE_DEV_TO_PCI(info.device);\n-\t\tconf.addr = pci_dev->addr;\n-\t\tconf.id = pci_dev->id;\n-\t}\n \tconf.group_id = port_id;\n \tconf.mbuf_size = MAX_PACKET_SZ;\n \ndiff --git a/examples/ip_pipeline/kni.c b/examples/ip_pipeline/kni.c\nindex a2d3331cb0..cd02c39478 100644\n--- a/examples/ip_pipeline/kni.c\n+++ b/examples/ip_pipeline/kni.c\n@@ -6,7 +6,6 @@\n #include <string.h>\n \n #include <rte_ethdev.h>\n-#include <rte_bus_pci.h>\n #include <rte_string_fns.h>\n \n #include \"kni.h\"\n@@ -107,8 +106,6 @@ kni_create(const char *name, struct kni_params *params)\n \tstruct mempool *mempool;\n \tstruct link *link;\n \tstruct rte_kni *k;\n-\tconst struct rte_pci_device *pci_dev;\n-\tconst struct rte_bus *bus = NULL;\n \tint ret;\n \n \t/* Check input params */\n@@ -134,13 +131,6 @@ kni_create(const char *name, struct kni_params *params)\n \tkni_conf.core_id = params->thread_id;\n \tkni_conf.group_id = link->port_id;\n \tkni_conf.mbuf_size = mempool->buffer_size;\n-\tif (dev_info.device)\n-\t\tbus = rte_bus_find_by_device(dev_info.device);\n-\tif (bus && !strcmp(bus->name, \"pci\")) {\n-\t\tpci_dev = RTE_DEV_TO_PCI(dev_info.device);\n-\t\tkni_conf.addr = pci_dev->addr;\n-\t\tkni_conf.id = pci_dev->id;\n-\t}\n \n \tmemset(&kni_ops, 0, sizeof(kni_ops));\n \tkni_ops.port_id = link->port_id;\n", "prefixes": [ "v5", "05/27" ] }