Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115556/?format=api
{ "id": 115556, "url": "http://patches.dpdk.org/api/patches/115556/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/tencent_F3597A23B9EE72C7633E44F78D66D01F1109@qq.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<tencent_F3597A23B9EE72C7633E44F78D66D01F1109@qq.com>", "list_archive_url": "https://inbox.dpdk.org/dev/tencent_F3597A23B9EE72C7633E44F78D66D01F1109@qq.com", "date": "2022-08-27T09:25:47", "name": "eal: zero out new added memory", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "de7696ebbcd6ca1647efc4ab7002b246778434da", "submitter": { "id": 2821, "url": "http://patches.dpdk.org/api/people/2821/?format=api", "name": "lic121", "email": "chengtcli@qq.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/tencent_F3597A23B9EE72C7633E44F78D66D01F1109@qq.com/mbox/", "series": [ { "id": 24432, "url": "http://patches.dpdk.org/api/series/24432/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24432", "date": "2022-08-27T09:25:47", "name": "eal: zero out new added memory", "version": 1, "mbox": "http://patches.dpdk.org/series/24432/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115556/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/115556/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 43B7AA054A;\n\tSat, 27 Aug 2022 11:26:25 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E6B3D40DF7;\n\tSat, 27 Aug 2022 11:26:24 +0200 (CEST)", "from out162-62-57-137.mail.qq.com (out162-62-57-137.mail.qq.com\n [162.62.57.137]) by mails.dpdk.org (Postfix) with ESMTP id 821AB40696\n for <dev@dpdk.org>; Sat, 27 Aug 2022 11:26:22 +0200 (CEST)", "from vscode.localdomain ([218.88.39.146])\n by newxmesmtplogicsvrszc8.qq.com (NewEsmtp) with SMTP\n id 6928DAC7; Sat, 27 Aug 2022 17:26:18 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;\n t=1661592380; bh=SOzd1dOvhL+Jsux10CU+QlQtXUxWVJO4QVbtX9HHthI=;\n h=From:To:Cc:Subject:Date;\n b=RfmwTq7bc3V8Vn+crrcId5eWiUUE6nRuCP78DDyEY/m11z+MfROnY0jpPDZxuCn1+\n H0DnLVk5oDpi9BoZ7TNmkloAJ5nK7Zu/BQTmOpwY/2LDGKjhnpOA/um1thNxhq9VTD\n 8NCV18yo4gUMvszoY5ugLrp2nwCoZJXSrThY1nrE=", "X-QQ-mid": "xmsmtpt1661592378t4yqzqq3m", "Message-ID": "<tencent_F3597A23B9EE72C7633E44F78D66D01F1109@qq.com>", "X-QQ-XMAILINFO": "MqN/FiDJuNHiSvU9z+hrdeVSS1QufAOx23Sn80RJ5LN/d/BNd7s3Ypq/WCEhxE\n EmsG1BGowuU9TLJOeAcOYMfbqVcezWIFPo9DXu3zhhcQNZpcUB10xhMpHaOLyfqZkfIPhAHW7Kic\n 3Nbpjom5ZwHeKH1v9CsFHIf9Ss8LUTGmlHxHAy4Sadt0B/oMbdNxNUagBy6ZbJSrRaoh234f7zKd\n FpHugYcTxoMVlsPqgFzc3+M6H9DzMONfNYsl9DmZV9brP1roGZGbNID/PcfUN6PUDpa9oJDapwty\n inXhkTNRrmLcQhO2YgyxD5qGUGWOAvpmqX3+6iCtvQTh3QSS+EvLqpNf9Ah8AGQrGUE2Y/e1xRXz\n Ie69atwgyxCHY0XaiRBb0w3kRpvFqPhjrbXfXanY/g3wnz17D2tc0pGQTGCDn2kBxQNGwbP0t6Zn\n 6aMW/Zqp4z2LeMZ7OLx2DhXG40xBWy5Lra0b9KMoVVAd1Ge2mK1G+9PcEsd+y/qSeiu7EwqPVmmK\n rqYph+U5F5PUplsXVO0m/MgQTRNLRID7NLxJI9JnVFfb0riQgYClhqU91ImapmBcRDCIQ/Y/l885\n biH41jB24AIgvfLxIqoa1T4Ffc2xDOnFsSqXaGQ3qviuqFAcbw+STouTWZcSI6z280zTUBVkN+we\n Re6kLjyGRpg/IUIglZI5zxLdqQZ6ikjqmsRblIRV0FOVuzsWUI6O2zA9bhuNCSTnB+PlII09Hmyp\n PdoJVWURqXTu1LMizaO07X9vtQr8nOrwIs9kLF0KV7vIRUOb2JrAgN8MaMl2MTh/z/u2xySBhvbX\n G2fPPcGPhg4ob6b7+//YjcNY8jtt2BBRdaFOOLw+5btetBEw6RlRoovr06tf/EAa4PSbbaRnqF84\n WZPa7bbblOM3ToraTfxGVLh2uM0591lzUejwiBIMbaeye7VC6iubaR8OZOuDUlbnjYQtKN0+hg", "From": "chengtcli@qq.com", "To": "dev@dpdk.org", "Cc": "lic121 <lic121@chinatelecom.cn>", "Subject": "[PATCH] eal: zero out new added memory", "Date": "Sat, 27 Aug 2022 09:25:47 +0000", "X-OQ-MSGID": "<1661592347-31533-1-git-send-email-chengtcli@qq.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: lic121 <lic121@chinatelecom.cn>\n\nWhen RTE_MALLOC_DEBUG not configured, rte_zmalloc_socket() doens't\nzero oute allocaed memory. Because memory are zeroed out when free\nin malloc_elem_free(). But seems the initial allocated memory is\nnot zeroed out as expected.\n\nThis patch zero out initial allocated memory in\nmalloc_heap_add_memory().\n\nWith dpdk 20.11.5, \"QLogic Corp. FastLinQ QL41000\" probe triggers\nthis problem.\n```\n Stack trace of thread 412780:\n #0 0x0000000000e5fb99 ecore_int_igu_read_cam (dpdk-testpmd)\n #1 0x0000000000e4df54 ecore_get_hw_info (dpdk-testpmd)\n #2 0x0000000000e504aa ecore_hw_prepare (dpdk-testpmd)\n #3 0x0000000000e8a7ca qed_probe (dpdk-testpmd)\n #4 0x0000000000e83c59 qede_common_dev_init (dpdk-testpmd)\n #5 0x0000000000e84c8e qede_eth_dev_init (dpdk-testpmd)\n #6 0x00000000009dd5a7 rte_pci_probe_one_driver (dpdk-testpmd)\n #7 0x00000000009734e3 rte_bus_probe (dpdk-testpmd)\n #8 0x00000000009933bd rte_eal_init (dpdk-testpmd)\n #9 0x000000000041768f main (dpdk-testpmd)\n #10 0x00007f41a7001b17 __libc_start_main (libc.so.6)\n #11 0x000000000067e34a _start (dpdk-testpmd)\n```\n\nSigned-off-by: lic121 <lic121@chinatelecom.cn>\n---\n lib/librte_eal/common/malloc_heap.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c\nindex f4e20ea..1607401 100644\n--- a/lib/librte_eal/common/malloc_heap.c\n+++ b/lib/librte_eal/common/malloc_heap.c\n@@ -96,11 +96,19 @@\n \t\tvoid *start, size_t len)\n {\n \tstruct malloc_elem *elem = start;\n+\tvoid *ptr;\n+\tsize_t data_len\n+\n \n \tmalloc_elem_init(elem, heap, msl, len, elem, len);\n \n \tmalloc_elem_insert(elem);\n \n+\t/* Zero out new added memory. */\n+\t*ptr = RTE_PTR_ADD(elem, MALLOC_ELEM_HEADER_LEN);\n+\tdata_len = elem->size - MALLOC_ELEM_OVERHEAD;\n+\tmemset(ptr, 0, data_len);\n+\n \telem = malloc_elem_join_adjacent_free(elem);\n \n \tmalloc_elem_free_list_insert(elem);\n", "prefixes": [] }