Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115512/?format=api
{ "id": 115512, "url": "http://patches.dpdk.org/api/patches/115512/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220826131737.1741743-6-cristian.dumitrescu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220826131737.1741743-6-cristian.dumitrescu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220826131737.1741743-6-cristian.dumitrescu@intel.com", "date": "2022-08-26T13:17:21", "name": "[V2,05/21] net/softnic: remove tap support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f158902b842a737ce28a13f15a09750e44ee6f42", "submitter": { "id": 19, "url": "http://patches.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220826131737.1741743-6-cristian.dumitrescu@intel.com/mbox/", "series": [ { "id": 24429, "url": "http://patches.dpdk.org/api/series/24429/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24429", "date": "2022-08-26T13:17:16", "name": "net/softnic: replace the legacy pipeline with SWX pipeline", "version": 2, "mbox": "http://patches.dpdk.org/series/24429/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115512/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115512/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7A030A0550;\n\tFri, 26 Aug 2022 15:18:47 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 98DF042B79;\n\tFri, 26 Aug 2022 15:18:10 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 0C88A40143\n for <dev@dpdk.org>; Fri, 26 Aug 2022 15:17:59 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Aug 2022 06:17:44 -0700", "from silpixa00400573.ir.intel.com (HELO\n silpixa00400573.ger.corp.intel.com.) ([10.237.223.157])\n by orsmga002.jf.intel.com with ESMTP; 26 Aug 2022 06:17:43 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1661519880; x=1693055880;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=6WklVaKDbqddeo1Nn5SNNCuoIBb7qyEX3VtGVbcO7hs=;\n b=DRNfWdY6f9j7oPqYz3DsqGvppG5uoJs01N9O6Ue55lQA+W7h9jgyepTU\n vsh5a0sGgjSr+JlmO2ESMfHQNSe8KAhAcMobqHp3E8/maIxN3m7FZ71uX\n hPP4ack+PzlL7SXLMwNCCNrIFPgwW7F1FXG/1bvL81nLiAxhRUL2fPaZC\n hLIJ8H7bNA66pbk44xpRzK4M1GkIxW64I/qJmqW54A84KguQEYIAD4307\n 9ocm8dIkt4hwZwP7RvBG8qBKMZ271cijv/99ImVKUKawz23GU6M/6YzSf\n TXtTBkzDi4666Wxsg0IHggINXHbNfbefkCoCBzGsQ+JxtvND6VDDhdm1C Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10450\"; a=\"320598556\"", "E=Sophos;i=\"5.93,265,1654585200\"; d=\"scan'208\";a=\"320598556\"", "E=Sophos;i=\"5.93,265,1654585200\"; d=\"scan'208\";a=\"610561608\"" ], "X-ExtLoop1": "1", "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "To": "dev@dpdk.org", "Cc": "Yogesh Jangra <yogesh.jangra@intel.com>", "Subject": "[PATCH V2 05/21] net/softnic: remove tap support", "Date": "Fri, 26 Aug 2022 13:17:21 +0000", "Message-Id": "<20220826131737.1741743-6-cristian.dumitrescu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220826131737.1741743-1-cristian.dumitrescu@intel.com>", "References": "<20220804165839.1074817-1-cristian.dumitrescu@intel.com>\n <20220826131737.1741743-1-cristian.dumitrescu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove the TUN/TAP device support. The TUN/TAP devices are still\nsupported as virtual Ethernet devices through the TAP Poll Mode\nDriver.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Yogesh Jangra <yogesh.jangra@intel.com>\n---\n drivers/net/softnic/meson.build | 1 -\n drivers/net/softnic/rte_eth_softnic.c | 3 -\n drivers/net/softnic/rte_eth_softnic_cli.c | 76 -----------\n .../net/softnic/rte_eth_softnic_internals.h | 36 ------\n .../net/softnic/rte_eth_softnic_pipeline.c | 44 -------\n drivers/net/softnic/rte_eth_softnic_tap.c | 118 ------------------\n 6 files changed, 278 deletions(-)\n delete mode 100644 drivers/net/softnic/rte_eth_softnic_tap.c", "diff": "diff --git a/drivers/net/softnic/meson.build b/drivers/net/softnic/meson.build\nindex b3d235841d..91f1f3220f 100644\n--- a/drivers/net/softnic/meson.build\n+++ b/drivers/net/softnic/meson.build\n@@ -16,7 +16,6 @@ sources = files(\n 'rte_eth_softnic_mempool.c',\n 'rte_eth_softnic_pipeline.c',\n 'rte_eth_softnic_swq.c',\n- 'rte_eth_softnic_tap.c',\n 'rte_eth_softnic_thread.c',\n )\n deps += ['pipeline', 'port', 'table']\ndiff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c\nindex 1ea5989223..eb97ae7185 100644\n--- a/drivers/net/softnic/rte_eth_softnic.c\n+++ b/drivers/net/softnic/rte_eth_softnic.c\n@@ -162,7 +162,6 @@ pmd_dev_stop(struct rte_eth_dev *dev)\n \tsoftnic_pipeline_free(p);\n \tsoftnic_table_action_profile_free(p);\n \tsoftnic_port_in_action_profile_free(p);\n-\tsoftnic_tap_free(p);\n \tsoftnic_link_free(p);\n \tsoftnic_softnic_swq_free_keep_rxq_txq(p);\n \tsoftnic_mempool_free(p);\n@@ -183,7 +182,6 @@ pmd_free(struct pmd_internals *p)\n \tsoftnic_pipeline_free(p);\n \tsoftnic_table_action_profile_free(p);\n \tsoftnic_port_in_action_profile_free(p);\n-\tsoftnic_tap_free(p);\n \tsoftnic_link_free(p);\n \tsoftnic_swq_free(p);\n \tsoftnic_mempool_free(p);\n@@ -263,7 +261,6 @@ pmd_init(struct pmd_params *params)\n \tsoftnic_mempool_init(p);\n \tsoftnic_swq_init(p);\n \tsoftnic_link_init(p);\n-\tsoftnic_tap_init(p);\n \tsoftnic_port_in_action_profile_init(p);\n \tsoftnic_table_action_profile_init(p);\n \tsoftnic_pipeline_init(p);\ndiff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c\nindex bca0b176d6..501ef08c4c 100644\n--- a/drivers/net/softnic/rte_eth_softnic_cli.c\n+++ b/drivers/net/softnic/rte_eth_softnic_cli.c\n@@ -186,33 +186,6 @@ cmd_swq(struct pmd_internals *softnic,\n \t}\n }\n \n-/**\n- * tap <tap_name>\n- */\n-static void\n-cmd_tap(struct pmd_internals *softnic,\n-\tchar **tokens,\n-\tuint32_t n_tokens,\n-\tchar *out,\n-\tsize_t out_size)\n-{\n-\tchar *name;\n-\tstruct softnic_tap *tap;\n-\n-\tif (n_tokens != 2) {\n-\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);\n-\t\treturn;\n-\t}\n-\n-\tname = tokens[1];\n-\n-\ttap = softnic_tap_create(softnic, name);\n-\tif (tap == NULL) {\n-\t\tsnprintf(out, out_size, MSG_CMD_FAIL, tokens[0]);\n-\t\treturn;\n-\t}\n-}\n-\n /**\n * port in action profile <profile_name>\n * [filter match | mismatch offset <key_offset> mask <key_mask> key <key_value> port <port_id>]\n@@ -874,7 +847,6 @@ cmd_pipeline(struct pmd_internals *softnic,\n * bsz <burst_size>\n * link <link_name> rxq <queue_id>\n * | swq <swq_name>\n- * | tap <tap_name> mempool <mempool_name> mtu <mtu>\n * | source mempool <mempool_name> file <file_name> bpp <n_bytes_per_pkt>\n * [action <port_in_action_profile_name>]\n * [disabled]\n@@ -957,38 +929,6 @@ cmd_pipeline_port_in(struct pmd_internals *softnic,\n \t\tstrlcpy(p.dev_name, tokens[t0 + 1], sizeof(p.dev_name));\n \n \t\tt0 += 2;\n-\t} else if (strcmp(tokens[t0], \"tap\") == 0) {\n-\t\tif (n_tokens < t0 + 6) {\n-\t\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH,\n-\t\t\t\t\"pipeline port in tap\");\n-\t\t\treturn;\n-\t\t}\n-\n-\t\tp.type = PORT_IN_TAP;\n-\n-\t\tstrlcpy(p.dev_name, tokens[t0 + 1], sizeof(p.dev_name));\n-\n-\t\tif (strcmp(tokens[t0 + 2], \"mempool\") != 0) {\n-\t\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND,\n-\t\t\t\t\"mempool\");\n-\t\t\treturn;\n-\t\t}\n-\n-\t\tp.tap.mempool_name = tokens[t0 + 3];\n-\n-\t\tif (strcmp(tokens[t0 + 4], \"mtu\") != 0) {\n-\t\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND,\n-\t\t\t\t\"mtu\");\n-\t\t\treturn;\n-\t\t}\n-\n-\t\tif (softnic_parser_read_uint32(&p.tap.mtu,\n-\t\t\ttokens[t0 + 5]) != 0) {\n-\t\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"mtu\");\n-\t\t\treturn;\n-\t\t}\n-\n-\t\tt0 += 6;\n \t} else if (strcmp(tokens[t0], \"source\") == 0) {\n \t\tif (n_tokens < t0 + 6) {\n \t\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH,\n@@ -1074,7 +1014,6 @@ cmd_pipeline_port_in(struct pmd_internals *softnic,\n * bsz <burst_size>\n * link <link_name> txq <txq_id>\n * | swq <swq_name>\n- * | tap <tap_name>\n * | sink [file <file_name> pkts <max_n_pkts>]\n */\n static void\n@@ -1147,16 +1086,6 @@ cmd_pipeline_port_out(struct pmd_internals *softnic,\n \n \t\tp.type = PORT_OUT_SWQ;\n \n-\t\tstrlcpy(p.dev_name, tokens[7], sizeof(p.dev_name));\n-\t} else if (strcmp(tokens[6], \"tap\") == 0) {\n-\t\tif (n_tokens != 8) {\n-\t\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH,\n-\t\t\t\t\"pipeline port out tap\");\n-\t\t\treturn;\n-\t\t}\n-\n-\t\tp.type = PORT_OUT_TAP;\n-\n \t\tstrlcpy(p.dev_name, tokens[7], sizeof(p.dev_name));\n \t} else if (strcmp(tokens[6], \"sink\") == 0) {\n \t\tif ((n_tokens != 7) && (n_tokens != 11)) {\n@@ -4600,11 +4529,6 @@ softnic_cli_process(char *in, char *out, size_t out_size, void *arg)\n \t\treturn;\n \t}\n \n-\tif (strcmp(tokens[0], \"tap\") == 0) {\n-\t\tcmd_tap(softnic, tokens, n_tokens, out, out_size);\n-\t\treturn;\n-\t}\n-\n \tif (strcmp(tokens[0], \"port\") == 0) {\n \t\tcmd_port_in_action_profile(softnic, tokens, n_tokens, out, out_size);\n \t\treturn;\ndiff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/drivers/net/softnic/rte_eth_softnic_internals.h\nindex ddcde99b98..df74c1fbdc 100644\n--- a/drivers/net/softnic/rte_eth_softnic_internals.h\n+++ b/drivers/net/softnic/rte_eth_softnic_internals.h\n@@ -89,17 +89,6 @@ struct softnic_link {\n \n TAILQ_HEAD(softnic_link_list, softnic_link);\n \n-/**\n- * TAP\n- */\n-struct softnic_tap {\n-\tTAILQ_ENTRY(softnic_tap) node;\n-\tchar name[NAME_SIZE];\n-\tint fd;\n-};\n-\n-TAILQ_HEAD(softnic_tap_list, softnic_tap);\n-\n /**\n * Input port action\n */\n@@ -163,7 +152,6 @@ struct pipeline_params {\n enum softnic_port_in_type {\n \tPORT_IN_RXQ,\n \tPORT_IN_SWQ,\n-\tPORT_IN_TAP,\n \tPORT_IN_SOURCE,\n };\n \n@@ -176,11 +164,6 @@ struct softnic_port_in_params {\n \t\t\tuint16_t queue_id;\n \t\t} rxq;\n \n-\t\tstruct {\n-\t\t\tconst char *mempool_name;\n-\t\t\tuint32_t mtu;\n-\t\t} tap;\n-\n \t\tstruct {\n \t\t\tconst char *mempool_name;\n \t\t\tconst char *file_name;\n@@ -196,7 +179,6 @@ struct softnic_port_in_params {\n enum softnic_port_out_type {\n \tPORT_OUT_TXQ,\n \tPORT_OUT_SWQ,\n-\tPORT_OUT_TAP,\n \tPORT_OUT_SINK,\n };\n \n@@ -385,7 +367,6 @@ struct pmd_internals {\n \tstruct softnic_mempool_list mempool_list;\n \tstruct softnic_swq_list swq_list;\n \tstruct softnic_link_list link_list;\n-\tstruct softnic_tap_list tap_list;\n \tstruct softnic_port_in_action_profile_list port_in_action_profile_list;\n \tstruct softnic_table_action_profile_list table_action_profile_list;\n \tstruct pipeline_list pipeline_list;\n@@ -466,23 +447,6 @@ softnic_link_create(struct pmd_internals *p,\n \tconst char *name,\n \tstruct softnic_link_params *params);\n \n-/**\n- * TAP\n- */\n-int\n-softnic_tap_init(struct pmd_internals *p);\n-\n-void\n-softnic_tap_free(struct pmd_internals *p);\n-\n-struct softnic_tap *\n-softnic_tap_find(struct pmd_internals *p,\n-\tconst char *name);\n-\n-struct softnic_tap *\n-softnic_tap_create(struct pmd_internals *p,\n-\tconst char *name);\n-\n /**\n * Input port action\n */\ndiff --git a/drivers/net/softnic/rte_eth_softnic_pipeline.c b/drivers/net/softnic/rte_eth_softnic_pipeline.c\nindex 51a1ea73c0..7a2828b785 100644\n--- a/drivers/net/softnic/rte_eth_softnic_pipeline.c\n+++ b/drivers/net/softnic/rte_eth_softnic_pipeline.c\n@@ -293,25 +293,6 @@ softnic_pipeline_port_in_create(struct pmd_internals *softnic,\n \t\tbreak;\n \t}\n \n-\tcase PORT_IN_TAP:\n-\t{\n-\t\tstruct softnic_tap *tap;\n-\t\tstruct softnic_mempool *mempool;\n-\n-\t\ttap = softnic_tap_find(softnic, params->dev_name);\n-\t\tmempool = softnic_mempool_find(softnic, params->tap.mempool_name);\n-\t\tif (tap == NULL || mempool == NULL)\n-\t\t\treturn -1;\n-\n-\t\tpp.fd.fd = tap->fd;\n-\t\tpp.fd.mempool = mempool->m;\n-\t\tpp.fd.mtu = params->tap.mtu;\n-\n-\t\tp.ops = &rte_port_fd_reader_ops;\n-\t\tp.arg_create = &pp.fd;\n-\t\tbreak;\n-\t}\n-\n \tcase PORT_IN_SOURCE:\n \t{\n \t\tstruct softnic_mempool *mempool;\n@@ -499,31 +480,6 @@ softnic_pipeline_port_out_create(struct pmd_internals *softnic,\n \t\tbreak;\n \t}\n \n-\tcase PORT_OUT_TAP:\n-\t{\n-\t\tstruct softnic_tap *tap;\n-\n-\t\ttap = softnic_tap_find(softnic, params->dev_name);\n-\t\tif (tap == NULL)\n-\t\t\treturn -1;\n-\n-\t\tpp.fd.fd = tap->fd;\n-\t\tpp.fd.tx_burst_sz = params->burst_size;\n-\n-\t\tpp_nodrop.fd.fd = tap->fd;\n-\t\tpp_nodrop.fd.tx_burst_sz = params->burst_size;\n-\t\tpp_nodrop.fd.n_retries = params->n_retries;\n-\n-\t\tif (params->retry == 0) {\n-\t\t\tp.ops = &rte_port_fd_writer_ops;\n-\t\t\tp.arg_create = &pp.fd;\n-\t\t} else {\n-\t\t\tp.ops = &rte_port_fd_writer_nodrop_ops;\n-\t\t\tp.arg_create = &pp_nodrop.fd;\n-\t\t}\n-\t\tbreak;\n-\t}\n-\n \tcase PORT_OUT_SINK:\n \t{\n \t\tpp.sink.file_name = params->sink.file_name;\ndiff --git a/drivers/net/softnic/rte_eth_softnic_tap.c b/drivers/net/softnic/rte_eth_softnic_tap.c\ndeleted file mode 100644\nindex 36fe9f0287..0000000000\n--- a/drivers/net/softnic/rte_eth_softnic_tap.c\n+++ /dev/null\n@@ -1,118 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2010-2018 Intel Corporation\n- */\n-\n-#include <netinet/in.h>\n-#ifdef RTE_EXEC_ENV_LINUX\n-#include <linux/if.h>\n-#include <linux/if_tun.h>\n-#endif\n-#include <sys/ioctl.h>\n-\n-#include <fcntl.h>\n-#include <stdio.h>\n-#include <stdlib.h>\n-#include <string.h>\n-#include <unistd.h>\n-\n-#include <rte_string_fns.h>\n-\n-#include \"rte_eth_softnic_internals.h\"\n-\n-#define TAP_DEV \"/dev/net/tun\"\n-\n-int\n-softnic_tap_init(struct pmd_internals *p)\n-{\n-\tTAILQ_INIT(&p->tap_list);\n-\n-\treturn 0;\n-}\n-\n-void\n-softnic_tap_free(struct pmd_internals *p)\n-{\n-\tfor ( ; ; ) {\n-\t\tstruct softnic_tap *tap;\n-\n-\t\ttap = TAILQ_FIRST(&p->tap_list);\n-\t\tif (tap == NULL)\n-\t\t\tbreak;\n-\n-\t\tTAILQ_REMOVE(&p->tap_list, tap, node);\n-\t\tfree(tap);\n-\t}\n-}\n-\n-struct softnic_tap *\n-softnic_tap_find(struct pmd_internals *p,\n-\tconst char *name)\n-{\n-\tstruct softnic_tap *tap;\n-\n-\tif (name == NULL)\n-\t\treturn NULL;\n-\n-\tTAILQ_FOREACH(tap, &p->tap_list, node)\n-\t\tif (strcmp(tap->name, name) == 0)\n-\t\t\treturn tap;\n-\n-\treturn NULL;\n-}\n-\n-#ifndef RTE_EXEC_ENV_LINUX\n-\n-struct softnic_tap *\n-softnic_tap_create(struct pmd_internals *p __rte_unused,\n-\tconst char *name __rte_unused)\n-{\n-\treturn NULL;\n-}\n-\n-#else\n-\n-struct softnic_tap *\n-softnic_tap_create(struct pmd_internals *p,\n-\tconst char *name)\n-{\n-\tstruct softnic_tap *tap;\n-\tstruct ifreq ifr;\n-\tint fd, status;\n-\n-\t/* Check input params */\n-\tif (name == NULL ||\n-\t\tsoftnic_tap_find(p, name))\n-\t\treturn NULL;\n-\n-\t/* Resource create */\n-\tfd = open(TAP_DEV, O_RDWR | O_NONBLOCK);\n-\tif (fd < 0)\n-\t\treturn NULL;\n-\n-\tmemset(&ifr, 0, sizeof(ifr));\n-\tifr.ifr_flags = IFF_TAP | IFF_NO_PI; /* No packet information */\n-\tstrlcpy(ifr.ifr_name, name, IFNAMSIZ);\n-\n-\tstatus = ioctl(fd, TUNSETIFF, (void *)&ifr);\n-\tif (status < 0) {\n-\t\tclose(fd);\n-\t\treturn NULL;\n-\t}\n-\n-\t/* Node allocation */\n-\ttap = calloc(1, sizeof(struct softnic_tap));\n-\tif (tap == NULL) {\n-\t\tclose(fd);\n-\t\treturn NULL;\n-\t}\n-\t/* Node fill in */\n-\tstrlcpy(tap->name, name, sizeof(tap->name));\n-\ttap->fd = fd;\n-\n-\t/* Node add to list */\n-\tTAILQ_INSERT_TAIL(&p->tap_list, tap, node);\n-\n-\treturn tap;\n-}\n-\n-#endif\n", "prefixes": [ "V2", "05/21" ] }