Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115486/?format=api
{ "id": 115486, "url": "http://patches.dpdk.org/api/patches/115486/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220826124208.671400-8-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220826124208.671400-8-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220826124208.671400-8-david.marchand@redhat.com", "date": "2022-08-26T12:41:48", "name": "[v4,07/27] dev: hide debug messages in device iterator", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ad978992e544d7149d340a1818e7bb68398c65f8", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220826124208.671400-8-david.marchand@redhat.com/mbox/", "series": [ { "id": 24428, "url": "http://patches.dpdk.org/api/series/24428/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24428", "date": "2022-08-26T12:41:41", "name": "Bus and device cleanup for 22.11", "version": 4, "mbox": "http://patches.dpdk.org/series/24428/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115486/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115486/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82C02A0550;\n\tFri, 26 Aug 2022 14:43:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C290540A80;\n\tFri, 26 Aug 2022 14:42:50 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id E0AC840143\n for <dev@dpdk.org>; Fri, 26 Aug 2022 14:42:48 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-365-806MI9oVNQyuF_pODE-ukw-1; Fri, 26 Aug 2022 08:42:42 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDE903817A6D;\n Fri, 26 Aug 2022 12:42:41 +0000 (UTC)", "from fchome.redhat.com (unknown [10.40.193.251])\n by smtp.corp.redhat.com (Postfix) with ESMTP id BFF1B141510F;\n Fri, 26 Aug 2022 12:42:40 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1661517768;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=JHrvXXARgJBOV+K4etbQE6SOwGhN/4WXEqNSDtdqleQ=;\n b=WT4vYC7haAsTiFZYeUwsi5Z3BWj4TgiKeEx9aY44hs9gKCYjaufBuLpYhINKpGhAWhzxv7\n nPtRnSKwXwZB01sySnUcYFyxWKFmh2zKgrlNz/KQcfJig5b6IuaWFf1WragcKQ61b5Kwod\n d/SzQIgbeMuZITOxSylHEyNJ8NZfAws=", "X-MC-Unique": "806MI9oVNQyuF_pODE-ukw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com,\n Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>", "Subject": "[PATCH v4 07/27] dev: hide debug messages in device iterator", "Date": "Fri, 26 Aug 2022 14:41:48 +0200", "Message-Id": "<20220826124208.671400-8-david.marchand@redhat.com>", "In-Reply-To": "<20220826124208.671400-1-david.marchand@redhat.com>", "References": "<20220628144643.1213026-1-david.marchand@redhat.com>\n <20220826124208.671400-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For any bus that does not support device iteration, rte_dev_iterator_init\nboth returned an error code and logged an error message.\nAn application (like testpmd) that only wants to list devices, would have\nno choice but to inspect a bus object to avoid spewing error logs.\n\nMake those log messages debug level, and remove the check in testpmd.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test-pmd/config.c | 4 ----\n lib/eal/common/eal_common_dev.c | 7 +++----\n 2 files changed, 3 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 3a53b616d8..bc73819183 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -641,10 +641,6 @@ device_infos_display(const char *identifier)\n \t\tif (identifier && da.bus != next)\n \t\t\tcontinue;\n \n-\t\t/* Skip buses that don't have iterate method */\n-\t\tif (!next->dev_iterate)\n-\t\t\tcontinue;\n-\n \t\tsnprintf(devstr, sizeof(devstr), \"bus=%s\", next->name);\n \t\tRTE_DEV_FOREACH(dev, devstr, &dev_iter) {\n \ndiff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c\nindex 9d913e5478..b6f0392f30 100644\n--- a/lib/eal/common/eal_common_dev.c\n+++ b/lib/eal/common/eal_common_dev.c\n@@ -592,18 +592,17 @@ rte_dev_iterator_init(struct rte_dev_iterator *it,\n \t * one layer specified.\n \t */\n \tif (bus == NULL && cls == NULL) {\n-\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\"Either bus or class must be specified.\\n\");\n+\t\tRTE_LOG(DEBUG, EAL, \"Either bus or class must be specified.\\n\");\n \t\trte_errno = EINVAL;\n \t\tgoto get_out;\n \t}\n \tif (bus != NULL && bus->dev_iterate == NULL) {\n-\t\tRTE_LOG(ERR, EAL, \"Bus %s not supported\\n\", bus->name);\n+\t\tRTE_LOG(DEBUG, EAL, \"Bus %s not supported\\n\", bus->name);\n \t\trte_errno = ENOTSUP;\n \t\tgoto get_out;\n \t}\n \tif (cls != NULL && cls->dev_iterate == NULL) {\n-\t\tRTE_LOG(ERR, EAL, \"Class %s not supported\\n\", cls->name);\n+\t\tRTE_LOG(DEBUG, EAL, \"Class %s not supported\\n\", cls->name);\n \t\trte_errno = ENOTSUP;\n \t\tgoto get_out;\n \t}\n", "prefixes": [ "v4", "07/27" ] }