Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 115423,
    "url": "http://patches.dpdk.org/api/patches/115423/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220825153709.33181-4-dmitry.kozliuk@gmail.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220825153709.33181-4-dmitry.kozliuk@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220825153709.33181-4-dmitry.kozliuk@gmail.com",
    "date": "2022-08-25T15:37:08",
    "name": "[v2,3/4] eal: uninline rte_str_to_size",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e1cc88212c3baba6dc27a48875da18c6efdaf9a3",
    "submitter": {
        "id": 1581,
        "url": "http://patches.dpdk.org/api/people/1581/?format=api",
        "name": "Dmitry Kozlyuk",
        "email": "dmitry.kozliuk@gmail.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220825153709.33181-4-dmitry.kozliuk@gmail.com/mbox/",
    "series": [
        {
            "id": 24411,
            "url": "http://patches.dpdk.org/api/series/24411/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24411",
            "date": "2022-08-25T15:37:05",
            "name": "eal: small rte_common.h fixes and cleanup",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/24411/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/115423/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/115423/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BC2C4A0547;\n\tThu, 25 Aug 2022 17:37:41 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1689C4281C;\n\tThu, 25 Aug 2022 17:37:31 +0200 (CEST)",
            "from mail-lf1-f42.google.com (mail-lf1-f42.google.com\n [209.85.167.42]) by mails.dpdk.org (Postfix) with ESMTP id D5D05415D7\n for <dev@dpdk.org>; Thu, 25 Aug 2022 17:37:27 +0200 (CEST)",
            "by mail-lf1-f42.google.com with SMTP id s1so25932444lfp.6\n for <dev@dpdk.org>; Thu, 25 Aug 2022 08:37:27 -0700 (PDT)",
            "from sovereign.. (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23]) by smtp.gmail.com with ESMTPSA id\n r2-20020ac25c02000000b0048a9e899693sm562909lfp.16.2022.08.25.08.37.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 25 Aug 2022 08:37:26 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc;\n bh=zenFBCYP3ig2zKLvJ8GGjWTGkwpnUUqkE2EdFf4PgSo=;\n b=PuiVzYchAX4837C9Bv4TNyIktcjKspOX8T5ULy5qSiRQNEf0Zut4u0wAd66uTi4Tbv\n J8BSmBjdW7O5hbOt32OowVPtdCPOx8dub6ndJyBVppl5Rv+b2GSMQAsg+Px0L7ExAEdO\n sZDo2hcXva/NMTgRW32QVtgGmXA+V9HMQFv6JpW7A5UFPExON3wToGf/vE8cJaaIkms4\n 1gQZdPDDwlntwEZKWJuhdCCsvKYwSNa0znCNNzcHXguO1eq9fMhxdvz1eGonCf4BYq61\n dF7ulRMqoGaxIjGdAxGGUD1sSux64UYwz7Rqz/pHK1QaksgR0ZyU7OTCuG7nbHOp/d6F\n DmJg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n bh=zenFBCYP3ig2zKLvJ8GGjWTGkwpnUUqkE2EdFf4PgSo=;\n b=rBWDZf9sn9lBchIAzi4o9HsWIc9BlF4l+6FbfAkPiDdlPCIgPhwZs5gT69g3Kz5jIO\n 5b0+4UL25qczX8eyHv9XAokKePX8egQSqaFUFE7/oRDIpTspWlJH2QXtOUKJR3xp/y9x\n a73nfmCEyyi3LVZZBrPAkmoP6KYSbvRkh9rmQFiWsicK//wyLq2ZHPFSjDv0XUSsMiig\n NW8iWsW7XGLT1G5GlKPu+8tGUSqJWnP1GLLv8pHBZf5iUAn7ggRBouHlhzOO5Bvp6dWN\n UtYmIWMbFj1yrth4OGoB/hT54TeSZRVWphpQ2Tes+zvurcm5Z9yoNn32g8dK0qfHX30M\n NsoA==",
        "X-Gm-Message-State": "ACgBeo0jEdlSqt5wFuqFZEo6xBWeun/LJbC7fGka/5AikK3p4Tz2fG+o\n Ew4/tm2Z6aScrb8GNAmGiKk1zMW619g=",
        "X-Google-Smtp-Source": "\n AA6agR5bLmHGRO02Bq5MgC1rZtkmliCyxSpGhloH3ES7OaLUQv/9hgE2/mRiufrlz4y4d3mrMFNxSw==",
        "X-Received": "by 2002:ac2:4d45:0:b0:492:d8a2:de61 with SMTP id\n 5-20020ac24d45000000b00492d8a2de61mr1428185lfp.313.1661441847233;\n Thu, 25 Aug 2022 08:37:27 -0700 (PDT)",
        "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Ray Kinsella <mdr@ashroe.eu>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>",
        "Subject": "[PATCH v2 3/4] eal: uninline rte_str_to_size",
        "Date": "Thu, 25 Aug 2022 18:37:08 +0300",
        "Message-Id": "<20220825153709.33181-4-dmitry.kozliuk@gmail.com>",
        "X-Mailer": "git-send-email 2.33.1",
        "In-Reply-To": "<20220825153709.33181-1-dmitry.kozliuk@gmail.com>",
        "References": "<20220821205009.1317044-1-dmitry.kozliuk@gmail.com>\n <20220825153709.33181-1-dmitry.kozliuk@gmail.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "There is no reason for rte_str_to_size() to be inline.\nMove the implementation out of <rte_common.h>.\nExport it as a stable ABI because it always has been public.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n lib/eal/common/eal_common_string_fns.c | 32 ++++++++++++++++++++++++++\n lib/eal/include/rte_common.h           | 30 ++----------------------\n lib/eal/version.map                    |  1 +\n 3 files changed, 35 insertions(+), 28 deletions(-)",
    "diff": "diff --git a/lib/eal/common/eal_common_string_fns.c b/lib/eal/common/eal_common_string_fns.c\nindex 0236ae4023..5fc4ee71dc 100644\n--- a/lib/eal/common/eal_common_string_fns.c\n+++ b/lib/eal/common/eal_common_string_fns.c\n@@ -64,3 +64,35 @@ rte_strscpy(char *dst, const char *src, size_t dsize)\n \trte_errno = E2BIG;\n \treturn -rte_errno;\n }\n+\n+uint64_t\n+rte_str_to_size(const char *str)\n+{\n+\tchar *endptr;\n+\tunsigned long long size;\n+\n+\twhile (isspace((int)*str))\n+\t\tstr++;\n+\tif (*str == '-')\n+\t\treturn 0;\n+\n+\terrno = 0;\n+\tsize = strtoull(str, &endptr, 0);\n+\tif (errno)\n+\t\treturn 0;\n+\n+\tif (*endptr == ' ')\n+\t\tendptr++; /* allow 1 space gap */\n+\n+\tswitch (*endptr) {\n+\tcase 'G': case 'g':\n+\t\tsize *= 1024; /* fall-through */\n+\tcase 'M': case 'm':\n+\t\tsize *= 1024; /* fall-through */\n+\tcase 'K': case 'k':\n+\t\tsize *= 1024; /* fall-through */\n+\tdefault:\n+\t\tbreak;\n+\t}\n+\treturn size;\n+}\ndiff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h\nindex b65555bac6..86c50c55e0 100644\n--- a/lib/eal/include/rte_common.h\n+++ b/lib/eal/include/rte_common.h\n@@ -873,34 +873,8 @@ rte_log2_u64(uint64_t v)\n  * @return\n  *     Number.\n  */\n-static inline uint64_t\n-rte_str_to_size(const char *str)\n-{\n-\tchar *endptr;\n-\tunsigned long long size;\n-\n-\twhile (isspace((int)*str))\n-\t\tstr++;\n-\tif (*str == '-')\n-\t\treturn 0;\n-\n-\terrno = 0;\n-\tsize = strtoull(str, &endptr, 0);\n-\tif (errno)\n-\t\treturn 0;\n-\n-\tif (*endptr == ' ')\n-\t\tendptr++; /* allow 1 space gap */\n-\n-\tswitch (*endptr){\n-\tcase 'G': case 'g': size *= 1024; /* fall-through */\n-\tcase 'M': case 'm': size *= 1024; /* fall-through */\n-\tcase 'K': case 'k': size *= 1024; /* fall-through */\n-\tdefault:\n-\t\tbreak;\n-\t}\n-\treturn size;\n-}\n+uint64_t\n+rte_str_to_size(const char *str);\n \n /**\n  * Function to terminate the application immediately, printing an error\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex 1f293e768b..773b0902c0 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -261,6 +261,7 @@ DPDK_23 {\n \trte_socket_id;\n \trte_socket_id_by_idx;\n \trte_srand;\n+\trte_str_to_size;\n \trte_strerror;\n \trte_strscpy;\n \trte_strsplit;\n",
    "prefixes": [
        "v2",
        "3/4"
    ]
}