Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115343/?format=api
http://patches.dpdk.org/api/patches/115343/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1661229305-240952-4-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1661229305-240952-4-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1661229305-240952-4-git-send-email-andy.pei@intel.com", "date": "2022-08-23T04:35:00", "name": "[3/8] vdpa/ifc: set max queues according to HW spec", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4b5ac810e5b3cabe1628a809d4debaadd9efdd0d", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1661229305-240952-4-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 24387, "url": "http://patches.dpdk.org/api/series/24387/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24387", "date": "2022-08-23T04:34:57", "name": "add multi queue support to vDPA ifc driver", "version": 1, "mbox": "http://patches.dpdk.org/series/24387/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115343/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/115343/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 09ABFA0093;\n\tTue, 23 Aug 2022 07:25:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 808234281B;\n\tTue, 23 Aug 2022 07:24:49 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id CFFC74281B\n for <dev@dpdk.org>; Tue, 23 Aug 2022 07:24:47 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Aug 2022 22:24:47 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.251])\n by fmsmga008.fm.intel.com with ESMTP; 22 Aug 2022 22:24:45 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1661232288; x=1692768288;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=MVNbXBjBKTeHXv4sSe9YudTelWhvDBk09Y5qNYuM5N4=;\n b=jHC03Kpy/SXEtIWNgD1qw1K4Xg7RBfemOMnyVS/S5BK5/QaE4rnyvAjO\n j0UjUDa+dgTPmxNaiZvvwtZn41uwE2UlSb4TDgpmOImqJ6c0guizgbSrE\n B576B0aASSYM2DSgXfe3xhDAhT2x73xlDrIsM2lHh9ddtVwGF1v/WMpht\n Sy11WlsM4Cd2m3E9+yAKHwJloYdxEh+klTTrHYlrDo0N40N09EJEofBqW\n SSBiGuu+pzintpI9LcNy0DE6ho9Yzd3GKSoc/VU4mCLf2P1n7ZCkxtkp/\n 8RsXhZrI5Gw7ctLu0J3GsjNAb0QV85dVr82Qwu3syderuwGKVqtp6p9ZZ w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10447\"; a=\"355325298\"", "E=Sophos;i=\"5.93,256,1654585200\"; d=\"scan'208\";a=\"355325298\"", "E=Sophos;i=\"5.93,256,1654585200\"; d=\"scan'208\";a=\"669864735\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com,\n gang.cao@intel.com, maxime.coquelin@redhat.com,\n Huang Wei <wei_huang@intel.com>", "Subject": "[PATCH 3/8] vdpa/ifc: set max queues according to HW spec", "Date": "Tue, 23 Aug 2022 12:35:00 +0800", "Message-Id": "<1661229305-240952-4-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1661229305-240952-1-git-send-email-andy.pei@intel.com>", "References": "<1661229305-240952-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Set max_queues according to virtio HW spec.\nFor virtio BLK device, set max_queues to the value of \"num_queues\".\n\"num_queues\" is element of struct virtio_blk_config.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\nSigned-off-by: Huang Wei <wei_huang@intel.com>\n---\n drivers/vdpa/ifc/base/ifcvf.h | 2 +-\n drivers/vdpa/ifc/ifcvf_vdpa.c | 18 +++++++++++++++++-\n 2 files changed, 18 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h\nindex ad505f1..c17bf2a 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.h\n+++ b/drivers/vdpa/ifc/base/ifcvf.h\n@@ -21,7 +21,7 @@\n #define IFCVF_NET_DEVICE_ID 0x0001\n #define IFCVF_BLK_DEVICE_ID 0x0002\n \n-#define IFCVF_MAX_QUEUES\t\t1\n+#define IFCVF_MAX_QUEUES\t\t32\n \n #ifndef VIRTIO_F_IOMMU_PLATFORM\n #define VIRTIO_F_IOMMU_PLATFORM\t\t33\ndiff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex 2d165c0..34aea6c 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -26,6 +26,18 @@\n \n #include \"base/ifcvf.h\"\n \n+/**\n+** RTE_MAX() and RTE_MIN() cannot be used since braced-group within\n+** expression allowed only inside a function, but MAX() is used as\n+** a number of elements in array.\n+**/\n+#ifndef MAX\n+#define MAX(v1, v2)\t((v1) > (v2) ? (v1) : (v2))\n+#endif\n+#ifndef MIN\n+#define MIN(v1, v2)\t((v1) < (v2) ? (v1) : (v2))\n+#endif\n+\n RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE);\n #define DRV_LOG(level, fmt, args...) \\\n \trte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \\\n@@ -1559,7 +1571,6 @@ struct rte_vdpa_dev_info dev_info[] = {\n \t}\n \n \tinternal->configured = 0;\n-\tinternal->max_queues = IFCVF_MAX_QUEUES;\n \tfeatures = ifcvf_get_features(&internal->hw);\n \n \tdevice_id = ifcvf_pci_get_device_type(pci_dev);\n@@ -1570,6 +1581,8 @@ struct rte_vdpa_dev_info dev_info[] = {\n \n \tif (device_id == VIRTIO_ID_NET) {\n \t\tinternal->hw.device_type = IFCVF_NET;\n+\t\tinternal->max_queues = MIN(IFCVF_MAX_QUEUES,\n+\t\t\t(internal->hw.common_cfg->num_queues - 1)/2);\n \t\tinternal->features = features &\n \t\t\t\t\t~(1ULL << VIRTIO_F_IOMMU_PLATFORM);\n \t\tinternal->features |= dev_info[IFCVF_NET].features;\n@@ -1609,6 +1622,9 @@ struct rte_vdpa_dev_info dev_info[] = {\n \t\t\tinternal->hw.blk_cfg->geometry.sectors);\n \t\tDRV_LOG(DEBUG, \"num_queues: 0x%08x\",\n \t\t\tinternal->hw.blk_cfg->num_queues);\n+\n+\t\tinternal->max_queues = MIN(IFCVF_MAX_QUEUES,\n+\t\t\tinternal->hw.blk_cfg->num_queues);\n \t}\n \n \tlist->internal = internal;\n", "prefixes": [ "3/8" ] }{ "id": 115343, "url": "