Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115034/?format=api
{ "id": 115034, "url": "http://patches.dpdk.org/api/patches/115034/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220815073206.2917968-7-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220815073206.2917968-7-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220815073206.2917968-7-qi.z.zhang@intel.com", "date": "2022-08-15T07:31:02", "name": "[v2,06/70] net/ice/base: added auto drop blocking packets functionality", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9037467394fe8c581756a0436ff91ca0eb4cec2a", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220815073206.2917968-7-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 24308, "url": "http://patches.dpdk.org/api/series/24308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24308", "date": "2022-08-15T07:30:56", "name": "ice base code update", "version": 2, "mbox": "http://patches.dpdk.org/series/24308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115034/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115034/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C6E59A00C3;\n\tMon, 15 Aug 2022 01:22:50 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8A96542B98;\n\tMon, 15 Aug 2022 01:22:26 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 4DFC142905\n for <dev@dpdk.org>; Mon, 15 Aug 2022 01:22:24 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Aug 2022 16:22:23 -0700", "from dpdk-qzhan15-test02.sh.intel.com ([10.67.115.4])\n by orsmga008.jf.intel.com with ESMTP; 14 Aug 2022 16:22:22 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1660519344; x=1692055344;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=6D8R+669MYEXbC4+vvojJXztFZ0cRp1m3De9j092BFI=;\n b=mkm66u3URrxJRecxTdEVy2Zzz/fpYzI068Kq2WjrNSNRM5MmVwrltNNF\n FL/j8zABlkZvWIYSV04psODDgIpRAGv03e1cSYqAdBXNDIwA8+C2V11kt\n 5UqGkkDAvU0SXk+A6sico9eMn8cQ5Nle0wcV/1OYpLrpDjnkoTvA31Dc8\n sKquXBfb1/Pv1RZNAx2tJas87bJQ+cVCbI4hOekFQgsiFUtaWmGdRrlnv\n qnao1nhcwhR5Ysy7YsDPnn5S6IX/X9FCaRnUQpbulbXvydOiw3zgWqGrA\n I+h+3sLTYe8x6XarxlTMriJqb4a5gx801SVNg5WOGnu/FPAYzNitvgxWY A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10439\"; a=\"291857921\"", "E=Sophos;i=\"5.93,237,1654585200\"; d=\"scan'208\";a=\"291857921\"", "E=Sophos;i=\"5.93,237,1654585200\"; d=\"scan'208\";a=\"635283003\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Mateusz Rusinski <mateusz.rusinski@intel.com>", "Subject": "[PATCH v2 06/70] net/ice/base: added auto drop blocking packets\n functionality", "Date": "Mon, 15 Aug 2022 03:31:02 -0400", "Message-Id": "<20220815073206.2917968-7-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220815073206.2917968-1-qi.z.zhang@intel.com>", "References": "<20220815071306.2910599-1-qi.z.zhang@intel.com>\n <20220815073206.2917968-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Extended ice_aq_set_mac_cfg()function to add support for\nauto drop blocking packets.\n\nSigned-off-by: Mateusz Rusinski <mateusz.rusinski@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 22 ++++++++++++++++++++--\n drivers/net/ice/base/ice_common.h | 5 ++++-\n drivers/net/ice/base/ice_type.h | 6 ++++++\n drivers/net/ice/ice_ethdev.c | 2 +-\n 4 files changed, 31 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex edc24030ec..f9640d9403 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -788,12 +788,14 @@ ice_fill_tx_timer_and_fc_thresh(struct ice_hw *hw,\n * ice_aq_set_mac_cfg\n * @hw: pointer to the HW struct\n * @max_frame_size: Maximum Frame Size to be supported\n+ * @auto_drop: Tell HW to drop packets if TC queue is blocked\n * @cd: pointer to command details structure or NULL\n *\n * Set MAC configuration (0x0603)\n */\n enum ice_status\n-ice_aq_set_mac_cfg(struct ice_hw *hw, u16 max_frame_size, struct ice_sq_cd *cd)\n+ice_aq_set_mac_cfg(struct ice_hw *hw, u16 max_frame_size, bool auto_drop,\n+\t\t struct ice_sq_cd *cd)\n {\n \tstruct ice_aqc_set_mac_cfg *cmd;\n \tstruct ice_aq_desc desc;\n@@ -807,6 +809,8 @@ ice_aq_set_mac_cfg(struct ice_hw *hw, u16 max_frame_size, struct ice_sq_cd *cd)\n \n \tcmd->max_frame_size = CPU_TO_LE16(max_frame_size);\n \n+\tif (ice_is_fw_auto_drop_supported(hw) && auto_drop)\n+\t\tcmd->drop_opts |= ICE_AQ_SET_MAC_AUTO_DROP_BLOCKING_PKTS;\n \tice_fill_tx_timer_and_fc_thresh(hw, cmd);\n \n \treturn ice_aq_send_cmd(hw, &desc, NULL, 0, cd);\n@@ -1106,7 +1110,8 @@ enum ice_status ice_init_hw(struct ice_hw *hw)\n \t\tgoto err_unroll_fltr_mgmt_struct;\n \n \t/* enable jumbo frame support at MAC level */\n-\tstatus = ice_aq_set_mac_cfg(hw, ICE_AQ_SET_MAC_FRAME_SIZE_MAX, NULL);\n+\tstatus = ice_aq_set_mac_cfg(hw, ICE_AQ_SET_MAC_FRAME_SIZE_MAX, false,\n+\t\t\t\t NULL);\n \tif (status)\n \t\tgoto err_unroll_fltr_mgmt_struct;\n \n@@ -5921,3 +5926,16 @@ bool ice_fw_supports_report_dflt_cfg(struct ice_hw *hw)\n \t}\n \treturn false;\n }\n+/**\n+ * ice_is_fw_auto_drop_supported\n+ * @hw: pointer to the hardware structure\n+ *\n+ * Checks if the firmware supports auto drop feature\n+ */\n+bool ice_is_fw_auto_drop_supported(struct ice_hw *hw)\n+{\n+\tif (hw->api_maj_ver >= ICE_FW_API_AUTO_DROP_MAJ &&\n+\t hw->api_min_ver >= ICE_FW_API_AUTO_DROP_MIN)\n+\t\treturn true;\n+\treturn false;\n+}\ndiff --git a/drivers/net/ice/base/ice_common.h b/drivers/net/ice/base/ice_common.h\nindex 1044a3088e..1051cc1176 100644\n--- a/drivers/net/ice/base/ice_common.h\n+++ b/drivers/net/ice/base/ice_common.h\n@@ -191,7 +191,8 @@ enum ice_status\n ice_aq_set_link_restart_an(struct ice_port_info *pi, bool ena_link,\n \t\t\t struct ice_sq_cd *cd);\n enum ice_status\n-ice_aq_set_mac_cfg(struct ice_hw *hw, u16 max_frame_size, struct ice_sq_cd *cd);\n+ice_aq_set_mac_cfg(struct ice_hw *hw, u16 max_frame_size, bool auto_drop,\n+\t\t struct ice_sq_cd *cd);\n enum ice_status\n ice_aq_get_link_info(struct ice_port_info *pi, bool ena_lse,\n \t\t struct ice_link_status *link, struct ice_sq_cd *cd);\n@@ -289,4 +290,6 @@ ice_aq_write_i2c(struct ice_hw *hw, struct ice_aqc_link_topo_addr topo_addr,\n \t\t u16 bus_addr, __le16 addr, u8 params, u8 *data,\n \t\t struct ice_sq_cd *cd);\n bool ice_fw_supports_report_dflt_cfg(struct ice_hw *hw);\n+/* AQ API version for FW auto drop reports */\n+bool ice_is_fw_auto_drop_supported(struct ice_hw *hw);\n #endif /* _ICE_COMMON_H_ */\ndiff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h\nindex 3da3de38af..15b12bfc8d 100644\n--- a/drivers/net/ice/base/ice_type.h\n+++ b/drivers/net/ice/base/ice_type.h\n@@ -1539,5 +1539,11 @@ struct ice_aq_get_set_rss_lut_params {\n /* AQ API version for report default configuration */\n #define ICE_FW_API_REPORT_DFLT_CFG_MAJ\t\t1\n #define ICE_FW_API_REPORT_DFLT_CFG_MIN\t\t7\n+\n #define ICE_FW_API_REPORT_DFLT_CFG_PATCH\t3\n+/* AQ API version for FW auto drop reports */\n+#define ICE_FW_API_AUTO_DROP_MAJ\t\t1\n+#define ICE_FW_API_AUTO_DROP_MIN\t\t4\n+\n+\n #endif /* _ICE_TYPE_H_ */\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 587b01cf23..2e522376e3 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -3662,7 +3662,7 @@ ice_dev_start(struct rte_eth_dev *dev)\n \t\tICE_FRAME_SIZE_MAX;\n \n \t/* Set the max frame size to HW*/\n-\tice_aq_set_mac_cfg(hw, max_frame_size, NULL);\n+\tice_aq_set_mac_cfg(hw, max_frame_size, false, NULL);\n \n \tif (ad->devargs.pps_out_ena) {\n \t\tret = ice_pps_out_cfg(hw, pin_idx, timer);\n", "prefixes": [ "v2", "06/70" ] }