Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115031/?format=api
{ "id": 115031, "url": "http://patches.dpdk.org/api/patches/115031/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220815073206.2917968-4-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220815073206.2917968-4-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220815073206.2917968-4-qi.z.zhang@intel.com", "date": "2022-08-15T07:30:59", "name": "[v2,03/70] net/ice/base: combine functions for VSI promisc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3054d8fa8d5fd70189bb225f81fc6ece93746f34", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220815073206.2917968-4-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 24308, "url": "http://patches.dpdk.org/api/series/24308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24308", "date": "2022-08-15T07:30:56", "name": "ice base code update", "version": 2, "mbox": "http://patches.dpdk.org/series/24308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/115031/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/115031/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AE901A00C3;\n\tMon, 15 Aug 2022 01:22:33 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E59F342685;\n\tMon, 15 Aug 2022 01:22:20 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id EA796427F9\n for <dev@dpdk.org>; Mon, 15 Aug 2022 01:22:18 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Aug 2022 16:22:18 -0700", "from dpdk-qzhan15-test02.sh.intel.com ([10.67.115.4])\n by orsmga008.jf.intel.com with ESMTP; 14 Aug 2022 16:22:17 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1660519339; x=1692055339;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=FpMBRmcA4/j+c5uVHSN5c8R6sNVERw/9xQ3n0uwJX+s=;\n b=V5OW00C0B5XJS/6wLc95/zzmZs/WzuVtWexhd6XftEnf32Wm4WWJVPg9\n ++QgrD/SKi/UmY/9oUi4c8uekbOJ5F4zEmLhLuLnFSOUzYfYNAV3N9YWr\n eq0Bz4PiVL3dv7jObJbD29x2AuwRNZqD6KQsUShFJYO50m7u3XKrfIEkP\n HR8rMKqi3Rb2HhaGmbdSBhYCQBRgla2UbcZ6KRF4NaeXcTRk7rmKsKm1U\n 7gxqmkKNLcs06/JIomVVIIqTK25u202p8SsOgtAmCzQ9HoZu+BSWtOs7f\n o2aeb+syX52jYPk53Y4NyxH47np1lhYUopmrOefnA7GVx1SIIxil0Ylhn Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10439\"; a=\"291857912\"", "E=Sophos;i=\"5.93,237,1654585200\"; d=\"scan'208\";a=\"291857912\"", "E=Sophos;i=\"5.93,237,1654585200\"; d=\"scan'208\";a=\"635282987\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Wiktor Pilarczyk <wiktor.pilarczyk@intel.com>", "Subject": "[PATCH v2 03/70] net/ice/base: combine functions for VSI promisc", "Date": "Mon, 15 Aug 2022 03:30:59 -0400", "Message-Id": "<20220815073206.2917968-4-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220815073206.2917968-1-qi.z.zhang@intel.com>", "References": "<20220815071306.2910599-1-qi.z.zhang@intel.com>\n <20220815073206.2917968-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove ice_get_vsi_vlan_promisc,\ncause of similar implementation as ice_get_vsi_promisc,\nwhich will now handle the use case of ice_get_vsi_vlan_promisc.\n\nSigned-off-by: Wiktor Pilarczyk <wiktor.pilarczyk@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_switch.c | 58 ++++++-------------------------\n 1 file changed, 11 insertions(+), 47 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex c0df3a1815..513623a0a4 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -5825,22 +5825,25 @@ static u8 ice_determine_promisc_mask(struct ice_fltr_info *fi)\n * @promisc_mask: pointer to mask to be filled in\n * @vid: VLAN ID of promisc VLAN VSI\n * @sw: pointer to switch info struct for which function add rule\n+ * @lkup: switch rule filter lookup type\n */\n static enum ice_status\n _ice_get_vsi_promisc(struct ice_hw *hw, u16 vsi_handle, u8 *promisc_mask,\n-\t\t u16 *vid, struct ice_switch_info *sw)\n+\t\t u16 *vid, struct ice_switch_info *sw,\n+\t\t enum ice_sw_lkup_type lkup)\n {\n \tstruct ice_fltr_mgmt_list_entry *itr;\n \tstruct LIST_HEAD_TYPE *rule_head;\n \tstruct ice_lock *rule_lock;\t/* Lock to protect filter rule list */\n \n-\tif (!ice_is_vsi_valid(hw, vsi_handle))\n+\tif (!ice_is_vsi_valid(hw, vsi_handle) ||\n+\t (lkup != ICE_SW_LKUP_PROMISC && lkup != ICE_SW_LKUP_PROMISC_VLAN))\n \t\treturn ICE_ERR_PARAM;\n \n \t*vid = 0;\n \t*promisc_mask = 0;\n-\trule_head = &sw->recp_list[ICE_SW_LKUP_PROMISC].filt_rules;\n-\trule_lock = &sw->recp_list[ICE_SW_LKUP_PROMISC].filt_rule_lock;\n+\trule_head = &sw->recp_list[lkup].filt_rules;\n+\trule_lock = &sw->recp_list[lkup].filt_rule_lock;\n \n \tice_acquire_lock(rule_lock);\n \tLIST_FOR_EACH_ENTRY(itr, rule_head,\n@@ -5870,47 +5873,7 @@ ice_get_vsi_promisc(struct ice_hw *hw, u16 vsi_handle, u8 *promisc_mask,\n \t\t u16 *vid)\n {\n \treturn _ice_get_vsi_promisc(hw, vsi_handle, promisc_mask,\n-\t\t\t\t vid, hw->switch_info);\n-}\n-\n-/**\n- * _ice_get_vsi_vlan_promisc - get VLAN promiscuous mode of given VSI\n- * @hw: pointer to the hardware structure\n- * @vsi_handle: VSI handle to retrieve info from\n- * @promisc_mask: pointer to mask to be filled in\n- * @vid: VLAN ID of promisc VLAN VSI\n- * @sw: pointer to switch info struct for which function add rule\n- */\n-static enum ice_status\n-_ice_get_vsi_vlan_promisc(struct ice_hw *hw, u16 vsi_handle, u8 *promisc_mask,\n-\t\t\t u16 *vid, struct ice_switch_info *sw)\n-{\n-\tstruct ice_fltr_mgmt_list_entry *itr;\n-\tstruct LIST_HEAD_TYPE *rule_head;\n-\tstruct ice_lock *rule_lock;\t/* Lock to protect filter rule list */\n-\n-\tif (!ice_is_vsi_valid(hw, vsi_handle))\n-\t\treturn ICE_ERR_PARAM;\n-\n-\t*vid = 0;\n-\t*promisc_mask = 0;\n-\trule_head = &sw->recp_list[ICE_SW_LKUP_PROMISC_VLAN].filt_rules;\n-\trule_lock = &sw->recp_list[ICE_SW_LKUP_PROMISC_VLAN].filt_rule_lock;\n-\n-\tice_acquire_lock(rule_lock);\n-\tLIST_FOR_EACH_ENTRY(itr, rule_head, ice_fltr_mgmt_list_entry,\n-\t\t\t list_entry) {\n-\t\t/* Continue if this filter doesn't apply to this VSI or the\n-\t\t * VSI ID is not in the VSI map for this filter\n-\t\t */\n-\t\tif (!ice_vsi_uses_fltr(itr, vsi_handle))\n-\t\t\tcontinue;\n-\n-\t\t*promisc_mask |= ice_determine_promisc_mask(&itr->fltr_info);\n-\t}\n-\tice_release_lock(rule_lock);\n-\n-\treturn ICE_SUCCESS;\n+\t\t\t\t vid, hw->switch_info, ICE_SW_LKUP_PROMISC);\n }\n \n /**\n@@ -5924,8 +5887,9 @@ enum ice_status\n ice_get_vsi_vlan_promisc(struct ice_hw *hw, u16 vsi_handle, u8 *promisc_mask,\n \t\t\t u16 *vid)\n {\n-\treturn _ice_get_vsi_vlan_promisc(hw, vsi_handle, promisc_mask,\n-\t\t\t\t\t vid, hw->switch_info);\n+\treturn _ice_get_vsi_promisc(hw, vsi_handle, promisc_mask,\n+\t\t\t\t vid, hw->switch_info,\n+\t\t\t\t ICE_SW_LKUP_PROMISC_VLAN);\n }\n \n /**\n", "prefixes": [ "v2", "03/70" ] }