Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114984/?format=api
{ "id": 114984, "url": "http://patches.dpdk.org/api/patches/114984/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220815071306.2910599-28-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220815071306.2910599-28-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220815071306.2910599-28-qi.z.zhang@intel.com", "date": "2022-08-15T07:12:23", "name": "[27/70] net/ice/base: convert IO expander handle to u16", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dd3799103266429caba213f64033ae0c6a3c460e", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220815071306.2910599-28-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 24307, "url": "http://patches.dpdk.org/api/series/24307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24307", "date": "2022-08-15T07:11:56", "name": "ice base code update", "version": 1, "mbox": "http://patches.dpdk.org/series/24307/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/114984/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/114984/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F40A8A00C3;\n\tMon, 15 Aug 2022 01:06:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F3CCD41181;\n\tMon, 15 Aug 2022 01:03:57 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 06E6E42C08\n for <dev@dpdk.org>; Mon, 15 Aug 2022 01:03:54 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Aug 2022 16:03:54 -0700", "from dpdk-qzhan15-test02.sh.intel.com ([10.67.115.4])\n by fmsmga005.fm.intel.com with ESMTP; 14 Aug 2022 16:03:53 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1660518235; x=1692054235;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=kbSVhzGkATdbHWP375kfWEdJGKRjOZL2hKrnZ95xxxk=;\n b=KwVKIe0izJK8cnv181M8fER1AhPqTNAj9EWkE/YzstDvitfJM13RhGey\n iZwRYz0EWhUE4pmqcBwK+XJcXutEK22uF3XRsaVsUwQUf05pujG9BYTsD\n /pURPDDM1mJawsXy7TwPS6K62g4j+BfjnhkLVwlfkMhIJUek6jxNM8O8+\n I+meBxGORZEbBP7mI+vhedIQhngzctbIvTzRme2Nf3VF6mgZh5Ayqf4E2\n lEHoYzq3mq2/G2E+qsRduKCmDcM245yRwISnlv+Gr97s0L+Sj+7C/oE4X\n Zt5PcU8hEG31rbOdlin5bqWDdV30XSiP4hvjRVqODcIFag2lVkRYX4BMU A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10439\"; a=\"289427595\"", "E=Sophos;i=\"5.93,237,1654585200\"; d=\"scan'208\";a=\"289427595\"", "E=Sophos;i=\"5.93,237,1654585200\"; d=\"scan'208\";a=\"934296688\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Jacob Keller <jacob.e.keller@intel.com>", "Subject": "[PATCH 27/70] net/ice/base: convert IO expander handle to u16", "Date": "Mon, 15 Aug 2022 03:12:23 -0400", "Message-Id": "<20220815071306.2910599-28-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220815071306.2910599-1-qi.z.zhang@intel.com>", "References": "<20220815071306.2910599-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The io_expander_handle cached value is marked as an __le16, but\nseveral places track the node handle with u16 values. Unify all\nthe interfaces so that it is stored and reported as a u16, and\nkeep the low level conversion to LE16 only at the direct firmware\ninterface.\n\nThis fixes warnings from sparse about mixing __le16 and u16, and\nwill fix related issues on platforms which use Big Endian format.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_ptp_hw.c | 10 +++++++---\n drivers/net/ice/base/ice_type.h | 2 +-\n 2 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c\nindex 1fb0c57a8c..3df0915cd3 100644\n--- a/drivers/net/ice/base/ice_ptp_hw.c\n+++ b/drivers/net/ice/base/ice_ptp_hw.c\n@@ -4483,7 +4483,7 @@ ice_ptp_port_cmd_e810(struct ice_hw *hw, enum ice_ptp_tmr_cmd cmd,\n * will return cached value\n */\n static enum ice_status\n-ice_get_pca9575_handle(struct ice_hw *hw, __le16 *pca9575_handle)\n+ice_get_pca9575_handle(struct ice_hw *hw, u16 *pca9575_handle)\n {\n \tstruct ice_aqc_get_link_topo cmd;\n \tu8 node_part_number, idx;\n@@ -4564,13 +4564,15 @@ ice_read_pca9575_reg_e810t(struct ice_hw *hw, u8 offset, u8 *data)\n \tstruct ice_aqc_link_topo_addr link_topo;\n \tenum ice_status status;\n \t__le16 addr;\n+\tu16 handle;\n \n \tmemset(&link_topo, 0, sizeof(link_topo));\n \n-\tstatus = ice_get_pca9575_handle(hw, &link_topo.handle);\n+\tstatus = ice_get_pca9575_handle(hw, &handle);\n \tif (status)\n \t\treturn status;\n \n+\tlink_topo.handle = CPU_TO_LE16(handle);\n \tlink_topo.topo_params.node_type_ctx =\n \t\t(ICE_AQC_LINK_TOPO_NODE_CTX_PROVIDED <<\n \t\t ICE_AQC_LINK_TOPO_NODE_CTX_S);\n@@ -4594,13 +4596,15 @@ ice_write_pca9575_reg_e810t(struct ice_hw *hw, u8 offset, u8 data)\n \tstruct ice_aqc_link_topo_addr link_topo;\n \tenum ice_status status;\n \t__le16 addr;\n+\tu16 handle;\n \n \tmemset(&link_topo, 0, sizeof(link_topo));\n \n-\tstatus = ice_get_pca9575_handle(hw, &link_topo.handle);\n+\tstatus = ice_get_pca9575_handle(hw, &handle);\n \tif (status)\n \t\treturn status;\n \n+\tlink_topo.handle = CPU_TO_LE16(handle);\n \tlink_topo.topo_params.node_type_ctx =\n \t\t(ICE_AQC_LINK_TOPO_NODE_CTX_PROVIDED <<\n \t\t ICE_AQC_LINK_TOPO_NODE_CTX_S);\ndiff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h\nindex d94fdcda67..b8be0d948a 100644\n--- a/drivers/net/ice/base/ice_type.h\n+++ b/drivers/net/ice/base/ice_type.h\n@@ -1259,7 +1259,7 @@ struct ice_hw {\n \tstruct LIST_HEAD_TYPE rss_list_head;\n \tice_declare_bitmap(hw_ptype, ICE_FLOW_PTYPE_MAX);\n \tu8 dvm_ena;\n-\t__le16 io_expander_handle;\n+\tu16 io_expander_handle;\n };\n \n /* Statistics collected by each port, VSI, VEB, and S-channel */\n", "prefixes": [ "27/70" ] }