Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114705/?format=api
{ "id": 114705, "url": "http://patches.dpdk.org/api/patches/114705/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220808080606.220-16-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220808080606.220-16-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220808080606.220-16-anoobj@marvell.com", "date": "2022-08-08T08:06:03", "name": "[15/18] crypto/cnxk: remove unused ctx buf len", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5bad2a674258dd5b0ef78347adff1ef30d6f610f", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220808080606.220-16-anoobj@marvell.com/mbox/", "series": [ { "id": 24219, "url": "http://patches.dpdk.org/api/series/24219/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24219", "date": "2022-08-08T08:05:48", "name": "Fixes and improvements in cnxk crypto PMDs", "version": 1, "mbox": "http://patches.dpdk.org/series/24219/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/114705/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/114705/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DC904A034C;\n\tMon, 8 Aug 2022 10:07:50 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 301E942C88;\n\tMon, 8 Aug 2022 10:06:48 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 4CF4B42C83\n for <dev@dpdk.org>; Mon, 8 Aug 2022 10:06:47 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 277N0RZ4005916\n for <dev@dpdk.org>; Mon, 8 Aug 2022 01:06:46 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3hsqtmmxfb-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 08 Aug 2022 01:06:46 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Mon, 8 Aug 2022 01:06:44 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 8 Aug 2022 01:06:44 -0700", "from BG-LT92004.corp.innovium.com (unknown [10.28.160.62])\n by maili.marvell.com (Postfix) with ESMTP id C30AE3F7043;\n Mon, 8 Aug 2022 01:06:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=+eR4+SAOOB8HpaHv4i/xB0Vbm/PRHvFcJVxhlZZro14=;\n b=kaf1nOPt+yNxv1DSs5NShDu1WLC6ACPBbv757hRxPijQ36/otGqymZxatGFeRo0oZ3PG\n HExo1/o0rN+BM3iDPiFBhA35mA81Vdtgcnmvu2bVlFuPeYwAd1MDDHRfn/d4FjeffrPf\n 4tYvn0or2KPCGoyD0PCavX4DlIhZiLflwfOEEfsjawz/fboGoMC47Z9cj0d1FOifI8+r\n mVo3RUhhdDGNt46G+unti4b8vwRMguzpSTUvVpztizEPDef/iVpJKTHA+5hHEPQ2igYk\n TfofMxbOTMbqhT5+K3/7BSGqsQ91qOs3e+wCL30s1jnqCbHOj13x6/JmYLU/Bu73jtJU jg==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Jerin Jacob <jerinj@marvell.com>", "CC": "Archana Muniganti <marchana@marvell.com>, Tejasree Kondoj\n <ktejasree@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 15/18] crypto/cnxk: remove unused ctx buf len", "Date": "Mon, 8 Aug 2022 13:36:03 +0530", "Message-ID": "<20220808080606.220-16-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220808080606.220-1-anoobj@marvell.com>", "References": "<20220808080606.220-1-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "rEoNluYLLskaRoQCZmWYNcBzpad4GLtv", "X-Proofpoint-ORIG-GUID": "rEoNluYLLskaRoQCZmWYNcBzpad4GLtv", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1\n definitions=2022-08-08_05,2022-08-05_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Ctx len buf field is unused. Remove it.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/common/cnxk/roc_se.h | 45 +++++++++++++++--------------------\n drivers/crypto/cnxk/cnxk_se.h | 27 +++++++++++----------\n 2 files changed, 33 insertions(+), 39 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_se.h b/drivers/common/cnxk/roc_se.h\nindex 86bb3aa79d..d1a87a96da 100644\n--- a/drivers/common/cnxk/roc_se.h\n+++ b/drivers/common/cnxk/roc_se.h\n@@ -287,32 +287,6 @@ struct roc_se_iov_ptr {\n \tstruct roc_se_buf_ptr bufs[];\n };\n \n-struct roc_se_fc_params {\n-\t/* 0th cache line */\n-\tunion {\n-\t\tstruct roc_se_buf_ptr bufs[1];\n-\t\tstruct {\n-\t\t\tstruct roc_se_iov_ptr *src_iov;\n-\t\t\tstruct roc_se_iov_ptr *dst_iov;\n-\t\t};\n-\t};\n-\tvoid *iv_buf;\n-\tvoid *auth_iv_buf;\n-\tstruct roc_se_buf_ptr meta_buf;\n-\tstruct roc_se_buf_ptr ctx_buf;\n-\tuint32_t rsvd2;\n-\tuint8_t rsvd3;\n-\tuint8_t iv_ovr;\n-\tuint8_t cipher_iv_len;\n-\tuint8_t auth_iv_len;\n-\n-\t/* 1st cache line */\n-\tstruct roc_se_buf_ptr aad_buf __plt_cache_aligned;\n-\tstruct roc_se_buf_ptr mac_buf;\n-};\n-\n-PLT_STATIC_ASSERT((offsetof(struct roc_se_fc_params, aad_buf) % 128) == 0);\n-\n #define ROC_SE_PDCP_ALG_TYPE_ZUC\t 0\n #define ROC_SE_PDCP_ALG_TYPE_SNOW3G\t 1\n #define ROC_SE_PDCP_ALG_TYPE_AES_CTR\t 2\n@@ -349,6 +323,25 @@ struct roc_se_ctx {\n \tuint8_t *auth_key;\n };\n \n+struct roc_se_fc_params {\n+\tunion {\n+\t\tstruct roc_se_buf_ptr bufs[1];\n+\t\tstruct {\n+\t\t\tstruct roc_se_iov_ptr *src_iov;\n+\t\t\tstruct roc_se_iov_ptr *dst_iov;\n+\t\t};\n+\t};\n+\tvoid *iv_buf;\n+\tvoid *auth_iv_buf;\n+\tstruct roc_se_ctx *ctx;\n+\tstruct roc_se_buf_ptr meta_buf;\n+\tuint8_t cipher_iv_len;\n+\tuint8_t auth_iv_len;\n+\n+\tstruct roc_se_buf_ptr aad_buf;\n+\tstruct roc_se_buf_ptr mac_buf;\n+};\n+\n static inline void\n roc_se_zuc_bytes_swap(uint8_t *arr, int len)\n {\ndiff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h\nindex dc9621fb84..44b31bfe97 100644\n--- a/drivers/crypto/cnxk/cnxk_se.h\n+++ b/drivers/crypto/cnxk/cnxk_se.h\n@@ -334,7 +334,7 @@ cpt_digest_gen_prep(uint32_t flags, uint64_t d_lens,\n \tuint32_t g_size_bytes, s_size_bytes;\n \tunion cpt_inst_w4 cpt_inst_w4;\n \n-\tctx = params->ctx_buf.vaddr;\n+\tctx = params->ctx;\n \n \thash_type = ctx->hash_type;\n \tmac_len = ctx->mac_len;\n@@ -478,7 +478,8 @@ cpt_enc_hmac_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens,\n \t\taad_len = fc_params->aad_buf.size;\n \t\taad_buf = &fc_params->aad_buf;\n \t}\n-\tse_ctx = fc_params->ctx_buf.vaddr;\n+\n+\tse_ctx = fc_params->ctx;\n \tcipher_type = se_ctx->enc_cipher;\n \thash_type = se_ctx->hash_type;\n \tmac_len = se_ctx->mac_len;\n@@ -777,7 +778,7 @@ cpt_dec_hmac_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens,\n \t\taad_buf = &fc_params->aad_buf;\n \t}\n \n-\tse_ctx = fc_params->ctx_buf.vaddr;\n+\tse_ctx = fc_params->ctx;\n \thash_type = se_ctx->hash_type;\n \tmac_len = se_ctx->mac_len;\n \top_minor = se_ctx->template_w4.s.opcode_minor;\n@@ -1087,7 +1088,7 @@ cpt_pdcp_chain_alg_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \t\treturn -1;\n \t}\n \n-\tse_ctx = params->ctx_buf.vaddr;\n+\tse_ctx = params->ctx;\n \tmac_len = se_ctx->mac_len;\n \tpdcp_ci_alg = se_ctx->pdcp_ci_alg;\n \tpdcp_auth_alg = se_ctx->pdcp_auth_alg;\n@@ -1281,7 +1282,7 @@ cpt_pdcp_alg_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \tuint8_t pack_iv = 0;\n \tunion cpt_inst_w4 cpt_inst_w4;\n \n-\tse_ctx = params->ctx_buf.vaddr;\n+\tse_ctx = params->ctx;\n \tflags = se_ctx->zsk_flags;\n \tmac_len = se_ctx->mac_len;\n \n@@ -1562,7 +1563,7 @@ cpt_kasumi_enc_prep(uint32_t req_flags, uint64_t d_offs, uint64_t d_lens,\n \tencr_data_len = ROC_SE_ENCR_DLEN(d_lens);\n \tauth_data_len = ROC_SE_AUTH_DLEN(d_lens);\n \n-\tse_ctx = params->ctx_buf.vaddr;\n+\tse_ctx = params->ctx;\n \tflags = se_ctx->zsk_flags;\n \tmac_len = se_ctx->mac_len;\n \n@@ -1751,7 +1752,7 @@ cpt_kasumi_dec_prep(uint64_t d_offs, uint64_t d_lens,\n \tencr_offset = ROC_SE_ENCR_OFFSET(d_offs) / 8;\n \tencr_data_len = ROC_SE_ENCR_DLEN(d_lens);\n \n-\tse_ctx = params->ctx_buf.vaddr;\n+\tse_ctx = params->ctx;\n \tflags = se_ctx->zsk_flags;\n \n \tcpt_inst_w4.u64 = 0;\n@@ -1863,7 +1864,7 @@ static __rte_always_inline int\n cpt_fc_enc_hmac_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens,\n \t\t struct roc_se_fc_params *fc_params, struct cpt_inst_s *inst)\n {\n-\tstruct roc_se_ctx *ctx = fc_params->ctx_buf.vaddr;\n+\tstruct roc_se_ctx *ctx = fc_params->ctx;\n \tuint8_t fc_type;\n \tint ret = -1;\n \n@@ -2408,7 +2409,7 @@ fill_fc_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\tflags |= ROC_SE_VALID_IV_BUF;\n \t\tfc_params.iv_buf = rte_crypto_op_ctod_offset(cop, uint8_t *,\n \t\t\t\t\t\t\t sess->iv_offset);\n-\t\tif (sess->aes_ctr && unlikely(sess->iv_length != 16)) {\n+\t\tif (!is_aead && sess->aes_ctr && unlikely(sess->iv_length != 16)) {\n \t\t\tmemcpy((uint8_t *)iv_buf,\n \t\t\t rte_crypto_op_ctod_offset(cop, uint8_t *,\n \t\t\t\t\t\t\t sess->iv_offset),\n@@ -2523,7 +2524,7 @@ fill_fc_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\t\t}\n \t\t}\n \t}\n-\tfc_params.ctx_buf.vaddr = &sess->roc_se_ctx;\n+\tfc_params.ctx = &sess->roc_se_ctx;\n \n \tif (!(sess->auth_first) && unlikely(sess->is_null || sess->cpt_op == ROC_SE_OP_DECODE))\n \t\tinplace = 0;\n@@ -2651,7 +2652,7 @@ fill_pdcp_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \td_offs = (uint64_t)c_data_off << 16;\n \td_lens = (uint64_t)c_data_len << 32;\n \n-\tfc_params.ctx_buf.vaddr = &sess->roc_se_ctx;\n+\tfc_params.ctx = &sess->roc_se_ctx;\n \n \tif (likely(m_dst == NULL || m_src == m_dst)) {\n \t\tfc_params.dst_iov = fc_params.src_iov = (void *)src;\n@@ -2794,7 +2795,7 @@ fill_pdcp_chain_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\t\t\t\tci_data_length, true);\n \t}\n \n-\tfc_params.ctx_buf.vaddr = &sess->roc_se_ctx;\n+\tfc_params.ctx = &sess->roc_se_ctx;\n \n \tif (likely((m_dst == NULL || m_dst == m_src)) && inplace) {\n \t\tfc_params.dst_iov = fc_params.src_iov = (void *)src;\n@@ -2993,7 +2994,7 @@ fill_digest_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \n \td_lens = sym_op->auth.data.length;\n \n-\tparams.ctx_buf.vaddr = &sess->roc_se_ctx;\n+\tparams.ctx = &sess->roc_se_ctx;\n \n \tif (auth_op == ROC_SE_OP_AUTH_GENERATE) {\n \t\tif (sym_op->auth.digest.data) {\n", "prefixes": [ "15/18" ] }