Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114697/?format=api
{ "id": 114697, "url": "http://patches.dpdk.org/api/patches/114697/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220808080606.220-8-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220808080606.220-8-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220808080606.220-8-anoobj@marvell.com", "date": "2022-08-08T08:05:55", "name": "[07/18] crypto/cnxk: remove MAC len check for AEAD", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "370bc3848982920ab37110529864790ed895af74", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220808080606.220-8-anoobj@marvell.com/mbox/", "series": [ { "id": 24219, "url": "http://patches.dpdk.org/api/series/24219/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24219", "date": "2022-08-08T08:05:48", "name": "Fixes and improvements in cnxk crypto PMDs", "version": 1, "mbox": "http://patches.dpdk.org/series/24219/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/114697/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/114697/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D471A034C;\n\tMon, 8 Aug 2022 10:07:04 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0291942C45;\n\tMon, 8 Aug 2022 10:06:29 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 392D942C29\n for <dev@dpdk.org>; Mon, 8 Aug 2022 10:06:27 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 277LTX4g015930\n for <dev@dpdk.org>; Mon, 8 Aug 2022 01:06:26 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3hsnnqnf7e-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 08 Aug 2022 01:06:26 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 8 Aug 2022 01:06:24 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 8 Aug 2022 01:06:24 -0700", "from BG-LT92004.corp.innovium.com (unknown [10.28.160.62])\n by maili.marvell.com (Postfix) with ESMTP id E24D43F7051;\n Mon, 8 Aug 2022 01:06:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=2IejpeZY/nkwaNuPwnjsg58FbpV/xxhag3Aym+WoklQ=;\n b=NqVONjcYDkWDSebmNK3rK0k3kO21hpcKHlLpynANlWULvvPX/B+9p1qj4b2FItAbdxwh\n 5vwizUQN6Q76ctncIoh0/qG0cHUHQV8SriyxEycY3EX3KWdN0I+vpveVyVtlQP7A26gA\n 3sGbKmzr0YJjkpTnIcu44tpHKoTPfA+MTvu6Q3klZ9xOXDPWPtKy323+KvTPgZ73ETPH\n jI5RZt2N4NGa2TmfDwVGRmB6VpS9gF8YgHyxFAFP5QvJM1WZhmtdGiEEyhVhdGdAq65J\n R7u3F8AjbK/z+4Azbvkdtr7RZxwxoKJeXL65U0QrijlV9GHBFQjKLtgpxxlRLzR5SvBy oA==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Jerin Jacob <jerinj@marvell.com>", "CC": "Archana Muniganti <marchana@marvell.com>, Tejasree Kondoj\n <ktejasree@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 07/18] crypto/cnxk: remove MAC len check for AEAD", "Date": "Mon, 8 Aug 2022 13:35:55 +0530", "Message-ID": "<20220808080606.220-8-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220808080606.220-1-anoobj@marvell.com>", "References": "<20220808080606.220-1-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "AWqPsCUrFXXu864xWNA3MCMUu6ulHR0j", "X-Proofpoint-GUID": "AWqPsCUrFXXu864xWNA3MCMUu6ulHR0j", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1\n definitions=2022-08-08_05,2022-08-05_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For both AES-GCM and ChaChaPoly, digest size must be non-zero. So remove\nthe conditional handling in the datapath.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/crypto/cnxk/cnxk_se.h | 26 +++++++++++++-------------\n 1 file changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h\nindex 35d074ea34..2c44dba9a0 100644\n--- a/drivers/crypto/cnxk/cnxk_se.h\n+++ b/drivers/crypto/cnxk/cnxk_se.h\n@@ -2453,6 +2453,7 @@ fill_fc_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \tm_dst = sym_op->m_dst;\n \n \tif (sess->aes_gcm || sess->chacha_poly) {\n+\t\tstruct rte_mbuf *m;\n \t\tuint8_t *salt;\n \t\tuint8_t *aad_data;\n \t\tuint16_t aad_len;\n@@ -2483,20 +2484,19 @@ fill_fc_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\t\tcpt_fc_salt_update(&sess->roc_se_ctx, salt);\n \t\t\tsess->salt = *(uint32_t *)salt;\n \t\t}\n-\t\tfc_params.iv_buf = salt + 4;\n-\t\tif (likely(sess->mac_len)) {\n-\t\t\tstruct rte_mbuf *m = cpt_m_dst_get(cpt_op, m_src, m_dst);\n \n-\t\t\t/* hmac immediately following data is best case */\n-\t\t\tif (unlikely(rte_pktmbuf_mtod(m, uint8_t *) +\n-\t\t\t\t\t mc_hash_off !=\n-\t\t\t\t (uint8_t *)sym_op->aead.digest.data)) {\n-\t\t\t\tflags |= ROC_SE_VALID_MAC_BUF;\n-\t\t\t\tfc_params.mac_buf.size = sess->mac_len;\n-\t\t\t\tfc_params.mac_buf.vaddr =\n-\t\t\t\t\tsym_op->aead.digest.data;\n-\t\t\t\tinplace = 0;\n-\t\t\t}\n+\t\tfc_params.iv_buf = PLT_PTR_ADD(salt, 4);\n+\t\tfc_params.mac_buf.size = 0;\n+\t\tfc_params.mac_buf.vaddr = NULL;\n+\t\tm = cpt_m_dst_get(cpt_op, m_src, m_dst);\n+\n+\t\t/* Digest immediately following data is best case */\n+\t\tif (unlikely(rte_pktmbuf_mtod(m, uint8_t *) + mc_hash_off !=\n+\t\t\t (uint8_t *)sym_op->aead.digest.data)) {\n+\t\t\tflags |= ROC_SE_VALID_MAC_BUF;\n+\t\t\tfc_params.mac_buf.size = sess->mac_len;\n+\t\t\tfc_params.mac_buf.vaddr = sym_op->aead.digest.data;\n+\t\t\tinplace = 0;\n \t\t}\n \t} else {\n \t\tuint32_t ci_data_length = sym_op->cipher.data.length;\n", "prefixes": [ "07/18" ] }