Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114575/?format=api
{ "id": 114575, "url": "http://patches.dpdk.org/api/patches/114575/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220803113104.1184059-10-junfeng.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220803113104.1184059-10-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220803113104.1184059-10-junfeng.guo@intel.com", "date": "2022-08-03T11:31:00", "name": "[09/13] net/idpf: add support for RSS", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "34a56c25c873402a276c92acd15e6953aca8957a", "submitter": { "id": 1785, "url": "http://patches.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220803113104.1184059-10-junfeng.guo@intel.com/mbox/", "series": [ { "id": 24188, "url": "http://patches.dpdk.org/api/series/24188/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24188", "date": "2022-08-03T11:30:51", "name": "add support for idpf PMD in DPDK", "version": 1, "mbox": "http://patches.dpdk.org/series/24188/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/114575/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/114575/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E0FBFA00C5;\n\tWed, 3 Aug 2022 13:32:31 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7879D42BC2;\n\tWed, 3 Aug 2022 13:31:38 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 59FA540A7E\n for <dev@dpdk.org>; Wed, 3 Aug 2022 13:31:35 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Aug 2022 04:31:35 -0700", "from dpdk-jf-ntb-v2.sh.intel.com ([10.67.118.246])\n by FMSMGA003.fm.intel.com with ESMTP; 03 Aug 2022 04:31:33 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1659526295; x=1691062295;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=WWv2nt2i1EeahD+FSueuKuDn+ldi/9eCgse7akJ8QeI=;\n b=ni2uwEa33DxlFE5KmEomx25Z38Hy7KDVAROp893+TD8ctjv+d4SpgYNs\n UK5U2sorQ6iAdMoWzQPs2/5Ke/VwzUM4Gc8Mlp7DAXzMJ4XtjWwpVCi3e\n liCEjCOsZSz6ltwf4X8WLQQdUo+eYdOkyymkF8vWTaMehFV0Ct03YqpiU\n G52IchOf/zF8vrIDy8Zv3el3syc2j5SCBIYme09sC/dTlOn9gHwr4fplg\n mmgmY1Nh55y7uQDMteOYTjMkafxo3vfD1SEwy62CQzlVud4j14kYuXEi3\n JGCkbdaK3Hqp/RcFoIg8kmWjbdAVdCM4uMxxISbRg66SL9FooP9hn9KsP A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10427\"; a=\"375948531\"", "E=Sophos;i=\"5.93,214,1654585200\"; d=\"scan'208\";a=\"375948531\"", "E=Sophos;i=\"5.93,214,1654585200\"; d=\"scan'208\";a=\"692211100\"" ], "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "qi.z.zhang@intel.com,\n\tjingjing.wu@intel.com,\n\tbeilei.xing@intel.com", "Cc": "dev@dpdk.org,\n\tjunfeng.guo@intel.com", "Subject": "[PATCH 09/13] net/idpf: add support for RSS", "Date": "Wed, 3 Aug 2022 19:31:00 +0800", "Message-Id": "<20220803113104.1184059-10-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220803113104.1184059-1-junfeng.guo@intel.com>", "References": "<20220803113104.1184059-1-junfeng.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add RSS support.\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\n---\n drivers/net/idpf/idpf_ethdev.c | 108 +++++++++++++++++++++++++++++++++\n drivers/net/idpf/idpf_ethdev.h | 18 ++++++\n drivers/net/idpf/idpf_vchnl.c | 93 ++++++++++++++++++++++++++++\n 3 files changed, 219 insertions(+)", "diff": "diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c\nindex 55ec24872e..0b03ec860a 100644\n--- a/drivers/net/idpf/idpf_ethdev.c\n+++ b/drivers/net/idpf/idpf_ethdev.c\n@@ -85,6 +85,7 @@ idpf_dev_info_get(__rte_unused struct rte_eth_dev *dev, struct rte_eth_dev_info\n \tdev_info->max_mtu = dev_info->max_rx_pktlen - IDPF_ETH_OVERHEAD;\n \tdev_info->min_mtu = RTE_ETHER_MIN_MTU;\n \n+\tdev_info->flow_type_rss_offloads = IDPF_RSS_OFFLOAD_ALL;\n \tdev_info->max_mac_addrs = IDPF_NUM_MACADDR_MAX;\n \tdev_info->dev_capa = RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |\n \t\tRTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;\n@@ -293,6 +294,91 @@ idpf_init_vport(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+static int\n+idpf_config_rss(struct idpf_vport *vport)\n+{\n+\tint ret;\n+\n+\tret = idpf_set_rss_key(vport);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to configure RSS key\");\n+\t\treturn ret;\n+\t}\n+\n+\tret = idpf_set_rss_lut(vport);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to configure RSS lut\");\n+\t\treturn ret;\n+\t}\n+\n+\tret = idpf_set_rss_hash(vport);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to configure RSS hash\");\n+\t\treturn ret;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int\n+idpf_init_rss(struct idpf_vport *vport)\n+{\n+\tstruct rte_eth_rss_conf *rss_conf;\n+\tuint16_t i, nb_q, lut_size;\n+\tint ret = 0;\n+\n+\trss_conf = &vport->dev_data->dev_conf.rx_adv_conf.rss_conf;\n+\tnb_q = vport->num_rx_q;\n+\n+\tvport->rss_key = (uint8_t *)rte_zmalloc(\"rss_key\",\n+\t\t\t\t\t vport->rss_key_size, 0);\n+\tif (!vport->rss_key) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to allocate RSS key\");\n+\t\tret = -ENOMEM;\n+\t\tgoto err_key;\n+\t}\n+\n+\tlut_size = vport->rss_lut_size;\n+\tvport->rss_lut = (uint32_t *)rte_zmalloc(\"rss_lut\",\n+\t\t\t\t\t sizeof(uint32_t) * lut_size, 0);\n+\tif (!vport->rss_lut) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to allocate RSS lut\");\n+\t\tret = -ENOMEM;\n+\t\tgoto err_lut;\n+\t}\n+\n+\tif (!rss_conf->rss_key) {\n+\t\tfor (i = 0; i < vport->rss_key_size; i++)\n+\t\t\tvport->rss_key[i] = (uint8_t)rte_rand();\n+\t} else {\n+\t\trte_memcpy(vport->rss_key, rss_conf->rss_key,\n+\t\t\t RTE_MIN(rss_conf->rss_key_len,\n+\t\t\t\t vport->rss_key_size));\n+\t}\n+\n+\tfor (i = 0; i < lut_size; i++)\n+\t\tvport->rss_lut[i] = i % nb_q;\n+\n+\tvport->rss_hf = IECM_DEFAULT_RSS_HASH_EXPANDED;\n+\n+\tret = idpf_config_rss(vport);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to configure RSS\");\n+\t\tgoto err_cfg;\n+\t}\n+\n+\treturn ret;\n+\n+err_cfg:\n+\trte_free(vport->rss_lut);\n+\tvport->rss_lut = NULL;\n+err_lut:\n+\trte_free(vport->rss_key);\n+\tvport->rss_key = NULL;\n+err_key:\n+\treturn ret;\n+}\n+\n static int\n idpf_dev_configure(struct rte_eth_dev *dev)\n {\n@@ -300,6 +386,10 @@ idpf_dev_configure(struct rte_eth_dev *dev)\n \t\t(struct idpf_vport *)dev->data->dev_private;\n \tint ret = 0;\n \n+\tif (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG)\n+\t\tdev->data->dev_conf.rxmode.offloads |=\n+\t\t\tRTE_ETH_RX_OFFLOAD_RSS_HASH;\n+\n \tret = idpf_init_vport_req_info(dev);\n \tif (ret) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to init vport req_info.\");\n@@ -321,6 +411,14 @@ idpf_dev_configure(struct rte_eth_dev *dev)\n \trte_ether_addr_copy((struct rte_ether_addr *)vport->default_mac_addr,\n \t\t\t &dev->data->mac_addrs[0]);\n \n+\tif (adapter->caps->rss_caps) {\n+\t\tret = idpf_init_rss(vport);\n+\t\tif (ret) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Failed to init rss\");\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n \treturn ret;\n }\n \n@@ -422,6 +520,16 @@ idpf_dev_close(struct rte_eth_dev *dev)\n \tidpf_dev_stop(dev);\n \tidpf_destroy_vport(vport);\n \n+\tif (vport->rss_lut) {\n+\t\trte_free(vport->rss_lut);\n+\t\tvport->rss_lut = NULL;\n+\t}\n+\n+\tif (vport->rss_key) {\n+\t\trte_free(vport->rss_key);\n+\t\tvport->rss_key = NULL;\n+\t}\n+\n \treturn 0;\n }\n \ndiff --git a/drivers/net/idpf/idpf_ethdev.h b/drivers/net/idpf/idpf_ethdev.h\nindex 130bb7ad2d..22096c4185 100644\n--- a/drivers/net/idpf/idpf_ethdev.h\n+++ b/drivers/net/idpf/idpf_ethdev.h\n@@ -47,6 +47,20 @@\n #define IDPF_ETH_OVERHEAD \\\n \t(RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + IDPF_VLAN_TAG_SIZE * 2)\n \n+#define IDPF_RSS_OFFLOAD_ALL ( \\\n+\tRTE_ETH_RSS_IPV4\t\t| \\\n+\tRTE_ETH_RSS_FRAG_IPV4\t\t| \\\n+\tRTE_ETH_RSS_NONFRAG_IPV4_TCP\t| \\\n+\tRTE_ETH_RSS_NONFRAG_IPV4_UDP\t| \\\n+\tRTE_ETH_RSS_NONFRAG_IPV4_SCTP\t| \\\n+\tRTE_ETH_RSS_NONFRAG_IPV4_OTHER\t| \\\n+\tRTE_ETH_RSS_IPV6\t\t| \\\n+\tRTE_ETH_RSS_FRAG_IPV6\t\t| \\\n+\tRTE_ETH_RSS_NONFRAG_IPV6_TCP\t| \\\n+\tRTE_ETH_RSS_NONFRAG_IPV6_UDP\t| \\\n+\tRTE_ETH_RSS_NONFRAG_IPV6_SCTP\t| \\\n+\tRTE_ETH_RSS_NONFRAG_IPV6_OTHER)\n+\n #ifndef ETH_ADDR_LEN\n #define ETH_ADDR_LEN\t\t6\n #endif\n@@ -202,6 +216,9 @@ int idpf_check_api_version(struct idpf_adapter *adapter);\n int idpf_get_caps(struct idpf_adapter *adapter);\n int idpf_create_vport(__rte_unused struct rte_eth_dev *dev);\n int idpf_destroy_vport(struct idpf_vport *vport);\n+int idpf_set_rss_key(struct idpf_vport *vport);\n+int idpf_set_rss_lut(struct idpf_vport *vport);\n+int idpf_set_rss_hash(struct idpf_vport *vport);\n int idpf_config_rxqs(struct idpf_vport *vport);\n int idpf_config_rxq(struct idpf_vport *vport, uint16_t rxq_id);\n int idpf_config_txqs(struct idpf_vport *vport);\n@@ -212,3 +229,4 @@ int idpf_ena_dis_queues(struct idpf_vport *vport, bool enable);\n int idpf_ena_dis_vport(struct idpf_vport *vport, bool enable);\n \n #endif /* _IDPF_ETHDEV_H_ */\n+\ndiff --git a/drivers/net/idpf/idpf_vchnl.c b/drivers/net/idpf/idpf_vchnl.c\nindex d78903d983..07b220016f 100644\n--- a/drivers/net/idpf/idpf_vchnl.c\n+++ b/drivers/net/idpf/idpf_vchnl.c\n@@ -451,6 +451,99 @@ idpf_destroy_vport(struct idpf_vport *vport)\n \treturn err;\n }\n \n+int\n+idpf_set_rss_key(struct idpf_vport *vport)\n+{\n+\tstruct virtchnl2_rss_key *rss_key;\n+\tstruct idpf_cmd_info args;\n+\tint len, err;\n+\n+\tlen = sizeof(*rss_key) + sizeof(rss_key->key[0]) *\n+\t\t(vport->rss_key_size - 1);\n+\trss_key = rte_zmalloc(\"rss_key\", len, 0);\n+\tif (!rss_key)\n+\t\treturn -ENOMEM;\n+\n+\trss_key->vport_id = vport->vport_id;\n+\trss_key->key_len = vport->rss_key_size;\n+\trte_memcpy(rss_key->key, vport->rss_key,\n+\t\t sizeof(rss_key->key[0]) * vport->rss_key_size);\n+\n+\tmemset(&args, 0, sizeof(args));\n+\targs.ops = VIRTCHNL2_OP_SET_RSS_KEY;\n+\targs.in_args = (uint8_t *)rss_key;\n+\targs.in_args_size = len;\n+\targs.out_buffer = adapter->mbx_resp;\n+\targs.out_size = IDPF_DFLT_MBX_BUF_SIZE;\n+\n+\terr = idpf_execute_vc_cmd(adapter, &args);\n+\tif (err) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to execute command of VIRTCHNL2_OP_SET_RSS_KEY\");\n+\t\treturn err;\n+\t}\n+\n+\trte_free(rss_key);\n+\treturn err;\n+}\n+\n+int\n+idpf_set_rss_lut(struct idpf_vport *vport)\n+{\n+\tstruct virtchnl2_rss_lut *rss_lut;\n+\tstruct idpf_cmd_info args;\n+\tint len, err;\n+\n+\tlen = sizeof(*rss_lut) + sizeof(rss_lut->lut[0]) *\n+\t\t(vport->rss_lut_size - 1);\n+\trss_lut = rte_zmalloc(\"rss_lut\", len, 0);\n+\tif (!rss_lut)\n+\t\treturn -ENOMEM;\n+\n+\trss_lut->vport_id = vport->vport_id;\n+\trss_lut->lut_entries = vport->rss_lut_size;\n+\trte_memcpy(rss_lut->lut, vport->rss_lut,\n+\t\t sizeof(rss_lut->lut[0]) * vport->rss_lut_size);\n+\n+\tmemset(&args, 0, sizeof(args));\n+\targs.ops = VIRTCHNL2_OP_SET_RSS_LUT;\n+\targs.in_args = (uint8_t *)rss_lut;\n+\targs.in_args_size = len;\n+\targs.out_buffer = adapter->mbx_resp;\n+\targs.out_size = IDPF_DFLT_MBX_BUF_SIZE;\n+\n+\terr = idpf_execute_vc_cmd(adapter, &args);\n+\tif (err)\n+\t\tPMD_DRV_LOG(ERR, \"Failed to execute command of VIRTCHNL2_OP_SET_RSS_LUT\");\n+\n+\trte_free(rss_lut);\n+\treturn err;\n+}\n+\n+int\n+idpf_set_rss_hash(struct idpf_vport *vport)\n+{\n+\tstruct virtchnl2_rss_hash rss_hash;\n+\tstruct idpf_cmd_info args;\n+\tint err;\n+\n+\tmemset(&rss_hash, 0, sizeof(rss_hash));\n+\trss_hash.ptype_groups = vport->rss_hf;\n+\trss_hash.vport_id = vport->vport_id;\n+\n+\tmemset(&args, 0, sizeof(args));\n+\targs.ops = VIRTCHNL2_OP_SET_RSS_HASH;\n+\targs.in_args = (uint8_t *)&rss_hash;\n+\targs.in_args_size = sizeof(rss_hash);\n+\targs.out_buffer = adapter->mbx_resp;\n+\targs.out_size = IDPF_DFLT_MBX_BUF_SIZE;\n+\n+\terr = idpf_execute_vc_cmd(adapter, &args);\n+\tif (err)\n+\t\tPMD_DRV_LOG(ERR, \"Failed to execute command of OP_SET_RSS_HASH\");\n+\n+\treturn err;\n+}\n+\n #define IDPF_RX_BUF_STRIDE\t\t64\n int\n idpf_config_rxqs(struct idpf_vport *vport)\n", "prefixes": [ "09/13" ] }