Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114464/?format=api
{ "id": 114464, "url": "http://patches.dpdk.org/api/patches/114464/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220731201738.11733-2-cfontana@suse.de/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220731201738.11733-2-cfontana@suse.de>", "list_archive_url": "https://inbox.dpdk.org/dev/20220731201738.11733-2-cfontana@suse.de", "date": "2022-07-31T20:17:37", "name": "[1/2] vhost: fix error handling in virtio_dev_tx_split", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e3c9cc00495bee478e4834f27eb2695c1bb24e69", "submitter": { "id": 2788, "url": "http://patches.dpdk.org/api/people/2788/?format=api", "name": "Claudio Fontana", "email": "cfontana@suse.de" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220731201738.11733-2-cfontana@suse.de/mbox/", "series": [ { "id": 24140, "url": "http://patches.dpdk.org/api/series/24140/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24140", "date": "2022-07-31T20:17:36", "name": "vhost fixes for OVS SIGSEGV in PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/24140/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/114464/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/114464/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 485F7A00C3;\n\tSun, 31 Jul 2022 22:17:50 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DF22D42C61;\n\tSun, 31 Jul 2022 22:17:44 +0200 (CEST)", "from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])\n by mails.dpdk.org (Postfix) with ESMTP id 8FA2F4067B\n for <dev@dpdk.org>; Sun, 31 Jul 2022 22:17:42 +0200 (CEST)", "from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de\n [192.168.254.74])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 68D6D3EFCB;\n Sun, 31 Jul 2022 20:17:42 +0000 (UTC)", "from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de\n [192.168.254.74])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)\n (No client certificate requested)\n by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 49B8713754;\n Sun, 31 Jul 2022 20:17:42 +0000 (UTC)", "from dovecot-director2.suse.de ([192.168.254.65])\n by imap2.suse-dmz.suse.de with ESMTPSA id uL0pEGbj5mIXVgAAMHmgww\n (envelope-from <cfontana@suse.de>); Sun, 31 Jul 2022 20:17:42 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1659298662;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nZvhrahxoTiiT/3220MYPVzUOUFS0xSRx2KdpepO0ko=;\n b=G5dqURJaHDTzWr+BLWpDhiYHRKqK45r4nOc35V3XqiHAPqDix46qPI1b2xXIYsWebFvzID\n thV6h7E1Il7TSD1URe3oIJ0T+qgqgwjBjoKHrdounNRXmueqKPH1M9ChgDzUoReybtcGhJ\n OB9KYw9CRiXDVFkjGKPtmMlTwX4GbEY=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1659298662;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nZvhrahxoTiiT/3220MYPVzUOUFS0xSRx2KdpepO0ko=;\n b=SN2iQVFVUtAO1E7DrN9ROdWKdmfetBZdBg1/4BBw2kee/AalrDiD21uIepaRDICLpWtfgv\n wTYQjdqBCOckpGBA==" ], "From": "Claudio Fontana <cfontana@suse.de>", "To": "dev@dpdk.org", "Cc": "Claudio Fontana <cfontana@suse.de>", "Subject": "[PATCH 1/2] vhost: fix error handling in virtio_dev_tx_split", "Date": "Sun, 31 Jul 2022 22:17:37 +0200", "Message-Id": "<20220731201738.11733-2-cfontana@suse.de>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20220731201738.11733-1-cfontana@suse.de>", "References": "<20220731201738.11733-1-cfontana@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "in virtio_dev_split we add a check for invalid nr_vec,\nmainly for nr_vec == 0 (but add a check for BUF_VECTOR_MAX too),\nand bail out before calling desc_to_mbuf, otherwise in desc_to_mbuf\nwe end up trying to memcpy from a source address buf_vec[0] that\nis an uninitialized stack variable.\n\nThis should fix errors that have been reported in multiple occasions\nfrom telcos to the DPDK, OVS and QEMU projects, as this affects in\nparticular the openvswitch/DPDK, QEMU vhost-user setup.\n\nThe back trace looks roughly like this, depending on the specific\nrte_memcpy selected, etc, in any case the \"src\" parameter is garbage\n(in this example containing 0 + dev->host_hlen(12 = 0xc)).\n\nThread 153 \"pmd-c88/id:150\" received signal SIGSEGV, Segmentation fault.\n[Switching to Thread 0x7f64e5e6b700 (LWP 141373)]\nrte_mov128blocks (n=2048, src=0xc <error: Cannot access memory at address 0xc>,\n dst=0x150da4480) at ../lib/eal/x86/include/rte_memcpy.h:384\n(gdb) bt\n0 rte_mov128blocks (n=2048, src=0xc, dst=0x150da4480)\n1 rte_memcpy_generic (n=2048, src=0xc, dst=0x150da4480)\n2 rte_memcpy (n=2048, src=0xc, dst=<optimized out>)\n3 sync_fill_seg\n4 desc_to_mbuf\n5 virtio_dev_tx_split\n6 virtio_dev_tx_split_legacy\n7 0x00007f676fea0fef in rte_vhost_dequeue_burst\n8 0x00007f6772005a62 in netdev_dpdk_vhost_rxq_recv\n9 0x00007f6771f38116 in netdev_rxq_recv\n10 0x00007f6771f03d96 in dp_netdev_process_rxq_port\n11 0x00007f6771f04239 in pmd_thread_main\n12 0x00007f6771f92aff in ovsthread_wrapper\n13 0x00007f6771c1b6ea in start_thread\n14 0x00007f6771933a8f in clone\n\nTested-by: Claudio Fontana <cfontana@suse.de>\nSigned-off-by: Claudio Fontana <cfontana@suse.de>\n---\n lib/vhost/virtio_net.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c\nindex 35fa4670fd..0b8db2046e 100644\n--- a/lib/vhost/virtio_net.c\n+++ b/lib/vhost/virtio_net.c\n@@ -2917,9 +2917,16 @@ virtio_dev_tx_split(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t\t\t\t\tvq->last_avail_idx + i,\n \t\t\t\t\t\t&nr_vec, buf_vec,\n \t\t\t\t\t\t&head_idx, &buf_len,\n-\t\t\t\t\t\tVHOST_ACCESS_RO) < 0))\n+\t\t\t\t\t\tVHOST_ACCESS_RO) < 0)) {\n+\t\t\tdropped += 1;\n+\t\t\ti++;\n \t\t\tbreak;\n-\n+\t\t}\n+\t\tif (unlikely(nr_vec < 1 || nr_vec >= BUF_VECTOR_MAX)) {\n+\t\t\tdropped += 1;\n+\t\t\ti++;\n+\t\t\tbreak;\n+\t\t}\n \t\tupdate_shadow_used_ring_split(vq, head_idx, 0);\n \n \t\terr = virtio_dev_pktmbuf_prep(dev, pkts[i], buf_len);\n", "prefixes": [ "1/2" ] }