Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114461/?format=api
{ "id": 114461, "url": "http://patches.dpdk.org/api/patches/114461/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/004c86e8ddf05bb9d3df77580357c4eca852c013.1659177063.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<004c86e8ddf05bb9d3df77580357c4eca852c013.1659177063.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/004c86e8ddf05bb9d3df77580357c4eca852c013.1659177063.git.wangyunjian@huawei.com", "date": "2022-07-30T10:40:22", "name": "[1/1] net/mlx5: fix memory leak when releasing a drop action", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ad6275c5709e7188c2663301794699c53c60e59d", "submitter": { "id": 551, "url": "http://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/004c86e8ddf05bb9d3df77580357c4eca852c013.1659177063.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 24138, "url": "http://patches.dpdk.org/api/series/24138/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24138", "date": "2022-07-30T10:40:22", "name": "[1/1] net/mlx5: fix memory leak when releasing a drop action", "version": 1, "mbox": "http://patches.dpdk.org/series/24138/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/114461/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/114461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 199EEA0542;\n\tSat, 30 Jul 2022 12:41:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B4F7D4021E;\n\tSat, 30 Jul 2022 12:41:15 +0200 (CEST)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id C7E0D4014F;\n Sat, 30 Jul 2022 12:41:13 +0200 (CEST)", "from dggpemm500021.china.huawei.com (unknown [172.30.72.55])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Lw19T3dWLz9srK;\n Sat, 30 Jul 2022 18:39:57 +0800 (CST)", "from dggpemm500008.china.huawei.com (7.185.36.136) by\n dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Sat, 30 Jul 2022 18:41:10 +0800", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul\n 2022 18:41:10 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<matan@nvidia.com>, <viacheslavo@nvidia.com>, <dkozlyuk@nvidia.com>,\n <huangshaozhang@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,\n <stable@dpdk.org>", "Subject": "[dpdk-dev] [PATCH 1/1] net/mlx5: fix memory leak when releasing a\n drop action", "Date": "Sat, 30 Jul 2022 18:40:22 +0800", "Message-ID": "\n <004c86e8ddf05bb9d3df77580357c4eca852c013.1659177063.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the memory for hrxq->action is allocated in mlx5_devx_hrxq_new().\nBut it was not being freed when the drop action was released in\nmlx5_devx_drop_action_destroy(). These cause a memory leak.\n\nFixes: bc5bee028ebc (\"net/mlx5: create drop queue using DevX\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/mlx5/mlx5_devx.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c\nindex 6886ae1f22..171ce5c08a 100644\n--- a/drivers/net/mlx5/mlx5_devx.c\n+++ b/drivers/net/mlx5/mlx5_devx.c\n@@ -1097,6 +1097,12 @@ mlx5_devx_drop_action_destroy(struct rte_eth_dev *dev)\n \t\tmlx5_devx_ind_table_destroy(hrxq->ind_table);\n \tif (priv->drop_queue.rxq->devx_rq.rq != NULL)\n \t\tmlx5_rxq_devx_obj_drop_release(dev);\n+#ifdef HAVE_IBV_FLOW_DV_SUPPORT\n+\tif (hrxq->action != NULL) {\n+\t\tmlx5_glue->destroy_flow_action(hrxq->action);\n+\t\thrxq->action = NULL;\n+\t}\n+#endif\n }\n \n /**\n", "prefixes": [ "1/1" ] }