Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114390/?format=api
{ "id": 114390, "url": "http://patches.dpdk.org/api/patches/114390/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220728152640.547725-20-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220728152640.547725-20-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220728152640.547725-20-david.marchand@redhat.com", "date": "2022-07-28T15:26:33", "name": "[RFC,v3,19/26] bus: move IOVA definition from header", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "68b890125f32281a62fc0b5f46215c29a776dfef", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220728152640.547725-20-david.marchand@redhat.com/mbox/", "series": [ { "id": 24118, "url": "http://patches.dpdk.org/api/series/24118/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24118", "date": "2022-07-28T15:26:14", "name": "Bus and device cleanup for 22.11", "version": 3, "mbox": "http://patches.dpdk.org/series/24118/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/114390/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/114390/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 15601A00C5;\n\tThu, 28 Jul 2022 17:28:53 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7906842BE8;\n\tThu, 28 Jul 2022 17:28:20 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 74D4F42BE8\n for <dev@dpdk.org>; Thu, 28 Jul 2022 17:28:18 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-576-jZp0NN72M82MZgb743kE7g-1; Thu, 28 Jul 2022 11:28:15 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF97B3C10148;\n Thu, 28 Jul 2022 15:28:14 +0000 (UTC)", "from fchome.redhat.com (unknown [10.40.195.18])\n by smtp.corp.redhat.com (Postfix) with ESMTP id AB04A1415118;\n Thu, 28 Jul 2022 15:28:11 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1659022098;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=AcCS9ibySgB3CqkaVg2ayeUsnN9978kBRkFz32OlQNg=;\n b=Kk7ofbW2ONL6tbECHHNQ1ZeZWJWDrYF6caRr40UcPQU0UBgyZptsarDwrgzxb3hvegqjgG\n yPdLb3oXfPq3UIUxhoGZryrryWAFM7p8omA71rFyDHzqKU7lRCACYuI85YApoo427vtuYp\n I/1F/vvv52c9mub0jlsLtD2wSF4k7Dw=", "X-MC-Unique": "jZp0NN72M82MZgb743kE7g-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>, Sunila Sahu <ssahu@marvell.com>,\n Fan Zhang <roy.fan.zhang@intel.com>,\n Ashish Gupta <ashish.gupta@marvell.com>, Gaetan Rivet <grive@u256.net>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Akhil Goyal <gakhil@marvell.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@xilinx.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[RFC v3 19/26] bus: move IOVA definition from header", "Date": "Thu, 28 Jul 2022 17:26:33 +0200", "Message-Id": "<20220728152640.547725-20-david.marchand@redhat.com>", "In-Reply-To": "<20220728152640.547725-1-david.marchand@redhat.com>", "References": "<20220628144643.1213026-1-david.marchand@redhat.com>\n <20220728152640.547725-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.7", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "iova enum definition does not need to be defined as part of the bus API.\nMove it to rte_eal.h.\nWith this step, rte_eal.h does not depend on rte_bus.h and rte_dev.h.\nFix existing code that was relying on these implicit inclusions.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/test-compress-perf/comp_perf_options.h | 2 ++\n app/test-pmd/config.c | 1 +\n app/test-pmd/testpmd.c | 1 +\n drivers/compress/zlib/zlib_pmd_ops.c | 1 +\n drivers/net/failsafe/failsafe_eal.c | 1 +\n examples/multi_process/hotplug_mp/commands.c | 2 ++\n lib/compressdev/rte_compressdev.c | 1 +\n lib/compressdev/rte_compressdev_pmd.c | 1 +\n lib/cryptodev/cryptodev_pmd.c | 2 ++\n lib/eal/common/eal_thread.h | 1 +\n lib/eal/common/hotplug_mp.c | 1 +\n lib/eal/include/rte_bus.h | 18 ++----------------\n lib/eal/include/rte_eal.h | 15 ++++++++++++++-\n lib/eal/include/rte_lcore.h | 2 ++\n lib/eal/windows/eal.c | 1 +\n lib/ethdev/rte_ethdev.c | 1 +\n lib/pcapng/rte_pcapng.c | 1 +\n 17 files changed, 35 insertions(+), 17 deletions(-)", "diff": "diff --git a/app/test-compress-perf/comp_perf_options.h b/app/test-compress-perf/comp_perf_options.h\nindex 0b777521c5..57dd146330 100644\n--- a/app/test-compress-perf/comp_perf_options.h\n+++ b/app/test-compress-perf/comp_perf_options.h\n@@ -5,6 +5,8 @@\n #ifndef _COMP_PERF_OPS_\n #define _COMP_PERF_OPS_\n \n+#include <rte_dev.h>\n+\n #define MAX_LIST\t\t32\n #define MIN_COMPRESSED_BUF_SIZE 8\n #define EXPANSE_RATIO 1.1\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex bc73819183..d988429f24 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -24,6 +24,7 @@\n #include <rte_memcpy.h>\n #include <rte_memzone.h>\n #include <rte_launch.h>\n+#include <rte_bus.h>\n #include <rte_eal.h>\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex ee686393c5..510e0be624 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -32,6 +32,7 @@\n #include <rte_memory.h>\n #include <rte_memcpy.h>\n #include <rte_launch.h>\n+#include <rte_bus.h>\n #include <rte_eal.h>\n #include <rte_alarm.h>\n #include <rte_per_lcore.h>\ndiff --git a/drivers/compress/zlib/zlib_pmd_ops.c b/drivers/compress/zlib/zlib_pmd_ops.c\nindex 0a73aed949..7d657d81bc 100644\n--- a/drivers/compress/zlib/zlib_pmd_ops.c\n+++ b/drivers/compress/zlib/zlib_pmd_ops.c\n@@ -4,6 +4,7 @@\n \n #include <string.h>\n \n+#include <rte_dev.h>\n #include <rte_common.h>\n #include <rte_malloc.h>\n \ndiff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c\nindex cb4a2abc02..130344dce2 100644\n--- a/drivers/net/failsafe/failsafe_eal.c\n+++ b/drivers/net/failsafe/failsafe_eal.c\n@@ -3,6 +3,7 @@\n * Copyright 2017 Mellanox Technologies, Ltd\n */\n \n+#include <rte_bus.h>\n #include <rte_string_fns.h>\n #include <rte_malloc.h>\n \ndiff --git a/examples/multi_process/hotplug_mp/commands.c b/examples/multi_process/hotplug_mp/commands.c\nindex 41ea265e45..da8b5e5924 100644\n--- a/examples/multi_process/hotplug_mp/commands.c\n+++ b/examples/multi_process/hotplug_mp/commands.c\n@@ -8,6 +8,8 @@\n #include <cmdline_parse_num.h>\n #include <cmdline_parse_string.h>\n #include <cmdline.h>\n+\n+#include <rte_bus.h>\n #include <rte_ethdev.h>\n \n /**********************************************************/\ndiff --git a/lib/compressdev/rte_compressdev.c b/lib/compressdev/rte_compressdev.c\nindex 12469042f7..7f6dedbc52 100644\n--- a/lib/compressdev/rte_compressdev.c\n+++ b/lib/compressdev/rte_compressdev.c\n@@ -9,6 +9,7 @@\n #include <rte_common.h>\n #include <rte_string_fns.h>\n #include <rte_malloc.h>\n+#include <rte_dev.h>\n #include <rte_eal.h>\n #include <rte_memzone.h>\n \ndiff --git a/lib/compressdev/rte_compressdev_pmd.c b/lib/compressdev/rte_compressdev_pmd.c\nindex 7f500d76d4..9bfae077db 100644\n--- a/lib/compressdev/rte_compressdev_pmd.c\n+++ b/lib/compressdev/rte_compressdev_pmd.c\n@@ -5,6 +5,7 @@\n #include <rte_string_fns.h>\n #include <rte_malloc.h>\n #include <rte_kvargs.h>\n+#include <rte_dev.h>\n #include <rte_eal.h>\n \n #include \"rte_compressdev_internal.h\"\ndiff --git a/lib/cryptodev/cryptodev_pmd.c b/lib/cryptodev/cryptodev_pmd.c\nindex 1903ade388..75d0075b86 100644\n--- a/lib/cryptodev/cryptodev_pmd.c\n+++ b/lib/cryptodev/cryptodev_pmd.c\n@@ -3,6 +3,8 @@\n */\n \n #include <sys/queue.h>\n+\n+#include <rte_dev.h>\n #include <rte_errno.h>\n #include <rte_string_fns.h>\n #include <rte_malloc.h>\ndiff --git a/lib/eal/common/eal_thread.h b/lib/eal/common/eal_thread.h\nindex ca3378d463..e0240ccc60 100644\n--- a/lib/eal/common/eal_thread.h\n+++ b/lib/eal/common/eal_thread.h\n@@ -5,6 +5,7 @@\n #ifndef EAL_THREAD_H\n #define EAL_THREAD_H\n \n+#include <rte_common.h>\n #include <rte_lcore.h>\n \n /**\ndiff --git a/lib/eal/common/hotplug_mp.c b/lib/eal/common/hotplug_mp.c\nindex bde0de196e..1614a57752 100644\n--- a/lib/eal/common/hotplug_mp.c\n+++ b/lib/eal/common/hotplug_mp.c\n@@ -3,6 +3,7 @@\n */\n #include <string.h>\n \n+#include <rte_bus.h>\n #include <rte_eal.h>\n #include <rte_errno.h>\n #include <rte_alarm.h>\ndiff --git a/lib/eal/include/rte_bus.h b/lib/eal/include/rte_bus.h\nindex bbbb6efd28..17edaa37c9 100644\n--- a/lib/eal/include/rte_bus.h\n+++ b/lib/eal/include/rte_bus.h\n@@ -20,27 +20,13 @@ extern \"C\" {\n \n #include <stdio.h>\n \n-#include <rte_log.h>\n #include <rte_dev.h>\n+#include <rte_eal.h>\n+#include <rte_log.h>\n \n /** Double linked list of buses */\n RTE_TAILQ_HEAD(rte_bus_list, rte_bus);\n \n-\n-/**\n- * IOVA mapping mode.\n- *\n- * IOVA mapping mode is iommu programming mode of a device.\n- * That device (for example: IOMMU backed DMA device) based\n- * on rte_iova_mode will generate physical or virtual address.\n- *\n- */\n-enum rte_iova_mode {\n-\tRTE_IOVA_DC = 0,\t/* Don't care mode */\n-\tRTE_IOVA_PA = (1 << 0), /* DMA using physical address */\n-\tRTE_IOVA_VA = (1 << 1) /* DMA using virtual address */\n-};\n-\n /**\n * Bus specific scan for devices attached on the bus.\n * For each bus object, the scan would be responsible for finding devices and\ndiff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h\nindex 5dfc50e987..fd3d7c1da8 100644\n--- a/lib/eal/include/rte_eal.h\n+++ b/lib/eal/include/rte_eal.h\n@@ -17,7 +17,6 @@\n #include <rte_config.h>\n #include <rte_compat.h>\n #include <rte_per_lcore.h>\n-#include <rte_bus.h>\n #include <rte_uuid.h>\n \n #include <rte_pci_dev_feature_defs.h>\n@@ -458,6 +457,20 @@ static inline int rte_gettid(void)\n __rte_internal\n uint64_t rte_eal_get_baseaddr(void);\n \n+/**\n+ * IOVA mapping mode.\n+ *\n+ * IOVA mapping mode is iommu programming mode of a device.\n+ * That device (for example: IOMMU backed DMA device) based\n+ * on rte_iova_mode will generate physical or virtual address.\n+ *\n+ */\n+enum rte_iova_mode {\n+\tRTE_IOVA_DC = 0,\t/* Don't care mode */\n+\tRTE_IOVA_PA = (1 << 0), /* DMA using physical address */\n+\tRTE_IOVA_VA = (1 << 1) /* DMA using virtual address */\n+};\n+\n /**\n * Get the iova mode\n *\ndiff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/rte_lcore.h\nindex b598e1b9ec..4d3978512c 100644\n--- a/lib/eal/include/rte_lcore.h\n+++ b/lib/eal/include/rte_lcore.h\n@@ -11,6 +11,8 @@\n * API for lcore and socket manipulation\n *\n */\n+#include <stdio.h>\n+\n #include <rte_config.h>\n #include <rte_per_lcore.h>\n #include <rte_eal.h>\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 122de2a319..79322d2ce9 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -10,6 +10,7 @@\n #include <sys/stat.h>\n \n #include <rte_debug.h>\n+#include <rte_bus.h>\n #include <rte_eal.h>\n #include <eal_memcfg.h>\n #include <rte_errno.h>\ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 1979dc0850..ebbe8cca3d 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -11,6 +11,7 @@\n #include <string.h>\n #include <sys/queue.h>\n \n+#include <rte_bus.h>\n #include <rte_log.h>\n #include <rte_interrupts.h>\n #include <rte_memcpy.h>\ndiff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c\nindex 06ad712bd1..5b079cd14a 100644\n--- a/lib/pcapng/rte_pcapng.c\n+++ b/lib/pcapng/rte_pcapng.c\n@@ -11,6 +11,7 @@\n #include <time.h>\n #include <unistd.h>\n \n+#include <rte_bus.h>\n #include <rte_common.h>\n #include <rte_cycles.h>\n #include <rte_dev.h>\n", "prefixes": [ "RFC", "v3", "19/26" ] }