Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114294/?format=api
{ "id": 114294, "url": "http://patches.dpdk.org/api/patches/114294/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220727223639.598932-16-cristian.dumitrescu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220727223639.598932-16-cristian.dumitrescu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220727223639.598932-16-cristian.dumitrescu@intel.com", "date": "2022-07-27T22:36:38", "name": "[V3,16/17] examples/pipelines: remove obsolete tap CLI command", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "925123b70b697e4ab2fd8f721f21f991832fda6a", "submitter": { "id": 19, "url": "http://patches.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220727223639.598932-16-cristian.dumitrescu@intel.com/mbox/", "series": [ { "id": 24106, "url": "http://patches.dpdk.org/api/series/24106/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24106", "date": "2022-07-27T22:36:23", "name": "[V3,01/17] pipeline: add pipeline name", "version": 3, "mbox": "http://patches.dpdk.org/series/24106/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/114294/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/114294/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 27488A00C4;\n\tThu, 28 Jul 2022 00:38:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4B07742BB3;\n\tThu, 28 Jul 2022 00:37:06 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 6BEE542B94\n for <dev@dpdk.org>; Thu, 28 Jul 2022 00:36:57 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Jul 2022 15:36:57 -0700", "from silpixa00400573.ir.intel.com (HELO\n silpixa00400573.ger.corp.intel.com.) ([10.237.223.157])\n by orsmga008.jf.intel.com with ESMTP; 27 Jul 2022 15:36:56 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1658961417; x=1690497417;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=uZX8+4QfKLcqTrRryvdWz4IJDULmCR6po14r0NtwhbI=;\n b=OJNLJfFiabPNExjTtVfn4z7UsE41FgQgNTBY5odWzyI27JrvMdC8GmeU\n IGu8q4eUWiuBneuKX+NRxkN/wUeaM00GNwtzgIc/lH5jNCTFJR03wqSs9\n DECtH9jI6lccljOsIT3UOi0qfBM6qykr1KzRhUf3Er43URmPgp3sMOrR3\n nl7uH1nq1sDKklvNtJ4X+89DVOFjaK2+eixD0kb6xKp8j7j0UT4rPUEAw\n iwkY0BA9A1UFGKalDawFdKdh/jqpM/Fo4kWD2SI+wGFS09di1FwU6xgxy\n yf08IemcOZVLycD2daPeeYdXwfJzAuazPcWAV5qpdTapaAvpDsyNBX2bL w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10421\"; a=\"350068856\"", "E=Sophos;i=\"5.93,196,1654585200\"; d=\"scan'208\";a=\"350068856\"", "E=Sophos;i=\"5.93,196,1654585200\"; d=\"scan'208\";a=\"628567691\"" ], "X-ExtLoop1": "1", "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "To": "dev@dpdk.org", "Cc": "\"Kamalakannan R .\" <kamalakannan.r@intel.com>", "Subject": "[PATCH V3 16/17] examples/pipelines: remove obsolete tap CLI command", "Date": "Wed, 27 Jul 2022 22:36:38 +0000", "Message-Id": "<20220727223639.598932-16-cristian.dumitrescu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220727223639.598932-1-cristian.dumitrescu@intel.com>", "References": "<20220718132603.339314-1-cristian.dumitrescu@intel.com>\n <20220727223639.598932-1-cristian.dumitrescu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove the tap CLI command, as the file descriptor I/O ports of the\npipeline are now configured trough the I/O specification file.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Kamalakannan R. <kamalakannan.r@intel.com>\n---\n examples/pipeline/cli.c | 37 -----------------\n examples/pipeline/obj.c | 89 -----------------------------------------\n examples/pipeline/obj.h | 18 ---------\n 3 files changed, 144 deletions(-)", "diff": "diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c\nindex d56a830fb7..75c32b9089 100644\n--- a/examples/pipeline/cli.c\n+++ b/examples/pipeline/cli.c\n@@ -466,32 +466,6 @@ cmd_ring(char **tokens,\n \t}\n }\n \n-static const char cmd_tap_help[] =\n-\"tap <tap_name>\\n\";\n-\n-static void\n-cmd_tap(char **tokens,\n-\tuint32_t n_tokens,\n-\tchar *out,\n-\tsize_t out_size,\n-\tvoid *obj)\n-{\n-\tstruct tap *tap;\n-\tchar *name;\n-\n-\tif (n_tokens < 2) {\n-\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);\n-\t\treturn;\n-\t}\n-\tname = tokens[1];\n-\n-\ttap = tap_create(obj, name);\n-\tif (tap == NULL) {\n-\t\tsnprintf(out, out_size, MSG_CMD_FAIL, tokens[0]);\n-\t\treturn;\n-\t}\n-}\n-\n static const char cmd_pipeline_codegen_help[] =\n \"pipeline codegen <spec_file> <code_file>\\n\";\n \n@@ -2645,7 +2619,6 @@ cmd_help(char **tokens,\n \t\t\t\"List of commands:\\n\"\n \t\t\t\"\\tmempool\\n\"\n \t\t\t\"\\tethdev\\n\"\n-\t\t\t\"\\ttap\\n\"\n \t\t\t\"\\tpipeline codegen\\n\"\n \t\t\t\"\\tpipeline libbuild\\n\"\n \t\t\t\"\\tpipeline build\\n\"\n@@ -2690,11 +2663,6 @@ cmd_help(char **tokens,\n \t\treturn;\n \t}\n \n-\tif (strcmp(tokens[0], \"tap\") == 0) {\n-\t\tsnprintf(out, out_size, \"\\n%s\\n\", cmd_tap_help);\n-\t\treturn;\n-\t}\n-\n \tif ((strcmp(tokens[0], \"pipeline\") == 0) &&\n \t\t(n_tokens == 2) && (strcmp(tokens[1], \"codegen\") == 0)) {\n \t\tsnprintf(out, out_size, \"\\n%s\\n\", cmd_pipeline_codegen_help);\n@@ -2950,11 +2918,6 @@ cli_process(char *in, char *out, size_t out_size, void *obj)\n \t\treturn;\n \t}\n \n-\tif (strcmp(tokens[0], \"tap\") == 0) {\n-\t\tcmd_tap(tokens, n_tokens, out, out_size, obj);\n-\t\treturn;\n-\t}\n-\n \tif (strcmp(tokens[0], \"pipeline\") == 0) {\n \t\tif ((n_tokens >= 3) &&\n \t\t\t(strcmp(tokens[1], \"codegen\") == 0)) {\ndiff --git a/examples/pipeline/obj.c b/examples/pipeline/obj.c\nindex 950ab831fb..b7e2316eec 100644\n--- a/examples/pipeline/obj.c\n+++ b/examples/pipeline/obj.c\n@@ -35,11 +35,6 @@ TAILQ_HEAD(link_list, link);\n */\n TAILQ_HEAD(ring_list, ring);\n \n-/*\n- * tap\n- */\n-TAILQ_HEAD(tap_list, tap);\n-\n /*\n * obj\n */\n@@ -47,7 +42,6 @@ struct obj {\n \tstruct mempool_list mempool_list;\n \tstruct link_list link_list;\n \tstruct ring_list ring_list;\n-\tstruct tap_list tap_list;\n };\n \n /*\n@@ -416,88 +410,6 @@ ring_find(struct obj *obj, const char *name)\n \treturn NULL;\n }\n \n-/*\n- * tap\n- */\n-#define TAP_DEV\t\t\"/dev/net/tun\"\n-\n-struct tap *\n-tap_find(struct obj *obj, const char *name)\n-{\n-\tstruct tap *tap;\n-\n-\tif (!obj || !name)\n-\t\treturn NULL;\n-\n-\tTAILQ_FOREACH(tap, &obj->tap_list, node)\n-\t\tif (strcmp(tap->name, name) == 0)\n-\t\t\treturn tap;\n-\n-\treturn NULL;\n-}\n-\n-struct tap *\n-tap_next(struct obj *obj, struct tap *tap)\n-{\n-\treturn (tap == NULL) ?\n-\t\tTAILQ_FIRST(&obj->tap_list) : TAILQ_NEXT(tap, node);\n-}\n-\n-#ifndef RTE_EXEC_ENV_LINUX\n-\n-struct tap *\n-tap_create(struct obj *obj __rte_unused, const char *name __rte_unused)\n-{\n-\treturn NULL;\n-}\n-\n-#else\n-\n-struct tap *\n-tap_create(struct obj *obj, const char *name)\n-{\n-\tstruct tap *tap;\n-\tstruct ifreq ifr;\n-\tint fd, status;\n-\n-\t/* Check input params */\n-\tif ((name == NULL) ||\n-\t\ttap_find(obj, name))\n-\t\treturn NULL;\n-\n-\t/* Resource create */\n-\tfd = open(TAP_DEV, O_RDWR | O_NONBLOCK);\n-\tif (fd < 0)\n-\t\treturn NULL;\n-\n-\tmemset(&ifr, 0, sizeof(ifr));\n-\tifr.ifr_flags = IFF_TAP | IFF_NO_PI; /* No packet information */\n-\tstrlcpy(ifr.ifr_name, name, IFNAMSIZ);\n-\n-\tstatus = ioctl(fd, TUNSETIFF, (void *) &ifr);\n-\tif (status < 0) {\n-\t\tclose(fd);\n-\t\treturn NULL;\n-\t}\n-\n-\t/* Node allocation */\n-\ttap = calloc(1, sizeof(struct tap));\n-\tif (tap == NULL) {\n-\t\tclose(fd);\n-\t\treturn NULL;\n-\t}\n-\t/* Node fill in */\n-\tstrlcpy(tap->name, name, sizeof(tap->name));\n-\ttap->fd = fd;\n-\n-\t/* Node add to list */\n-\tTAILQ_INSERT_TAIL(&obj->tap_list, tap, node);\n-\n-\treturn tap;\n-}\n-\n-#endif\n-\n /*\n * obj\n */\n@@ -513,7 +425,6 @@ obj_init(void)\n \tTAILQ_INIT(&obj->mempool_list);\n \tTAILQ_INIT(&obj->link_list);\n \tTAILQ_INIT(&obj->ring_list);\n-\tTAILQ_INIT(&obj->tap_list);\n \n \treturn obj;\n }\ndiff --git a/examples/pipeline/obj.h b/examples/pipeline/obj.h\nindex af270a8e57..8ea1c414c2 100644\n--- a/examples/pipeline/obj.h\n+++ b/examples/pipeline/obj.h\n@@ -121,22 +121,4 @@ ring_create(struct obj *obj,\n struct ring *\n ring_find(struct obj *obj, const char *name);\n \n-/*\n- * tap\n- */\n-struct tap {\n-\tTAILQ_ENTRY(tap) node;\n-\tchar name[NAME_SIZE];\n-\tint fd;\n-};\n-\n-struct tap *\n-tap_find(struct obj *obj, const char *name);\n-\n-struct tap *\n-tap_next(struct obj *obj, struct tap *tap);\n-\n-struct tap *\n-tap_create(struct obj *obj, const char *name);\n-\n #endif /* _INCLUDE_OBJ_H_ */\n", "prefixes": [ "V3", "16/17" ] }