Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114272/?format=api
{ "id": 114272, "url": "http://patches.dpdk.org/api/patches/114272/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220727103616.18596-4-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220727103616.18596-4-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220727103616.18596-4-liudongdong3@huawei.com", "date": "2022-07-27T10:36:11", "name": "[3/8] net/hns3: fix next-to-use overflow when using simple xmit", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f992db1001993600267c9e37f923428f74c9a5a9", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220727103616.18596-4-liudongdong3@huawei.com/mbox/", "series": [ { "id": 24104, "url": "http://patches.dpdk.org/api/series/24104/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24104", "date": "2022-07-27T10:36:08", "name": "some bugfixes for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/24104/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/114272/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/114272/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0B230A00C4;\n\tWed, 27 Jul 2022 12:37:29 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2168441147;\n\tWed, 27 Jul 2022 12:37:18 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 7428040141;\n Wed, 27 Jul 2022 12:37:16 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Lt9Bp0pFTzkXFw;\n Wed, 27 Jul 2022 18:34:42 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Wed, 27 Jul 2022 18:37:14 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>,\n <ferruh.yigit@xilinx.com>, <thomas@monjalon.net>", "CC": "<stable@dpdk.org>, Chengwen Feng <fengchengwen@huawei.com>, Dongdong Liu\n <liudongdong3@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, \"Wei Hu\n (Xavier)\" <xavier.huwei@huawei.com>, Huisong Li <lihuisong@huawei.com>", "Subject": "[PATCH 3/8] net/hns3: fix next-to-use overflow when using simple xmit", "Date": "Wed, 27 Jul 2022 18:36:11 +0800", "Message-ID": "<20220727103616.18596-4-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220727103616.18596-1-liudongdong3@huawei.com>", "References": "<20220727103616.18596-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nIf txq's next-to-use plus nb_pkts equal txq's nb_tx_desc when using\nsimple xmit algorithm, the txq's next-to-use will equal nb_tx_desc\nfter the xmit, this does not cause Tx exceptions, but may affect other\nops that depend on this field, such as tx_descriptor_status.\n\nThis patch fixes it.\n\nFixes: 7ef933908f04 (\"net/hns3: add simple Tx path\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex 95f711e7eb..bb06038848 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -4126,14 +4126,16 @@ hns3_xmit_pkts_simple(void *tx_queue,\n \t}\n \n \ttxq->tx_bd_ready -= nb_pkts;\n-\tif (txq->next_to_use + nb_pkts > txq->nb_tx_desc) {\n+\tif (txq->next_to_use + nb_pkts >= txq->nb_tx_desc) {\n \t\tnb_tx = txq->nb_tx_desc - txq->next_to_use;\n \t\thns3_tx_fill_hw_ring(txq, tx_pkts, nb_tx);\n \t\ttxq->next_to_use = 0;\n \t}\n \n-\thns3_tx_fill_hw_ring(txq, tx_pkts + nb_tx, nb_pkts - nb_tx);\n-\ttxq->next_to_use += nb_pkts - nb_tx;\n+\tif (nb_pkts > nb_tx) {\n+\t\thns3_tx_fill_hw_ring(txq, tx_pkts + nb_tx, nb_pkts - nb_tx);\n+\t\ttxq->next_to_use += nb_pkts - nb_tx;\n+\t}\n \n \thns3_write_txq_tail_reg(txq, nb_pkts);\n \n", "prefixes": [ "3/8" ] }