Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113890/?format=api
{ "id": 113890, "url": "http://patches.dpdk.org/api/patches/113890/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/20220711151748.3155-1-zhiminx.huang@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20220711151748.3155-1-zhiminx.huang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20220711151748.3155-1-zhiminx.huang@intel.com", "date": "2022-07-11T15:17:48", "name": "[V1] tests/ice_advanced_rss_pppoe:add destroy test param", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b9aa9cd7240f3f0d9cdff7af7e529cd3b000dfbe", "submitter": { "id": 1685, "url": "http://patches.dpdk.org/api/people/1685/?format=api", "name": "Huang, ZhiminX", "email": "zhiminx.huang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/20220711151748.3155-1-zhiminx.huang@intel.com/mbox/", "series": [ { "id": 23954, "url": "http://patches.dpdk.org/api/series/23954/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=23954", "date": "2022-07-11T15:17:48", "name": "[V1] tests/ice_advanced_rss_pppoe:add destroy test param", "version": 1, "mbox": "http://patches.dpdk.org/series/23954/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/113890/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/113890/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D570CA0032;\n\tMon, 11 Jul 2022 08:55:43 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A71CA4021F;\n\tMon, 11 Jul 2022 08:55:43 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 0655D4021E\n for <dts@dpdk.org>; Mon, 11 Jul 2022 08:55:41 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Jul 2022 23:55:40 -0700", "from unknown (HELO localhost.localdomain) ([10.239.252.93])\n by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Jul 2022 23:55:39 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1657522542; x=1689058542;\n h=from:to:cc:subject:date:message-id;\n bh=eaNGvgMvxDh5aLdjl9/GnI2UyW3e8MTcJjkrGhMathM=;\n b=IqjDXnSSfae4enO59sM7Ehd1uPz+SL17Nc06wH04VaMe/NBAzJaiZLKx\n SKskjYmTKty9mjIg3rPTj0PAjmhCQi/KCyABWcGi6rE4dBqoTpT+nozJ4\n IC8mSRwcgwDFi+I1Z436YM2CX2SspQNkm3nXleIyXPAp/YbTv6MPc+HQt\n YYm7PRwXICCHcNEO3fdfM0uuWoFsIXYiH+kIUJJ8V6eia/osxm0aXUMYQ\n OTyQ5iibpA5JcgfSrfiIphw7Zy3ntoCVWFd4rxiD1UC7+sZsjYsCH5Vzq\n TsV1CHRR0JyVOj/CDovF9LjJPTuJPSGEEEFhhkT9SUqWzgJl08gUhq7Eo A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10404\"; a=\"264366488\"", "E=Sophos;i=\"5.92,262,1650956400\"; d=\"scan'208\";a=\"264366488\"", "E=Sophos;i=\"5.92,262,1650956400\"; d=\"scan'208\";a=\"592157617\"" ], "From": "Zhimin Huang <zhiminx.huang@intel.com>", "To": "dts@dpdk.org", "Cc": "Zhimin Huang <zhiminx.huang@intel.com>", "Subject": "[dts][PATCH V1] tests/ice_advanced_rss_pppoe:add destroy test param", "Date": "Mon, 11 Jul 2022 23:17:48 +0800", "Message-Id": "<20220711151748.3155-1-zhiminx.huang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "fix dts 21b47e97d7e(add check result after deleting the rules).\nsome case no need to check hash values after destroy rule.\nso add param judgement to check destroy rule test flow.\n\nSigned-off-by: Zhimin Huang <zhiminx.huang@intel.com>\n---\n tests/TestSuite_ice_advanced_rss_pppoe.py | 32 ++++++++++++++---------\n 1 file changed, 20 insertions(+), 12 deletions(-)", "diff": "diff --git a/tests/TestSuite_ice_advanced_rss_pppoe.py b/tests/TestSuite_ice_advanced_rss_pppoe.py\nindex ebb644f6..78a6a734 100644\n--- a/tests/TestSuite_ice_advanced_rss_pppoe.py\n+++ b/tests/TestSuite_ice_advanced_rss_pppoe.py\n@@ -5153,8 +5153,11 @@ class Advanced_rss_pppoe(TestCase):\n func(out, hash_key)\n \n def _two_rules_operation(\n- self, rule_list, pkt_list, action_list1=None, action_list2=None\n+ self, rule_list, pkt_list, action_list1=None, action_list2=None, **kwargs\n ):\n+ destroy_test = (\n+ kwargs.get(\"destroy_test\") if kwargs.get(\"destroy_test\") else False\n+ )\n for i in range(0, len(rule_list)):\n self.rsspro.create_rule(rule_list[i])\n self.rsspro.check_rule(rule_list=[\"{}\".format(i)])\n@@ -5163,15 +5166,16 @@ class Advanced_rss_pppoe(TestCase):\n self._send_pkt_action(pkt_list)\n else:\n self._send_pkt_action(pkt_list)\n- # destory rule 1\n- self.rsspro.destroy_rule(rule_id=1)\n- self.rsspro.check_rule(rule_list=[\"1\"], stats=False)\n- pkt_list[1], pkt_list[2] = pkt_list[2], pkt_list[1]\n- self._send_pkt_action(pkt_list)\n- # destory rule 0\n- self.rsspro.destroy_rule(rule_id=0)\n- self.rsspro.check_rule(rule_list=[\"0\"], stats=False)\n- self._send_pkt_action(pkt_list, action_list=[\"check_no_hash\"] * 3)\n+ if destroy_test:\n+ # destroy rule 1\n+ self.rsspro.destroy_rule(rule_id=1)\n+ self.rsspro.check_rule(rule_list=[\"1\"], stats=False)\n+ pkt_list[1], pkt_list[2] = pkt_list[2], pkt_list[1]\n+ self._send_pkt_action(pkt_list)\n+ # destroy rule 0\n+ self.rsspro.destroy_rule(rule_id=0)\n+ self.rsspro.check_rule(rule_list=[\"0\"], stats=False)\n+ self._send_pkt_action(pkt_list, action_list=[\"check_no_hash\"] * 3)\n \n def test_two_rules_smaller_first_larger_later(\n self,\n@@ -5190,7 +5194,9 @@ class Advanced_rss_pppoe(TestCase):\n 'Ether(src=\"00:11:22:33:44:55\", dst=\"10:22:33:44:55:66\")/PPPoE(sessionid=3)/PPP(b\\'\\\\x00\\\\x21\\')/IP(src=\"192.168.1.1\", dst=\"192.168.1.2\")/UDP(sport=19,dport=23)/Raw(\"x\"*80)',\n 'Ether(src=\"00:11:22:33:44:53\", dst=\"10:22:33:44:55:99\")/PPPoE(sessionid=7)/PPP(b\\'\\\\x00\\\\x21\\')/IP(src=\"192.168.1.3\", dst=\"192.168.1.5\")/UDP(sport=25,dport=99)/Raw(\"x\"*80)',\n ]\n- self._two_rules_operation(rule_list, pkt_list, action_list2=[\"check_no_hash\"])\n+ self._two_rules_operation(\n+ rule_list, pkt_list, action_list2=[\"check_no_hash\"], destroy_test=True\n+ )\n self.verify(not self.rsspro.error_msgs, \"some subcases failed\")\n \n def test_two_rules_larger_first_smaller_later(self):\n@@ -5208,4 +5214,6 @@ class Advanced_rss_pppoe(TestCase):\n 'Ether(src=\"00:11:22:33:44:53\", dst=\"10:22:33:44:55:99\")/PPPoE(sessionid=7)/PPP(b\\'\\\\x00\\\\x21\\')/IP(src=\"192.168.1.3\", dst=\"192.168.1.5\")/UDP(sport=25,dport=99)/Raw(\"x\"*80)',\n 'Ether(src=\"00:11:22:33:44:55\", dst=\"10:22:33:44:55:66\")/PPPoE(sessionid=3)/PPP(b\\'\\\\x00\\\\x21\\')/IP(src=\"192.168.1.1\", dst=\"192.168.1.2\")/UDP(sport=19,dport=23)/Raw(\"x\"*80)',\n ]\n- self._two_rules_operation(rule_list, pkt_list, action_list2=[\"check_no_hash\"])\n+ self._two_rules_operation(\n+ rule_list, pkt_list, action_list2=[\"check_no_hash\"], destroy_test=True\n+ )\n", "prefixes": [ "V1" ] }