Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 113605,
    "url": "http://patches.dpdk.org/api/patches/113605/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1656666167-26035-3-git-send-email-longli@linuxonhyperv.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1656666167-26035-3-git-send-email-longli@linuxonhyperv.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1656666167-26035-3-git-send-email-longli@linuxonhyperv.com",
    "date": "2022-07-01T09:02:32",
    "name": "[02/17] net/mana: add device configuration and stop",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "69e4848ad0072b60c6aad33d74a43abc027d3511",
    "submitter": {
        "id": 1784,
        "url": "http://patches.dpdk.org/api/people/1784/?format=api",
        "name": "Long Li",
        "email": "longli@linuxonhyperv.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1656666167-26035-3-git-send-email-longli@linuxonhyperv.com/mbox/",
    "series": [
        {
            "id": 23855,
            "url": "http://patches.dpdk.org/api/series/23855/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23855",
            "date": "2022-07-01T09:02:30",
            "name": "Introduce Microsoft Azure Network Adatper (MANA) PMD",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/23855/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/113605/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/113605/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0EA1DA00C2;\n\tFri,  1 Jul 2022 11:03:18 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 930AF4284D;\n\tFri,  1 Jul 2022 11:03:06 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 5671042670\n for <dev@dpdk.org>; Fri,  1 Jul 2022 11:03:04 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1004)\n id ABB3D20D5906; Fri,  1 Jul 2022 02:03:03 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com ABB3D20D5906",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com;\n s=default; t=1656666183;\n bh=qv1V20I7DwO8wxob5/bIKItLq/37U9CyUtMkoulLG3s=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:Reply-To:From;\n b=czFooDAvWeq2xRlintr+NY81PjBJw+LS0Sm56tFSxj1FmTu/6fj2Yoq2n18DYMtQh\n 3879l+0SvItyWpICegP/7yrsLoR2scFa0Qr8zP0zY472UqaQ16Pq0eDdlxhg0guX8r\n jBDafL+jA5JK6meiWoXs9a+z9E22JP6Jvy3LIfJw=",
        "From": "longli@linuxonhyperv.com",
        "To": "Ferruh Yigit <ferruh.yigit@intel.com>",
        "Cc": "dev@dpdk.org, Ajay Sharma <sharmaajay@microsoft.com>,\n Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>",
        "Subject": "[PATCH 02/17] net/mana: add device configuration and stop",
        "Date": "Fri,  1 Jul 2022 02:02:32 -0700",
        "Message-Id": "<1656666167-26035-3-git-send-email-longli@linuxonhyperv.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1656666167-26035-1-git-send-email-longli@linuxonhyperv.com>",
        "References": "<1656666167-26035-1-git-send-email-longli@linuxonhyperv.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Reply-To": "longli@microsoft.com",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Long Li <longli@microsoft.com>\n\nMANA defines its memory allocation functions to override IB layer default\nfunctions to allocate device queues. This patch adds the code for device\nconfiguration and stop.\n\nSigned-off-by: Long Li <longli@microsoft.com>\n---\n drivers/net/mana/mana.c | 87 ++++++++++++++++++++++++++++++++++++++++-\n drivers/net/mana/mana.h |  3 --\n 2 files changed, 85 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c\nindex 893e2b1e23..882a38d7df 100644\n--- a/drivers/net/mana/mana.c\n+++ b/drivers/net/mana/mana.c\n@@ -57,7 +57,91 @@ static rte_spinlock_t mana_shared_data_lock = RTE_SPINLOCK_INITIALIZER;\n int mana_logtype_driver;\n int mana_logtype_init;\n \n+static void *mana_alloc_verbs_buf(size_t size, void *data)\n+{\n+\tvoid *ret;\n+\tsize_t alignment = rte_mem_page_size();\n+\tint socket = (int)(uintptr_t)data;\n+\n+\tDRV_LOG(DEBUG, \"size=%lu socket=%d\", size, socket);\n+\n+\tif (alignment == (size_t)-1) {\n+\t\tDRV_LOG(ERR, \"Failed to get mem page size\");\n+\t\trte_errno = ENOMEM;\n+\t\treturn NULL;\n+\t}\n+\n+\tret = rte_zmalloc_socket(\"mana_verb_buf\", size, alignment, socket);\n+\tif (!ret && size)\n+\t\trte_errno = ENOMEM;\n+\treturn ret;\n+}\n+\n+static void mana_free_verbs_buf(void *ptr, void *data __rte_unused)\n+{\n+\trte_free(ptr);\n+}\n+\n+static int mana_dev_configure(struct rte_eth_dev *dev)\n+{\n+\tstruct mana_priv *priv = dev->data->dev_private;\n+\tstruct rte_eth_conf *dev_conf = &dev->data->dev_conf;\n+\tconst struct rte_eth_rxmode *rxmode = &dev_conf->rxmode;\n+\tconst struct rte_eth_txmode *txmode = &dev_conf->txmode;\n+\n+\tif (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)\n+\t\tdev_conf->rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;\n+\n+\tif (txmode->offloads & ~BNIC_DEV_TX_OFFLOAD_SUPPORT) {\n+\t\tDRV_LOG(ERR, \"Unsupported TX offload: %lx\", txmode->offloads);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (rxmode->offloads & ~BNIC_DEV_RX_OFFLOAD_SUPPORT) {\n+\t\tDRV_LOG(ERR, \"Unsupported RX offload: %lx\", rxmode->offloads);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (dev->data->nb_rx_queues != dev->data->nb_tx_queues) {\n+\t\tDRV_LOG(ERR, \"Only support equal number of rx/tx queues\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (!rte_is_power_of_2(dev->data->nb_rx_queues)) {\n+\t\tDRV_LOG(ERR, \"number of TX/RX queues must be power of 2\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tpriv->num_queues = dev->data->nb_rx_queues;\n+\n+\tmanadv_set_context_attr(priv->ib_ctx, MANADV_CTX_ATTR_BUF_ALLOCATORS,\n+\t\t\t\t(void *)((uintptr_t)&(struct manadv_ctx_allocators){\n+\t\t\t\t\t.alloc = &mana_alloc_verbs_buf,\n+\t\t\t\t\t.free = &mana_free_verbs_buf,\n+\t\t\t\t\t.data = 0,\n+\t\t\t\t}));\n+\n+\treturn 0;\n+}\n+\n+static int\n+mana_dev_close(struct rte_eth_dev *dev)\n+{\n+\tstruct mana_priv *priv = dev->data->dev_private;\n+\tint ret;\n+\n+\tret = ibv_close_device(priv->ib_ctx);\n+\tif (ret) {\n+\t\tret = errno;\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n const struct eth_dev_ops mana_dev_ops = {\n+\t.dev_configure\t\t= mana_dev_configure,\n+\t.dev_close\t\t= mana_dev_close,\n };\n \n const struct eth_dev_ops mana_dev_sec_ops = {\n@@ -652,8 +736,7 @@ static int mana_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \n static int mana_dev_uninit(struct rte_eth_dev *dev)\n {\n-\tRTE_SET_USED(dev);\n-\treturn 0;\n+\treturn mana_dev_close(dev);\n }\n \n static int mana_pci_remove(struct rte_pci_device *pci_dev)\ndiff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h\nindex dbef5420ff..9609bee4de 100644\n--- a/drivers/net/mana/mana.h\n+++ b/drivers/net/mana/mana.h\n@@ -177,9 +177,6 @@ uint16_t mana_rx_burst_removed(void *dpdk_rxq, struct rte_mbuf **pkts,\n uint16_t mana_tx_burst_removed(void *dpdk_rxq, struct rte_mbuf **pkts,\n \t\t\t       uint16_t pkts_n);\n \n-void *mana_alloc_verbs_buf(size_t size, void *data);\n-void mana_free_verbs_buf(void *ptr, void *data);\n-\n /** Request timeout for IPC. */\n #define MANA_MP_REQ_TIMEOUT_SEC 5\n \n",
    "prefixes": [
        "02/17"
    ]
}