Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113602/?format=api
{ "id": 113602, "url": "http://patches.dpdk.org/api/patches/113602/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220701085707.246099-1-rebecca.troy@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220701085707.246099-1-rebecca.troy@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220701085707.246099-1-rebecca.troy@intel.com", "date": "2022-07-01T08:57:07", "name": "crypto/qat: fix secure session check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a4f4087ee80a20b82a181b57a77e693ade5fc4fb", "submitter": { "id": 2273, "url": "http://patches.dpdk.org/api/people/2273/?format=api", "name": "Rebecca Troy", "email": "rebecca.troy@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220701085707.246099-1-rebecca.troy@intel.com/mbox/", "series": [ { "id": 23854, "url": "http://patches.dpdk.org/api/series/23854/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23854", "date": "2022-07-01T08:57:07", "name": "crypto/qat: fix secure session check", "version": 1, "mbox": "http://patches.dpdk.org/series/23854/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/113602/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/113602/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 41FE9A00C2;\n\tFri, 1 Jul 2022 10:57:21 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6B1504069D;\n\tFri, 1 Jul 2022 10:57:20 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 0F35140150;\n Fri, 1 Jul 2022 10:57:18 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Jul 2022 01:57:17 -0700", "from silpixa00401279.ir.intel.com (HELO\n silpixa00401279.ger.corp.intel.com) ([10.237.222.42])\n by fmsmga008.fm.intel.com with ESMTP; 01 Jul 2022 01:57:16 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1656665839; x=1688201839;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=R9New69+8q4lcHdH1sMj7Y1Kps6Del4gz0iKU4DyvW4=;\n b=ihLSiLBzsZ6C8oiqn5CY5rOGmVxB77Z7dklYp/rqwA5h+fkKtqe7SmVO\n Ja/n5nmQKi4+aksjAQgaRFX5ooPzUkZxAXT+xUn9wpeD7r9KjWAhFtjSV\n qOIQDX5XHqTwyTMmtl8a/pdsa//Qr6Sn+S/5h0lpvLn2jmo0N6g/MRinr\n 3AmcQQ04I/20cE3R1mBTubswpKr0ik+ePlqSoUdQPKN3mqGlM3CZpfEb4\n xxPvPDAr6LMhb3HJ/44vRr52dgGD9q2k6omayBcDIeYKISB6KxBhuI7hQ\n Gb/pujJzFl5WsFWvKgpafxwZw3R2zpag54CGZU9KyoJp9dcDP35OBJrWy Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10394\"; a=\"280149244\"", "E=Sophos;i=\"5.92,236,1650956400\"; d=\"scan'208\";a=\"280149244\"", "E=Sophos;i=\"5.92,236,1650956400\"; d=\"scan'208\";a=\"648266207\"" ], "X-ExtLoop1": "1", "From": "Rebecca Troy <rebecca.troy@intel.com>", "To": "Fan Zhang <roy.fan.zhang@intel.com>", "Cc": "dev@dpdk.org, Rebecca Troy <rebecca.troy@intel.com>, kai.ji@intel.com,\n stable@dpdk.org", "Subject": "[PATCH] crypto/qat: fix secure session check", "Date": "Fri, 1 Jul 2022 08:57:07 +0000", "Message-Id": "<20220701085707.246099-1-rebecca.troy@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently when running the dpdk-perf-test with docsis\nsecurity sessions, a segmentation fault occurs. This\nis due to the check being made that the session is not\nequal to op->sym->sec_session. This check passes the\nfirst time but on the second iteration fails and doesn't\ncreate the build_request.\n\nThis commit fixes that error by getting the ctx first\nfrom the private session data and then comparing ctx,\nrather than op->sym->sec_session, with the sess.\n\nFixes: fb3b9f492205 (\"crypto/qat: rework burst data path\")\nCc: kai.ji@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Rebecca Troy <rebecca.troy@intel.com>\n---\n drivers/crypto/qat/qat_sym.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c\nindex 3477cd89ad..e5ae670b3a 100644\n--- a/drivers/crypto/qat/qat_sym.c\n+++ b/drivers/crypto/qat/qat_sym.c\n@@ -105,16 +105,16 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,\n \n #ifdef RTE_LIB_SECURITY\n \telse if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) {\n-\t\tif ((void *)sess != (void *)op->sym->sec_session) {\n-\t\t\tstruct rte_cryptodev *cdev;\n-\t\t\tstruct qat_cryptodev_private *internals;\n-\n-\t\t\tctx = get_sec_session_private_data(\n+\t\tctx = get_sec_session_private_data(\n \t\t\t\t\top->sym->sec_session);\n \t\t\tif (unlikely(!ctx)) {\n \t\t\t\tQAT_DP_LOG(ERR, \"No session for this device\");\n \t\t\t\treturn -EINVAL;\n \t\t\t}\n+\t\tif (sess != (uintptr_t)ctx) {\n+\t\t\tstruct rte_cryptodev *cdev;\n+\t\t\tstruct qat_cryptodev_private *internals;\n+\n \t\t\tif (unlikely(ctx->bpi_ctx == NULL)) {\n \t\t\t\tQAT_DP_LOG(ERR, \"QAT PMD only supports security\"\n \t\t\t\t\t\t\" operation requests for\"\n", "prefixes": [] }