Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113584/?format=api
{ "id": 113584, "url": "http://patches.dpdk.org/api/patches/113584/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1656642017-8992-3-git-send-email-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1656642017-8992-3-git-send-email-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1656642017-8992-3-git-send-email-chaoyong.he@corigine.com", "date": "2022-07-01T02:20:07", "name": "[v4,02/12] net/nfp: simplify initialization and remove dead code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6d4370b89e464e125646c5155643655d09fe0c61", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1656642017-8992-3-git-send-email-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 23850, "url": "http://patches.dpdk.org/api/series/23850/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23850", "date": "2022-07-01T02:20:05", "name": "preparation for the rte_flow offload of nfp PMD", "version": 4, "mbox": "http://patches.dpdk.org/series/23850/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/113584/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/113584/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7B133A0093;\n\tFri, 1 Jul 2022 04:21:17 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7281042905;\n\tFri, 1 Jul 2022 04:21:12 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41])\n by mails.dpdk.org (Postfix) with ESMTP id 1DF0C40A80\n for <dev@dpdk.org>; Fri, 1 Jul 2022 04:21:10 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by CH2PR13MB4459.namprd13.prod.outlook.com (2603:10b6:610:35::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.11; Fri, 1 Jul\n 2022 02:21:09 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::5d9e:9ce5:51d1:2021]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::5d9e:9ce5:51d1:2021%9]) with mapi id 15.20.5395.014; Fri, 1 Jul 2022\n 02:21:09 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Sou0GYo5HkWapvGIJNBxm9FbBMnWZ9iBfIyen67rZUnqTMzn/g3sSosFJxA2qJYHGD3/ISl4fqg+7iYQrtn+ODslcndpUA3GNa74/b/aHT6kfRxgO3sf40g98utgGEDwoIZU/eo+6jC79xNJU+18xjh78wfBMlLgH27iXWumcnl+kvs44TBvlgfNQfGkOCFkOZUwP0j7dnTNbOFWnWNNAqh37a9Ic1SLqankFEfhspYBrGVn6BxMfhs3AvcHnUB5+/CB9RX/5DVS6cyc1KGJaoGGIawmDLjy7NPi3h8HWvmLWEm451pNnBNgQfOB22xf1P1t7JcwPQkoJTWtPyPo1w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Ft/XwXnwub++Lq508dydo4EZa+ijmdHevGF9s4Hph+s=;\n b=KSAQXUuZOCy73cO5kSSnW4+BMf02Xyn1imb9OZe7dBog78WFGD59Z6ewNdk+B2Rq/e1J0svVQCZUyOERtJXYBvXzMIJKsKDkX/PYtmr6x1GWeVko/RMaUz+J7XjYOlkDoGULh3kYHTLnlhQb8z9mKuvck0IcMbZHsGTtiRGYuwKII0zBzyTBeVxUKf8RcdRpqfOf19RHxNYapA1Hc8Bx6WAQ+9vor39DVjFRty7u4kMrYTci19Eblj8UEz2iAbDnE8t+ogamDIiviqQ3Eh74SQMXW9ld6AyJehkgEjQjZB9zuai8iYCgCE2zOs5ijAXMHaqmV2wGGp8PbC9ledu5Vw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ft/XwXnwub++Lq508dydo4EZa+ijmdHevGF9s4Hph+s=;\n b=lUIY4t5F6sL1rCzaawR+wzpmwUsZGDdvi39Qj7+K10RTYq9LoeS78qqzrmWK4uzrL6OXam6G1tF1nJL8oLTfkl8uOudvWc3kDDNWUMpmIULwEqQFM6Tn5QZS1hqIL6zEX33RC0N5ZjFE2hmzeeLalH8vGGktw372uCgE+GjgbkI=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "niklas.soderlund@corigine.com,\n\tChaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH v4 02/12] net/nfp: simplify initialization and remove dead\n code", "Date": "Fri, 1 Jul 2022 10:20:07 +0800", "Message-Id": "<1656642017-8992-3-git-send-email-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1656642017-8992-1-git-send-email-chaoyong.he@corigine.com>", "References": "<1656642017-8992-1-git-send-email-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "SG2PR02CA0079.apcprd02.prod.outlook.com\n (2603:1096:4:90::19) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "445c4bf7-22ac-4168-bcf0-08da5b085c08", "X-MS-TrafficTypeDiagnostic": "CH2PR13MB4459:EE_", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n IB/qBXjfrLyoxHXo0y30pfhG930pDFmqRbm4JCPtHYEijJaEp3cSurObHEOTOUsgfXefw+Ca/l4hm7dDKq+TNIOxapwnSbzS2FeRR+VP8kFluZArGcNi4ZxuwcaGusJj3ePyuXlaZ2E7ksSzeVCzAid99zcuDzFhWRCHsnxrE8FZQ6rhaKdT4yR1GdYtMA7hC1RY62aNyBiRFgEups79o/wWWnwnJD3wfHXK65icdYRNu8zISowvON5KCdb8568xA7oR2iDRxm9M2004N+XnFfPs8UykwW5O/4RhhmfkHPZyg82Qep8AuUBp7WzSbPmWmdHL1LXRXUhKNEbN/sxWebEL2FSenEPoJ1mLlb4ZU6QEW7FI67BFgr/MdnjBO62VFuDHQPz45nOkWlzg0RKdBe5BI5c/FDGikDgcN+yTn/diwsXxuZoGWacicmxf9pz+B+xKtdtjNjjZxfGu53qXfBCzYygXMkeuWbEmXNpITx7mPIpaAdy+tknmdB7rq/X6RBIw5GfF9JJGvi8IK7ccq3/ZH18q/6sb/kySRB+hkcOxMrBS4rsSbRQity25gNLzogu8s+C+RFDU1+OM8wmt8L2/LVk3a4fJed3kd17BvRA/kU2VTKJBBHCGlgpNZqJPef+PTeruOD26fKQG1/3S2FslneHhs90aC9LYGg8GFPqBZp99ywmsMIgYKGPotS6Yb0t/iKpjiPqaL2BXUdXNwnkbR58h4sXyI9HtBzT8OLje2jIti+9B5uSFZw6flCc8xoye2pJ4z+lmJRssjU2ug8m99EI7DnLzSyD/J+gJwy6+OqTg+m3TU7QHslRzJr7ONpXKedqxlIx/e5g4na2o3Ay4/mdl/mbbgpHldDBzoMqrlJ3L6PaeStPPcv+BhAgT", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230016)(4636009)(39840400004)(346002)(376002)(366004)(396003)(136003)(6486002)(4326008)(186003)(36756003)(26005)(66476007)(66556008)(2616005)(8676002)(83380400001)(6512007)(107886003)(38350700002)(5660300002)(66946007)(8936002)(38100700002)(2906002)(478600001)(44832011)(6916009)(6506007)(316002)(52116002)(41300700001)(86362001);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?rkFSmFgE8hUPwOhHD7muEV2iObw7?=\n\t=?utf-8?q?lRyV1XoDWjWUY1fY765xpgO+zRJIoWhdPmPEgtAL1DdGnofOoA0ldNYkUYJRQoZDR?=\n\t=?utf-8?q?sHQ+O8hfgYFt3woDEmqrqb0kGHb6vEUNp6yIon1p85/zVKKmREgRI/CoA63w/SZtB?=\n\t=?utf-8?q?yIgIdPm/HXTsw7vJAgP/XoCp25WOHBP+yeL4ZT1LA3+Nv6cDPXDjTGLQQSi2IRWYb?=\n\t=?utf-8?q?0JO8HtjbZuN+pJ7b/xBoCVYuV181aOmD6rCkcoObUyk7PODEyJsv0sWIv2BIzVc2O?=\n\t=?utf-8?q?jhPvYEOtUg8no+XkZXhPWImW3r9vFv9VxFub8f05to8yXS0NZOL3Twyi/idzsoyVl?=\n\t=?utf-8?q?tQ+LQxLc1HgRnS/xHq2HMZZt/wZB0Dd6jwPadj0ttdSEN088XkfHjCvY6NwBdH32h?=\n\t=?utf-8?q?HW5FRADkUuMpE3myNoLUiZN3rfJdDHlE3ebQgoVCzoySJr2ItuYiFoEOuq73Z4unR?=\n\t=?utf-8?q?6V1ZfEJEtfWSJjAtpCILZY5DOsTuFpd12YlwgoqC+0+Pg/skzviVPNSIM0/49WtYG?=\n\t=?utf-8?q?f1P8ieNKAnr4admM0zygQlpORv/mZ01HoiTv28j43bB7VgwH9BOPXw9AE7/wzegUy?=\n\t=?utf-8?q?zLamox4tWgxXRVYYNZPKZ0u6mDecPdnwU6QxllLQdwJq35pTkYNnDXkLHc7k+j54W?=\n\t=?utf-8?q?NVLgudkwbBEDbCu/nH/LlzazfTA6q2d7kEDXq6zZzehmYPrvo+5qsX+tEgEY21HqJ?=\n\t=?utf-8?q?IRdO/Yhb0wwLz52VME4bjlEO6IvSFyfUMMtlHEEPjh5+c7PkyTIpTZ6One7F4qqQj?=\n\t=?utf-8?q?hnt3o39SJsoFcQ/6Xl4H44Q4r0dXgYPL9AHvrBGrTtgPapMbKU2nzM/KUSoUBBpvY?=\n\t=?utf-8?q?wB2EFEB2VWLZqMEf7nI50BVD8hN5PvA5x4P3xakmxHvPg/X8DLdNZOs5+oYvNcfx5?=\n\t=?utf-8?q?nZ0ONJzjYjUwIrZnLCgvv1fHrUMihonETHGWXR6mpRAqrsY9zkLuTTYggkdIbWe/K?=\n\t=?utf-8?q?k8TFfn2xnBM8SJo1cLisLXoPXwNVv7U7fpczKtgEm7SkbbXzmKgI/vLMEAFa99jLq?=\n\t=?utf-8?q?EkC8Zpvy2Zqmg+U7rGHlxwZwbAJNNfEOgp4sx9skUYTZYyAFB5NYRFQxJgm/5kUQj?=\n\t=?utf-8?q?fQhN8ZSZeqRfQUjLISR9txk0/KuJttLNRxrFxm26G9g+s0q5kow4XYfEpJumpP2ug?=\n\t=?utf-8?q?zWIZC4dy0++g2CDmnLbS9w9bBzVtEw4q+exReBldOpH0i5MfedWp/Y2TzydHlArMk?=\n\t=?utf-8?q?vf3mQOvkNqdoaHjzGohvdfWyFjwi6m/Y12Fd9R+YKeMIiVKBv4CGDHWEJOtlOOkrt?=\n\t=?utf-8?q?sy+yCQhScH/d5nOsl/Dft7YGQTlAvlBrH3RqCus2DX2yNIGbvhnK9hSCu0nGouh+/?=\n\t=?utf-8?q?28YioWhmFlmcH5eTyvvpOYZcke/ZTSa/i/W7e4ZIjSRLJucCWgYPQG9/uuZ76fv8M?=\n\t=?utf-8?q?+hqfkrHsd1wDr4M3oRTisHwwkXuOEa/nDh6MLQ0o+U4pNFRH0AlVqFM4Jgo/D7gIx?=\n\t=?utf-8?q?piOcXTtFrtoxyAD/RjW7HjCqmihaj/xYDIgR+yMiFjT4ZNVVjIJ05LQ5i3xJZE2KQ?=\n\t=?utf-8?q?vRJsL5mH2F4JEUzJiIPc2vc+f3s8gWCkSA=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 445c4bf7-22ac-4168-bcf0-08da5b085c08", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "01 Jul 2022 02:21:09.0944 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n N/LQVUzCTnXtNPXjn4O3Udf0ZZsvd/oDgiZwiJvX/1/acI1G47neToi2xABLp+qC1bJ0JoEAkLpZ41wCFm4rBzb9GUrkET0PfWu0iMJPS2k=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH2PR13MB4459", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Calling nfp_net_init() is only done for the corenic firmware flavor\nand it is guaranteed to always be called from the primary process,\nso the explicit check for RTE_PROC_PRIMARY can be dropped.\n\nThe calling graph of nfp_net_init() already guaranteed the free of\nresources when it fail, so remove the necessary free logics inside it.\n\nWhile at it remove the unused member is_phyport from struct nfp_net_hw.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfp_common.h | 1 -\n drivers/net/nfp/nfp_ethdev.c | 40 +++++++++++-----------------------------\n 2 files changed, 11 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h\nindex 2aaf1d6..b28ebc9 100644\n--- a/drivers/net/nfp/nfp_common.h\n+++ b/drivers/net/nfp/nfp_common.h\n@@ -238,7 +238,6 @@ struct nfp_net_hw {\n \tuint8_t idx;\n \t/* Internal port number as seen from NFP */\n \tuint8_t nfp_idx;\n-\tbool\tis_phyport;\n \n \tunion eth_table_entry *eth_table;\n \ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 3c4b0ac..2c5607c 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -417,7 +417,6 @@\n \tuint32_t start_q;\n \tint stride = 4;\n \tint port = 0;\n-\tint err;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -452,10 +451,6 @@\n \tPMD_INIT_LOG(DEBUG, \"Working with physical port number: %d, \"\n \t\t\t\"NFP internal port number: %d\", port, hw->nfp_idx);\n \n-\t/* For secondary processes, the primary has done all the work */\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n-\t\treturn 0;\n-\n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n \n \thw->device_id = pci_dev->id.device_id;\n@@ -506,8 +501,7 @@\n \t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(ERR, \"nfp_net: no device ID matching\");\n-\t\terr = -ENODEV;\n-\t\tgoto dev_err_ctrl_map;\n+\t\treturn -ENODEV;\n \t}\n \n \tPMD_INIT_LOG(DEBUG, \"tx_bar_off: 0x%\" PRIx64 \"\", tx_bar_off);\n@@ -573,8 +567,7 @@\n \t\t\t\t\t RTE_ETHER_ADDR_LEN, 0);\n \tif (eth_dev->data->mac_addrs == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to space for MAC address\");\n-\t\terr = -ENOMEM;\n-\t\tgoto dev_err_queues_map;\n+\t\treturn -ENOMEM;\n \t}\n \n \tnfp_net_pf_read_mac(app_nic, port);\n@@ -604,24 +597,15 @@\n \t\t hw->mac_addr[0], hw->mac_addr[1], hw->mac_addr[2],\n \t\t hw->mac_addr[3], hw->mac_addr[4], hw->mac_addr[5]);\n \n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\t/* Registering LSC interrupt handler */\n-\t\trte_intr_callback_register(pci_dev->intr_handle,\n-\t\t\t\tnfp_net_dev_interrupt_handler, (void *)eth_dev);\n-\t\t/* Telling the firmware about the LSC interrupt entry */\n-\t\tnn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX);\n-\t\t/* Recording current stats counters values */\n-\t\tnfp_net_stats_reset(eth_dev);\n-\t}\n+\t/* Registering LSC interrupt handler */\n+\trte_intr_callback_register(pci_dev->intr_handle,\n+\t\t\tnfp_net_dev_interrupt_handler, (void *)eth_dev);\n+\t/* Telling the firmware about the LSC interrupt entry */\n+\tnn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX);\n+\t/* Recording current stats counters values */\n+\tnfp_net_stats_reset(eth_dev);\n \n \treturn 0;\n-\n-dev_err_queues_map:\n-\t\tnfp_cpp_area_free(hw->hwqueues_area);\n-dev_err_ctrl_map:\n-\t\tnfp_cpp_area_free(hw->ctrl_area);\n-\n-\treturn err;\n }\n \n #define DEFAULT_FW_PATH \"/lib/firmware/netronome\"\n@@ -818,7 +802,6 @@\n \t\thw->eth_dev = eth_dev;\n \t\thw->idx = i;\n \t\thw->nfp_idx = nfp_eth_table->ports[i].index;\n-\t\thw->is_phyport = true;\n \n \t\teth_dev->device = &pf_dev->pci_dev->device;\n \n@@ -884,8 +867,7 @@\n \n \tif (cpp == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"A CPP handle can not be obtained\");\n-\t\tret = -EIO;\n-\t\tgoto error;\n+\t\treturn -EIO;\n \t}\n \n \thwinfo = nfp_hwinfo_read(cpp);\n@@ -1005,7 +987,7 @@\n \tfree(hwinfo);\n cpp_cleanup:\n \tnfp_cpp_free(cpp);\n-error:\n+\n \treturn ret;\n }\n \n", "prefixes": [ "v4", "02/12" ] }