Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113459/?format=api
{ "id": 113459, "url": "http://patches.dpdk.org/api/patches/113459/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220627072232.243946-1-yidingx.zhou@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220627072232.243946-1-yidingx.zhou@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220627072232.243946-1-yidingx.zhou@intel.com", "date": "2022-06-27T07:22:32", "name": "net/iavf: fix issue of VF resetting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5cbaf13a43ecb14c18f4bb87b86cffc38665e016", "submitter": { "id": 2501, "url": "http://patches.dpdk.org/api/people/2501/?format=api", "name": "Yiding Zhou", "email": "yidingx.zhou@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220627072232.243946-1-yidingx.zhou@intel.com/mbox/", "series": [ { "id": 23779, "url": "http://patches.dpdk.org/api/series/23779/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23779", "date": "2022-06-27T07:22:32", "name": "net/iavf: fix issue of VF resetting", "version": 1, "mbox": "http://patches.dpdk.org/series/23779/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/113459/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/113459/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DF9A7A00C4;\n\tMon, 27 Jun 2022 09:22:28 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8483E400D7;\n\tMon, 27 Jun 2022 09:22:28 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 64D42400D5;\n Mon, 27 Jun 2022 09:22:26 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Jun 2022 00:22:25 -0700", "from unknown (HELO dpdkserver..) ([10.239.252.174])\n by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Jun 2022 00:22:23 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1656314546; x=1687850546;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=gF7Y4iB9/nE7qmU0dfauJVcElHPDSfBO08k43kVqd/k=;\n b=OlTtostOk272NLxJhR73DWzU6Rcyr9m9mL2UU+6Basa6mW2KbeW/BvfF\n gnlQ0iUuKo4lPRXoXHZgX9tf8Lg/zmmC46s9jKGZCHnO2wGhy2PAme8sP\n 4T3ue0J8PtNCbzWZYDXaakP5zIpNu57G44T0x6YbnwaRAk4s9Ye1tpvfS\n VNCuUxcHe+f5hRKZKMEKU9qTYOv0bCEqjqyyhsUvcsCmLYelzUncfAh45\n Q36y099Ifz/ap4xbf+U0NoOSI+Y0qTdE+gmrAGSNmz5pBBYNmegyqMe7y\n dBmnfqYm4OUhUuW9hse6jgqMX1iNsFBwbmFoe0x0V7QHk+0XiVaAIyiwh Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10390\"; a=\"261795960\"", "E=Sophos;i=\"5.92,225,1650956400\"; d=\"scan'208\";a=\"261795960\"", "E=Sophos;i=\"5.92,225,1650956400\"; d=\"scan'208\";a=\"594186416\"" ], "From": "Yiding Zhou <yidingx.zhou@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Yiding Zhou <yidingx.zhou@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>", "Subject": "[PATCH] net/iavf: fix issue of VF resetting", "Date": "Mon, 27 Jun 2022 15:22:32 +0800", "Message-Id": "<20220627072232.243946-1-yidingx.zhou@intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the VF is in closed state, the vf_reset flag can not be reverted\nif the VF is reset asynchronously. This prevents all virtchnl commands\nfrom executing, causing subsequent calls to iavf_dev_reset() to fail.\n\nSo the vf_reset flag needs to be reverted even when VF is in closed state.\n\nFixes: 676d986b4b86 (\"net/iavf: fix crash after VF reset failure\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yiding Zhou <yidingx.zhou@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 7df0bf8118..506fcff6e3 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -2702,8 +2702,10 @@ iavf_dev_close(struct rte_eth_dev *dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n-\tif (adapter->closed)\n-\t\treturn 0;\n+\tif (adapter->closed) {\n+\t\tret = 0;\n+\t\tgoto out;\n+\t}\n \n \tret = iavf_dev_stop(dev);\n \tadapter->closed = true;\n@@ -2763,6 +2765,7 @@ iavf_dev_close(struct rte_eth_dev *dev)\n \t * the bus master bit will not be disabled, and this call will have no\n \t * effect.\n \t */\n+out:\n \tif (vf->vf_reset && !rte_pci_set_bus_master(pci_dev, true))\n \t\tvf->vf_reset = false;\n \n", "prefixes": [] }