Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113428/?format=api
{ "id": 113428, "url": "http://patches.dpdk.org/api/patches/113428/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220624085951.3177-6-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220624085951.3177-6-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220624085951.3177-6-liudongdong3@huawei.com", "date": "2022-06-24T08:59:50", "name": "[5/6] net/hns3: make code more clean", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "aef39eb7a6361760996a0d5f1fcc73a54abad8a3", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220624085951.3177-6-liudongdong3@huawei.com/mbox/", "series": [ { "id": 23758, "url": "http://patches.dpdk.org/api/series/23758/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23758", "date": "2022-06-24T08:59:45", "name": "some bugfixes for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/23758/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/113428/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/113428/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C332AA0032;\n\tFri, 24 Jun 2022 11:00:57 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BD27F42B75;\n\tFri, 24 Jun 2022 11:00:39 +0200 (CEST)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id 6798D40A89;\n Fri, 24 Jun 2022 11:00:38 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.54])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LTrfn4rdtzDsTR;\n Fri, 24 Jun 2022 17:00:01 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Fri, 24 Jun 2022 17:00:36 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@xilinx.com>,\n <andrew.rybchenko@oktetlabs.ru>, <thomas@monjalon.net>", "CC": "<stable@dpdk.org>, Dongdong Liu <liudongdong3@huawei.com>, Yisen Zhuang\n <yisen.zhuang@huawei.com>", "Subject": "[PATCH 5/6] net/hns3: make code more clean", "Date": "Fri, 24 Jun 2022 16:59:50 +0800", "Message-ID": "<20220624085951.3177-6-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220624085951.3177-1-liudongdong3@huawei.com>", "References": "<20220624085951.3177-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Delete unnecessary code and adjust code to make code more clean.\n\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx.c | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex b48da82b64..4ae07fd91d 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -1904,8 +1904,6 @@ hns3_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t nb_desc,\n \t\trxq->pvid_sw_discard_en = false;\n \trxq->ptype_en = hns3_dev_get_support(hw, RXD_ADV_LAYOUT) ? true : false;\n \trxq->configured = true;\n-\trxq->io_base = (void *)((char *)hw->io_base + HNS3_TQP_REG_OFFSET +\n-\t\t\t\tidx * HNS3_TQP_REG_SIZE);\n \trxq->io_base = (void *)((char *)hw->io_base +\n \t\t\t\t\thns3_get_tqp_reg_offset(idx));\n \trxq->io_head_reg = (volatile void *)((char *)rxq->io_base +\n@@ -2437,10 +2435,8 @@ hns3_recv_pkts_simple(void *rx_queue,\n \n \t\tnmb = hns3_rx_alloc_buffer(rxq);\n \t\tif (unlikely(nmb == NULL)) {\n-\t\t\tuint16_t port_id;\n-\n-\t\t\tport_id = rxq->port_id;\n-\t\t\trte_eth_devices[port_id].data->rx_mbuf_alloc_failed++;\n+\t\t\trte_eth_devices[rxq->port_id].data->\n+\t\t\t\trx_mbuf_alloc_failed++;\n \t\t\tbreak;\n \t\t}\n \n@@ -3865,7 +3861,7 @@ hns3_prep_pkt_proc(struct hns3_tx_queue *tx_queue, struct rte_mbuf *m)\n #endif\n \tif (hns3_pkt_is_tso(m)) {\n \t\tif (hns3_pkt_need_linearized(m, m->nb_segs,\n-\t\t\t\t\t tx_queue->max_non_tso_bd_num) ||\n+\t\t tx_queue->max_non_tso_bd_num) ||\n \t\t hns3_check_tso_pkt_valid(m)) {\n \t\t\trte_errno = EINVAL;\n \t\t\treturn -EINVAL;\n", "prefixes": [ "5/6" ] }