Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113426/?format=api
{ "id": 113426, "url": "http://patches.dpdk.org/api/patches/113426/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220624085951.3177-4-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220624085951.3177-4-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220624085951.3177-4-liudongdong3@huawei.com", "date": "2022-06-24T08:59:48", "name": "[3/6] net/hns3: fix statistic lock", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2dcefa7b1cc7bedc260aba7d74992eefdc77f5e4", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220624085951.3177-4-liudongdong3@huawei.com/mbox/", "series": [ { "id": 23758, "url": "http://patches.dpdk.org/api/series/23758/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23758", "date": "2022-06-24T08:59:45", "name": "some bugfixes for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/23758/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/113426/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/113426/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A5B77A0032;\n\tFri, 24 Jun 2022 11:00:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 431F042823;\n\tFri, 24 Jun 2022 11:00:31 +0200 (CEST)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id 27A1542820;\n Fri, 24 Jun 2022 11:00:29 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.56])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LTrfc1GhdzDsTX;\n Fri, 24 Jun 2022 16:59:52 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Fri, 24 Jun 2022 17:00:27 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@xilinx.com>,\n <andrew.rybchenko@oktetlabs.ru>, <thomas@monjalon.net>", "CC": "<stable@dpdk.org>, Huisong Li <lihuisong@huawei.com>, Dongdong Liu\n <liudongdong3@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>", "Subject": "[PATCH 3/6] net/hns3: fix statistic lock", "Date": "Fri, 24 Jun 2022 16:59:48 +0800", "Message-ID": "<20220624085951.3177-4-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220624085951.3177-1-liudongdong3@huawei.com>", "References": "<20220624085951.3177-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThe stats_lock is used to protect statistics update in stats APIs and\nperiodic task, but current code only protect queue related statistics.\n\nFixes: 1bb6e9073b82 (\"net/hns3: fix MAC and queues hw statistics reversion\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_stats.c | 22 +++++++++-------------\n 1 file changed, 9 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c\nindex 07fad03485..1b0464f3f7 100644\n--- a/drivers/net/hns3/hns3_stats.c\n+++ b/drivers/net/hns3/hns3_stats.c\n@@ -629,6 +629,7 @@ hns3_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *rte_stats)\n \tuint16_t i;\n \tint ret;\n \n+\trte_spinlock_lock(&hw->stats_lock);\n \t/* Update imissed stats */\n \tret = hns3_update_imissed_stats(hw, false);\n \tif (ret) {\n@@ -644,10 +645,7 @@ hns3_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *rte_stats)\n \t\tif (rxq == NULL)\n \t\t\tcontinue;\n \n-\t\trte_spinlock_lock(&hw->stats_lock);\n \t\thns3_rcb_rx_ring_stats_get(rxq, stats);\n-\t\trte_spinlock_unlock(&hw->stats_lock);\n-\n \t\trte_stats->ierrors += rxq->err_stats.l2_errors +\n \t\t\t\t rxq->err_stats.pkt_len_errors;\n \t\trte_stats->ibytes += rxq->basic_stats.bytes;\n@@ -659,9 +657,7 @@ hns3_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *rte_stats)\n \t\tif (txq == NULL)\n \t\t\tcontinue;\n \n-\t\trte_spinlock_lock(&hw->stats_lock);\n \t\thns3_rcb_tx_ring_stats_get(txq, stats);\n-\t\trte_spinlock_unlock(&hw->stats_lock);\n \t\trte_stats->obytes += txq->basic_stats.bytes;\n \t}\n \n@@ -683,7 +679,10 @@ hns3_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *rte_stats)\n \trte_stats->opackets = stats->rcb_tx_ring_pktnum_rcd -\n \t\trte_stats->oerrors;\n \trte_stats->rx_nombuf = eth_dev->data->rx_mbuf_alloc_failed;\n+\n out:\n+\trte_spinlock_unlock(&hw->stats_lock);\n+\n \treturn ret;\n }\n \n@@ -697,6 +696,7 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \tuint16_t i;\n \tint ret;\n \n+\trte_spinlock_lock(&hw->stats_lock);\n \t/*\n \t * Note: Reading hardware statistics of imissed registers will\n \t * clear them.\n@@ -732,7 +732,6 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \t\tif (rxq == NULL)\n \t\t\tcontinue;\n \n-\t\trte_spinlock_lock(&hw->stats_lock);\n \t\tmemset(&rxq->basic_stats, 0,\n \t\t\t\tsizeof(struct hns3_rx_basic_stats));\n \n@@ -740,7 +739,6 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \t\t(void)hns3_read_dev(rxq, HNS3_RING_RX_PKTNUM_RECORD_REG);\n \t\trxq->err_stats.pkt_len_errors = 0;\n \t\trxq->err_stats.l2_errors = 0;\n-\t\trte_spinlock_unlock(&hw->stats_lock);\n \t}\n \n \t/* Clear all the stats of a txq in a loop to keep them synchronized */\n@@ -749,19 +747,18 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \t\tif (txq == NULL)\n \t\t\tcontinue;\n \n-\t\trte_spinlock_lock(&hw->stats_lock);\n \t\tmemset(&txq->basic_stats, 0,\n \t\t\t\tsizeof(struct hns3_tx_basic_stats));\n \n \t\t/* This register is read-clear */\n \t\t(void)hns3_read_dev(txq, HNS3_RING_TX_PKTNUM_RECORD_REG);\n-\t\trte_spinlock_unlock(&hw->stats_lock);\n \t}\n \n-\trte_spinlock_lock(&hw->stats_lock);\n \thns3_tqp_stats_clear(hw);\n-\trte_spinlock_unlock(&hw->stats_lock);\n+\n out:\n+\trte_spinlock_unlock(&hw->stats_lock);\n+\n \treturn ret;\n }\n \n@@ -1082,11 +1079,11 @@ hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \t\t\tcount++;\n \t\t}\n \t}\n-\trte_spinlock_unlock(&hw->stats_lock);\n \n \tret = hns3_update_imissed_stats(hw, false);\n \tif (ret) {\n \t\thns3_err(hw, \"update imissed stats failed, ret = %d\", ret);\n+\t\trte_spinlock_unlock(&hw->stats_lock);\n \t\treturn ret;\n \t}\n \n@@ -1115,7 +1112,6 @@ hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \t\t}\n \t}\n \n-\trte_spinlock_lock(&hw->stats_lock);\n \thns3_tqp_dfx_stats_get(dev, xstats, &count);\n \thns3_queue_stats_get(dev, xstats, &count);\n \trte_spinlock_unlock(&hw->stats_lock);\n", "prefixes": [ "3/6" ] }