Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113356/?format=api
{ "id": 113356, "url": "http://patches.dpdk.org/api/patches/113356/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220623164245.561371-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220623164245.561371-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220623164245.561371-4-bruce.richardson@intel.com", "date": "2022-06-23T16:42:42", "name": "[RFC,3/6] telemetry: use json string function for string outputs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "332e8312bc55dc77067fe7868a939adf977b8d58", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220623164245.561371-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 23739, "url": "http://patches.dpdk.org/api/series/23739/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23739", "date": "2022-06-23T16:42:39", "name": "add json string escaping to telemetry", "version": 1, "mbox": "http://patches.dpdk.org/series/23739/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/113356/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/113356/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6356DA0093;\n\tThu, 23 Jun 2022 18:43:19 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3691E42824;\n\tThu, 23 Jun 2022 18:43:04 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 0270A427ED\n for <dev@dpdk.org>; Thu, 23 Jun 2022 18:43:00 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jun 2022 09:43:00 -0700", "from silpixa00401385.ir.intel.com (HELO\n silpixa00401385.ger.corp.intel.com.) ([10.237.223.125])\n by fmsmga005.fm.intel.com with ESMTP; 23 Jun 2022 09:42:59 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1656002581; x=1687538581;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=TeOUnYCpYeTAYv70jBTxhM9hwZjqFuPDJh+53UbReAY=;\n b=TSfZRRh7gqDzG6VkmkCu26uGoJRoL6mMRa6URHRqlfnqFW5+qzAk1xcw\n YkvTr8hKGYBRBWmJmRittJyUFvLvkny2CKW4rvxeZVboooAUUP+N93TlX\n cADIYtwZGSy40DF/L1RosYOpZ3rACKJO7ZudeuBvNCcP7l2K8FM5lYyu1\n tCGs+9e/SAllMUzePDmLhesqyzOK0fbbFGBlZdWqjoisafTgh33vGuaEc\n UeencYZPkCnHVDhdBGG0zp5CDhMRa3L74Xn0Jwe60MK6+8SUS+bJ8tz+D\n x23PVMLrXk0wZSYd4qZ60UpGP5sYBClN6Lf7q9gC26JCWBpLmgvLvfPtZ g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10386\"; a=\"260589088\"", "E=Sophos;i=\"5.92,216,1650956400\"; d=\"scan'208\";a=\"260589088\"", "E=Sophos;i=\"5.92,216,1650956400\"; d=\"scan'208\";a=\"915267934\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "ciara.power@intel.com, fengchengwen@huawei.com, mb@smartsharesystems.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[RFC PATCH 3/6] telemetry: use json string function for string\n outputs", "Date": "Thu, 23 Jun 2022 17:42:42 +0100", "Message-Id": "<20220623164245.561371-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220623164245.561371-1-bruce.richardson@intel.com>", "References": "<20220623164245.561371-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When returning just a string in response to a query, use the proper json\nstring printing function to escape characters rather than just snprintf.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/telemetry/telemetry.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex c6fd03a5ab..7188b1905c 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -232,9 +232,14 @@ output_json(const char *cmd, const struct rte_tel_data *d, int s)\n \t\t\t\tMAX_CMD_LEN, cmd ? cmd : \"none\");\n \t\tbreak;\n \tcase RTE_TEL_STRING:\n-\t\tused = snprintf(out_buf, sizeof(out_buf), \"{\\\"%.*s\\\":\\\"%.*s\\\"}\",\n-\t\t\t\tMAX_CMD_LEN, cmd,\n-\t\t\t\tRTE_TEL_MAX_SINGLE_STRING_LEN, d->data.str);\n+\t\tprefix_used = snprintf(out_buf, sizeof(out_buf), \"{\\\"%.*s\\\":\",\n+\t\t\t\tMAX_CMD_LEN, cmd);\n+\t\tcb_data_buf = &out_buf[prefix_used];\n+\t\tbuf_len = sizeof(out_buf) - prefix_used - 1; /* space for '}' */\n+\n+\t\tused = rte_tel_json_str(cb_data_buf, buf_len, 0, d->data.str);\n+\t\tused += prefix_used;\n+\t\tused += strlcat(out_buf + used, \"}\", sizeof(out_buf) - used);\n \t\tbreak;\n \tcase RTE_TEL_DICT:\n \t\tprefix_used = snprintf(out_buf, sizeof(out_buf), \"{\\\"%.*s\\\":\",\n", "prefixes": [ "RFC", "3/6" ] }