Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/11307/?format=api
{ "id": 11307, "url": "http://patches.dpdk.org/api/patches/11307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1457540381-20274-12-git-send-email-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1457540381-20274-12-git-send-email-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1457540381-20274-12-git-send-email-olivier.matz@6wind.com", "date": "2016-03-09T16:19:17", "name": "[dpdk-dev,RFC,11/35] mempool: use the list to audit all elements", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "279a8f136ae2ae8388dda9cc3afd702e2385792b", "submitter": { "id": 8, "url": "http://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1457540381-20274-12-git-send-email-olivier.matz@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/11307/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/11307/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E5324568F;\n\tWed, 9 Mar 2016 17:22:30 +0100 (CET)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id D7B7737AA\n\tfor <dev@dpdk.org>; Wed, 9 Mar 2016 17:22:14 +0100 (CET)", "from glumotte.dev.6wind.com (unknown [10.16.0.195])\n\tby proxy.6wind.com (Postfix) with ESMTP id CC27524A4A\n\tfor <dev@dpdk.org>; Wed, 9 Mar 2016 17:21:31 +0100 (CET)" ], "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 9 Mar 2016 17:19:17 +0100", "Message-Id": "<1457540381-20274-12-git-send-email-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1457540381-20274-1-git-send-email-olivier.matz@6wind.com>", "References": "<1457540381-20274-1-git-send-email-olivier.matz@6wind.com>", "Subject": "[dpdk-dev] [RFC 11/35] mempool: use the list to audit all elements", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use the new rte_mempool_obj_iter() instead the old rte_mempool_obj_iter()\nto iterate among objects to audit them (check for cookies).\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n lib/librte_mempool/rte_mempool.c | 42 +++++++---------------------------------\n 1 file changed, 7 insertions(+), 35 deletions(-)", "diff": "diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex 0f7c41f..a9af2fc 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -720,12 +720,6 @@ rte_mempool_dump_cache(FILE *f, const struct rte_mempool *mp)\n #pragma GCC diagnostic ignored \"-Wcast-qual\"\n #endif\n \n-struct mempool_audit_arg {\n-\tconst struct rte_mempool *mp;\n-\tuintptr_t obj_end;\n-\tuint32_t obj_num;\n-};\n-\n /* check and update cookies or panic (internal) */\n void __mempool_check_cookies(const struct rte_mempool *mp,\n \tvoid * const *obj_table_const, unsigned n, int free)\n@@ -795,45 +789,23 @@ void __mempool_check_cookies(const struct rte_mempool *mp,\n }\n \n static void\n-mempool_obj_audit(void *arg, void *start, void *end, uint32_t idx)\n+mempool_obj_audit(struct rte_mempool *mp, __rte_unused void *opaque,\n+\tvoid *obj, __rte_unused unsigned idx)\n {\n-\tstruct mempool_audit_arg *pa = arg;\n-\tvoid *obj;\n-\n-\tobj = (char *)start + pa->mp->header_size;\n-\tpa->obj_end = (uintptr_t)end;\n-\tpa->obj_num = idx + 1;\n-\t__mempool_check_cookies(pa->mp, &obj, 1, 2);\n+\t__mempool_check_cookies(mp, &obj, 1, 2);\n }\n \n static void\n mempool_audit_cookies(const struct rte_mempool *mp)\n {\n-\tuint32_t elt_sz, num;\n-\tstruct mempool_audit_arg arg;\n-\n-\telt_sz = mp->elt_size + mp->header_size + mp->trailer_size;\n-\n-\targ.mp = mp;\n-\targ.obj_end = mp->elt_va_start;\n-\targ.obj_num = 0;\n-\n-\tnum = rte_mempool_obj_mem_iter((void *)mp->elt_va_start,\n-\t\tmp->size, elt_sz, 1,\n-\t\tmp->elt_pa, mp->pg_num, mp->pg_shift,\n-\t\tmempool_obj_audit, &arg);\n+\tunsigned num;\n \n+\tnum = rte_mempool_obj_iter(RTE_DECONST(void *, mp),\n+\t\tmempool_obj_audit, NULL);\n \tif (num != mp->size) {\n-\t\t\trte_panic(\"rte_mempool_obj_iter(mempool=%p, size=%u) \"\n+\t\trte_panic(\"rte_mempool_obj_iter(mempool=%p, size=%u) \"\n \t\t\t\"iterated only over %u elements\\n\",\n \t\t\tmp, mp->size, num);\n-\t} else if (arg.obj_end != mp->elt_va_end || arg.obj_num != mp->size) {\n-\t\t\trte_panic(\"rte_mempool_obj_iter(mempool=%p, size=%u) \"\n-\t\t\t\"last callback va_end: %#tx (%#tx expeceted), \"\n-\t\t\t\"num of objects: %u (%u expected)\\n\",\n-\t\t\tmp, mp->size,\n-\t\t\targ.obj_end, mp->elt_va_end,\n-\t\t\targ.obj_num, mp->size);\n \t}\n }\n \n", "prefixes": [ "dpdk-dev", "RFC", "11/35" ] }