Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 112996,
    "url": "http://patches.dpdk.org/api/patches/112996/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220617100217.3356870-2-vfialko@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220617100217.3356870-2-vfialko@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220617100217.3356870-2-vfialko@marvell.com",
    "date": "2022-06-17T10:02:16",
    "name": "[1/2] app/eventdev: add null checks for cop allocations",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "8ede1675a1e148fb8bbab8fd5b39b881468c974e",
    "submitter": {
        "id": 2390,
        "url": "http://patches.dpdk.org/api/people/2390/?format=api",
        "name": "Volodymyr Fialko",
        "email": "vfialko@marvell.com"
    },
    "delegate": {
        "id": 310,
        "url": "http://patches.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220617100217.3356870-2-vfialko@marvell.com/mbox/",
    "series": [
        {
            "id": 23609,
            "url": "http://patches.dpdk.org/api/series/23609/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23609",
            "date": "2022-06-17T10:02:15",
            "name": "app/eventdev: fix issues with cop alloc and qp size",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/23609/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/112996/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/112996/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4CACAA0093;\n\tFri, 17 Jun 2022 12:02:33 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A088A41141;\n\tFri, 17 Jun 2022 12:02:30 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 005BD410FC\n for <dev@dpdk.org>; Fri, 17 Jun 2022 12:02:28 +0200 (CEST)",
            "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 25H3k8sc020527\n for <dev@dpdk.org>; Fri, 17 Jun 2022 03:02:28 -0700",
            "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3grj05s96e-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 17 Jun 2022 03:02:28 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Fri, 17 Jun 2022 03:02:26 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Fri, 17 Jun 2022 03:02:26 -0700",
            "from localhost.localdomain (unknown [10.28.34.39])\n by maili.marvell.com (Postfix) with ESMTP id 93E5E3F7086;\n Fri, 17 Jun 2022 03:02:24 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=bz/YhJFtC4Gs9Bt+cEMHcI/VlYe56yBJ6djOzSOWhb8=;\n b=WId3FFrzT5nchsLrS2HsgGVed7wA4Z59VxLUgXqoz5qlq2+0rj/Crp4+gSgVMm5QBqo1\n +txrI3FTN27QF7Xx3Nv7uz6qq2Xl6ariLYPUa6UqmWODa8Cv+bHuc4OOe4SU9Rts7LCw\n SqwIMLER01uZdqZFEjZ3UAcs76Z2kkycEmikIffM1q1zxTWDu0oVMXjLHpJPXrP5PfTw\n nJODREwPc5B1e4AktKrUaUcDND9xhGVI6ZvjU/vPIAjjRrCBG5Fkf1m9VUKzh1m8R8NB\n BF0XzXnwxWazKqyfyuFHmr6DQaRpsX/AX3i//7bn8TKFH5GGwtqq9GYyvLpnalD57dG7 rQ==",
        "From": "Volodymyr Fialko <vfialko@marvell.com>",
        "To": "<dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>",
        "CC": "<anoobj@marvell.com>, Volodymyr Fialko <vfialko@marvell.com>",
        "Subject": "[PATCH 1/2] app/eventdev: add null checks for cop allocations",
        "Date": "Fri, 17 Jun 2022 12:02:16 +0200",
        "Message-ID": "<20220617100217.3356870-2-vfialko@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20220617100217.3356870-1-vfialko@marvell.com>",
        "References": "<20220617100217.3356870-1-vfialko@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-GUID": "JLrOxDQhAczrwD7-N2rIOhuPTQwz59dQ",
        "X-Proofpoint-ORIG-GUID": "JLrOxDQhAczrwD7-N2rIOhuPTQwz59dQ",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.64.514\n definitions=2022-06-17_08,2022-06-16_01,2022-02-23_01",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Crypto operation allocation may fail in case when total size of queue\npairs is bigger then pool size.\n\nSigned-off-by: Volodymyr Fialko <vfialko@marvell.com>\n---\n app/test-eventdev/test_perf_common.c | 40 ++++++++++++++++++++++++++--\n 1 file changed, 38 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c\nindex b41785492e..a5e031873d 100644\n--- a/app/test-eventdev/test_perf_common.c\n+++ b/app/test-eventdev/test_perf_common.c\n@@ -367,6 +367,7 @@ crypto_adapter_enq_op_new(struct prod_data *p)\n \tstruct evt_options *opt = t->opt;\n \tuint16_t qp_id = p->ca.cdev_qp_id;\n \tuint8_t cdev_id = p->ca.cdev_id;\n+\tuint64_t alloc_failures = 0;\n \tuint32_t flow_counter = 0;\n \tstruct rte_crypto_op *op;\n \tstruct rte_mbuf *m;\n@@ -386,9 +387,17 @@ crypto_adapter_enq_op_new(struct prod_data *p)\n \n \t\t\top = rte_crypto_op_alloc(t->ca_op_pool,\n \t\t\t\t\t RTE_CRYPTO_OP_TYPE_SYMMETRIC);\n+\t\t\tif (unlikely(op == NULL)) {\n+\t\t\t\talloc_failures++;\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\n \t\t\tm = rte_pktmbuf_alloc(pool);\n-\t\t\tif (m == NULL)\n+\t\t\tif (unlikely(m == NULL)) {\n+\t\t\t\talloc_failures++;\n+\t\t\t\trte_crypto_op_free(op);\n \t\t\t\tcontinue;\n+\t\t\t}\n \n \t\t\trte_pktmbuf_append(m, len);\n \t\t\tsym_op = op->sym;\n@@ -404,6 +413,11 @@ crypto_adapter_enq_op_new(struct prod_data *p)\n \n \t\t\top = rte_crypto_op_alloc(t->ca_op_pool,\n \t\t\t\t\t RTE_CRYPTO_OP_TYPE_ASYMMETRIC);\n+\t\t\tif (unlikely(op == NULL)) {\n+\t\t\t\talloc_failures++;\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\n \t\t\tasym_op = op->asym;\n \t\t\tasym_op->modex.base.data = modex_test_case.base.data;\n \t\t\tasym_op->modex.base.length = modex_test_case.base.len;\n@@ -418,6 +432,10 @@ crypto_adapter_enq_op_new(struct prod_data *p)\n \n \t\tcount++;\n \t}\n+\n+\tif (opt->verbose_level > 1 && alloc_failures)\n+\t\tprintf(\"%s(): lcore %d allocation failures: %\"PRIu64\"\\n\",\n+\t\t       __func__, rte_lcore_id(), alloc_failures);\n }\n \n static inline void\n@@ -430,6 +448,7 @@ crypto_adapter_enq_op_fwd(struct prod_data *p)\n \tconst uint64_t nb_pkts = t->nb_pkts;\n \tstruct rte_mempool *pool = t->pool;\n \tstruct evt_options *opt = t->opt;\n+\tuint64_t alloc_failures = 0;\n \tuint32_t flow_counter = 0;\n \tstruct rte_crypto_op *op;\n \tstruct rte_event ev;\n@@ -455,9 +474,17 @@ crypto_adapter_enq_op_fwd(struct prod_data *p)\n \n \t\t\top = rte_crypto_op_alloc(t->ca_op_pool,\n \t\t\t\t\t RTE_CRYPTO_OP_TYPE_SYMMETRIC);\n+\t\t\tif (unlikely(op == NULL)) {\n+\t\t\t\talloc_failures++;\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\n \t\t\tm = rte_pktmbuf_alloc(pool);\n-\t\t\tif (m == NULL)\n+\t\t\tif (unlikely(m == NULL)) {\n+\t\t\t\talloc_failures++;\n+\t\t\t\trte_crypto_op_free(op);\n \t\t\t\tcontinue;\n+\t\t\t}\n \n \t\t\trte_pktmbuf_append(m, len);\n \t\t\tsym_op = op->sym;\n@@ -473,6 +500,11 @@ crypto_adapter_enq_op_fwd(struct prod_data *p)\n \n \t\t\top = rte_crypto_op_alloc(t->ca_op_pool,\n \t\t\t\t\t RTE_CRYPTO_OP_TYPE_ASYMMETRIC);\n+\t\t\tif (unlikely(op == NULL)) {\n+\t\t\t\talloc_failures++;\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\n \t\t\tasym_op = op->asym;\n \t\t\tasym_op->modex.base.data = modex_test_case.base.data;\n \t\t\tasym_op->modex.base.length = modex_test_case.base.len;\n@@ -489,6 +521,10 @@ crypto_adapter_enq_op_fwd(struct prod_data *p)\n \n \t\tcount++;\n \t}\n+\n+\tif (opt->verbose_level > 1 && alloc_failures)\n+\t\tprintf(\"%s(): lcore %d allocation failures: %\"PRIu64\"\\n\",\n+\t\t       __func__, rte_lcore_id(), alloc_failures);\n }\n \n static inline int\n",
    "prefixes": [
        "1/2"
    ]
}