Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112885/?format=api
{ "id": 112885, "url": "http://patches.dpdk.org/api/patches/112885/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220616094122.1909-5-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220616094122.1909-5-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220616094122.1909-5-fengchengwen@huawei.com", "date": "2022-06-16T09:41:22", "name": "[v8,4/4] net/bnxt: notify applications about device reset/recovery", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "8b4cbd754088bb2c6bf1ed80f03e78aa99a2892b", "submitter": { "id": 2146, "url": "http://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220616094122.1909-5-fengchengwen@huawei.com/mbox/", "series": [ { "id": 23570, "url": "http://patches.dpdk.org/api/series/23570/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23570", "date": "2022-06-16T09:41:18", "name": "ethdev: support error recovery notification", "version": 8, "mbox": "http://patches.dpdk.org/series/23570/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112885/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112885/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2F87EA00BE;\n\tThu, 16 Jun 2022 11:48:03 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E6D9F42C1E;\n\tThu, 16 Jun 2022 11:47:55 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 7746342C13\n for <dev@dpdk.org>; Thu, 16 Jun 2022 11:47:52 +0200 (CEST)", "from dggpeml500024.china.huawei.com (unknown [172.30.72.57])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LNy3t4bqdzjYC2;\n Thu, 16 Jun 2022 17:46:18 +0800 (CST)", "from localhost.localdomain (10.67.165.24) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Thu, 16 Jun 2022 17:47:50 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@xilinx.com>", "CC": "<dev@dpdk.org>, <kalesh-anakkur.purayil@broadcom.com>,\n <somnath.kotur@broadcom.com>, <ajit.khaparde@broadcom.com>, <mdr@ashroe.eu>,\n <Andrew.Rybchenko@oktetlabs.ru>", "Subject": "[PATCH v8 4/4] net/bnxt: notify applications about device\n reset/recovery", "Date": "Thu, 16 Jun 2022 17:41:22 +0800", "Message-ID": "<20220616094122.1909-5-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220616094122.1909-1-fengchengwen@huawei.com>", "References": "<20220128124830.427-1-kalesh-anakkur.purayil@broadcom.com>\n <20220616094122.1909-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.24]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nWhen the driver receives RESET_NOTIFY async event from FW or detects\nan error condition, it should update the application that FW is going\nto reset. Once the driver recovers from the reset, update the reset\nrecovery status to application as well.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/bnxt/bnxt_cpr.c | 4 ++++\n drivers/net/bnxt/bnxt_ethdev.c | 11 ++++++++++-\n 2 files changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 99af0f9e87..5bb376d4d5 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -180,6 +180,10 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \t\t\treturn;\n \t\t}\n \n+\t\trte_eth_dev_callback_process(bp->eth_dev,\n+\t\t\t\t\t RTE_ETH_EVENT_ERR_RECOVERING,\n+\t\t\t\t\t NULL);\n+\n \t\tpthread_mutex_lock(&bp->err_recovery_lock);\n \t\tevent_data = data1;\n \t\t/* timestamp_lo/hi values are in units of 100ms */\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 0f0f40b95b..cc02951d95 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4397,13 +4397,18 @@ static void bnxt_dev_recover(void *arg)\n \tPMD_DRV_LOG(INFO, \"Port: %u Recovered from FW reset\\n\",\n \t\t bp->eth_dev->data->port_id);\n \tpthread_mutex_unlock(&bp->err_recovery_lock);\n-\n+\trte_eth_dev_callback_process(bp->eth_dev,\n+\t\t\t\t RTE_ETH_EVENT_RECOVER_SUCCESS,\n+\t\t\t\t NULL);\n \treturn;\n err_start:\n \tbnxt_dev_stop(bp->eth_dev);\n err:\n \tbp->flags |= BNXT_FLAG_FATAL_ERROR;\n \tbnxt_uninit_resources(bp, false);\n+\trte_eth_dev_callback_process(bp->eth_dev,\n+\t\t\t\t RTE_ETH_EVENT_RECOVER_FAILED,\n+\t\t\t\t NULL);\n \tif (bp->eth_dev->data->dev_conf.intr_conf.rmv)\n \t\trte_eth_dev_callback_process(bp->eth_dev,\n \t\t\t\t\t RTE_ETH_EVENT_INTR_RMV,\n@@ -4575,6 +4580,10 @@ static void bnxt_check_fw_health(void *arg)\n \n \tPMD_DRV_LOG(ERR, \"Detected FW dead condition\\n\");\n \n+\trte_eth_dev_callback_process(bp->eth_dev,\n+\t\t\t\t RTE_ETH_EVENT_ERR_RECOVERING,\n+\t\t\t\t NULL);\n+\n \tif (bnxt_is_primary_func(bp))\n \t\twait_msec = info->primary_func_wait_period;\n \telse\n", "prefixes": [ "v8", "4/4" ] }