Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112841/?format=api
{ "id": 112841, "url": "http://patches.dpdk.org/api/patches/112841/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220616070743.30658-6-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220616070743.30658-6-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220616070743.30658-6-ndabilpuram@marvell.com", "date": "2022-06-16T07:07:37", "name": "[06/12] common/cnxk: fix mbox structs to avoid unaligned access", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "f1962cac916d8ee7099583cb03f429cf95b36bb3", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220616070743.30658-6-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 23552, "url": "http://patches.dpdk.org/api/series/23552/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23552", "date": "2022-06-16T07:07:32", "name": "[01/12] common/cnxk: use computed value for wqe skip", "version": 1, "mbox": "http://patches.dpdk.org/series/23552/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112841/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112841/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 54B83A00C3;\n\tThu, 16 Jun 2022 09:10:17 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 94B5D42BEB;\n\tThu, 16 Jun 2022 09:10:10 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 3693042BEA\n for <dev@dpdk.org>; Thu, 16 Jun 2022 09:10:09 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 25G2AMm1013083\n for <dev@dpdk.org>; Thu, 16 Jun 2022 00:10:08 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gq83yx522-5\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 16 Jun 2022 00:10:08 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Thu, 16 Jun 2022 00:09:46 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Thu, 16 Jun 2022 00:09:46 -0700", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id BA3053F709B;\n Thu, 16 Jun 2022 00:09:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=rcjGjLBSW5jrhgNpPdaQPcpBePgmci2c3u/OKIum7kk=;\n b=P5D5+Hl1GZCjpiw2vULrYMeSV2dLXE/IUl17qPo2Z3RYlFoNPomL/EZloFLefrTLkcIK\n IMJ5DiRGPqt3JIlL8kfOeDl0aD0Ne/eKPFliaFiF2fSntKWg9eaUTFSL5u+oo37bZkdn\n Ui43EN0beIPu8693fFsbPjFYrJ/33I7gFN7vaLBz6vROTlVNfOXhWhS6YT7RFumTRcud\n XPdt7rJ4eLhWzPrkh+fA/qOmUYsFG0ooUHUzRjylOLa8KhZuFWUz8UPwkNBQoQHKGsfA\n mf8YPznbqnW/Cd2s5KcyuMx26S2wTnsQbn8oUZkrfYgaMdBDPY8M9g+ysWDJd9B83jN9 /w==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 06/12] common/cnxk: fix mbox structs to avoid unaligned access", "Date": "Thu, 16 Jun 2022 12:37:37 +0530", "Message-ID": "<20220616070743.30658-6-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20220616070743.30658-1-ndabilpuram@marvell.com>", "References": "<20220616070743.30658-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "bQmNmt8J-JDKj7GpBKQ9W7WddISmpmSe", "X-Proofpoint-GUID": "bQmNmt8J-JDKj7GpBKQ9W7WddISmpmSe", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514\n definitions=2022-06-16_03,2022-06-15_01,2022-02-23_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix mbox structs to avoid unaligned access as mbox memory\nis from BAR space.\n\nFixes: 503b82de2cbf (\"common/cnxk: add mbox request and response definitions\")\nFixes: e746aec161cc (\"common/cnxk: fix SQ flush sequence\")\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n drivers/common/cnxk/roc_mbox.h | 18 +++++++++---------\n drivers/common/cnxk/roc_nix_inl.c | 2 ++\n 2 files changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h\nindex 2c30f19..965c704 100644\n--- a/drivers/common/cnxk/roc_mbox.h\n+++ b/drivers/common/cnxk/roc_mbox.h\n@@ -777,7 +777,7 @@ struct nix_lf_alloc_req {\n \tuint64_t __io way_mask;\n #define NIX_LF_RSS_TAG_LSB_AS_ADDER BIT_ULL(0)\n #define NIX_LF_LBK_BLK_SEL\t BIT_ULL(1)\n-\tuint64_t flags;\n+\tuint64_t __io flags;\n };\n \n struct nix_lf_alloc_rsp {\n@@ -798,7 +798,7 @@ struct nix_lf_alloc_rsp {\n \tuint8_t __io cgx_links;\t /* No. of CGX links present in HW */\n \tuint8_t __io lbk_links;\t /* No. of LBK links present in HW */\n \tuint8_t __io sdp_links;\t /* No. of SDP links present in HW */\n-\tuint8_t tx_link;\t /* Transmit channel link number */\n+\tuint8_t __io tx_link;\t /* Transmit channel link number */\n };\n \n struct nix_lf_free_req {\n@@ -1275,8 +1275,8 @@ struct ssow_lf_free_req {\n #define SSOW_INVAL_SELECTIVE_VER 0x1000\n struct ssow_lf_inv_req {\n \tstruct mbox_msghdr hdr;\n-\tuint16_t nb_hws;\t\t /* Number of HWS to invalidate*/\n-\tuint16_t hws[MAX_RVU_BLKLF_CNT]; /* Array of HWS */\n+\tuint16_t __io nb_hws;\t\t /* Number of HWS to invalidate*/\n+\tuint16_t __io hws[MAX_RVU_BLKLF_CNT]; /* Array of HWS */\n };\n \n struct ssow_config_lsw {\n@@ -1453,11 +1453,11 @@ struct cpt_sts_rsp {\n struct cpt_rxc_time_cfg_req {\n \tstruct mbox_msghdr hdr;\n \tint blkaddr;\n-\tuint32_t step;\n-\tuint16_t zombie_thres;\n-\tuint16_t zombie_limit;\n-\tuint16_t active_thres;\n-\tuint16_t active_limit;\n+\tuint32_t __io step;\n+\tuint16_t __io zombie_thres;\n+\tuint16_t __io zombie_limit;\n+\tuint16_t __io active_thres;\n+\tuint16_t __io active_limit;\n };\n \n struct cpt_rx_inline_lf_cfg_msg {\ndiff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c\nindex 39b9bec..7da8938 100644\n--- a/drivers/common/cnxk/roc_nix_inl.c\n+++ b/drivers/common/cnxk/roc_nix_inl.c\n@@ -246,6 +246,8 @@ roc_nix_reassembly_configure(uint32_t max_wait_time, uint16_t max_frags)\n \tstruct roc_cpt_rxc_time_cfg cfg;\n \n \tPLT_SET_USED(max_frags);\n+\tif (idev == NULL)\n+\t\treturn -ENOTSUP;\n \troc_cpt = idev->cpt;\n \tif (!roc_cpt) {\n \t\tplt_err(\"Cannot support inline inbound, cryptodev not probed\");\n", "prefixes": [ "06/12" ] }