Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112723/?format=api
{ "id": 112723, "url": "http://patches.dpdk.org/api/patches/112723/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220614122904.159946-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220614122904.159946-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220614122904.159946-2-bruce.richardson@intel.com", "date": "2022-06-14T12:29:03", "name": "[1/2] examples/l3fwd: add include for macro definition", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9ab9fe9be728ec2b8f8238f66c6f1a4702e86993", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220614122904.159946-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 23518, "url": "http://patches.dpdk.org/api/series/23518/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23518", "date": "2022-06-14T12:29:02", "name": "add includes to help when editing in Eclipse", "version": 1, "mbox": "http://patches.dpdk.org/series/23518/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112723/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112723/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 093DBA0093;\n\tTue, 14 Jun 2022 14:29:20 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EB05542802;\n\tTue, 14 Jun 2022 14:29:19 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id C4C814069C\n for <dev@dpdk.org>; Tue, 14 Jun 2022 14:29:18 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Jun 2022 05:29:17 -0700", "from silpixa00401385.ir.intel.com (HELO\n silpixa00401385.ger.corp.intel.com.) ([10.237.223.181])\n by orsmga001.jf.intel.com with ESMTP; 14 Jun 2022 05:29:16 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1655209758; x=1686745758;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=TtFC1tHZZDNFRPKShA+GIeLVdkbHGJeHMwBq7lHI0Vk=;\n b=SQSlyY0GBltRzU9WW0eNSYs78KTBYMksznbX0oOr6Dogz51jg0RvNiio\n OZ9yBRI8KoZIbsOV9PoYq65DndDUfr61KyAOsdj22QNVlgWEtNOKf1Gp3\n /QwOKov5As4l3ekpu0Wrx6FZySfVdPD+Byd4XO52/iZLfs45r/wQfjuZq\n c0OzXS3lrsY/Ahb921Q6ne2YiBHdsckCATudvorj4o0MDSl/IDlWBdm1r\n v2iFtQgfvstzzyw2rP56bBpK7quQpTG91uMRB5LmW1VfwNanoDym9Pv2/\n Ou8SF0DQY6wDBpV3U03LKhFimH6m/vjbREGUMEcqYXErqgCG3c7LJQ+i2 g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10377\"; a=\"258437303\"", "E=Sophos;i=\"5.91,300,1647327600\"; d=\"scan'208\";a=\"258437303\"", "E=Sophos;i=\"5.91,300,1647327600\"; d=\"scan'208\";a=\"617977180\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 1/2] examples/l3fwd: add include for macro definition", "Date": "Tue, 14 Jun 2022 13:29:03 +0100", "Message-Id": "<20220614122904.159946-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220614122904.159946-1-bruce.richardson@intel.com>", "References": "<20220614122904.159946-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The header files \"l3fwd_em.h\" and \"l3fwd_em_sequential.h\" use the\n\"__rte_always_inline\" macro but don't directly include \"rte_common.h\" to\nget the definition of it. This inclusion is not necessary for\ncompilation, but the lack of it can confuse some indexers - such as\nthose in eclipse, which reports the lines:\n\n\"static __rte_always_inline uint16_t\"\n\nas possible definitions of a variable called \"uint16_t\". This confusion\nleads to uint16_t being flagged as an unknown type in all other parts of\nthe project being indexed, e.g. across all of DPDK code.\n\nAdding in the include of rte_common.h makes it clear to the indexer that\nthose lines are part of a function definition, and that allows eclipse\nto correctly recognise uint16_t as a type from stdint.h\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/l3fwd/l3fwd_em.h | 2 ++\n examples/l3fwd/l3fwd_em_sequential.h | 2 ++\n 2 files changed, 4 insertions(+)", "diff": "diff --git a/examples/l3fwd/l3fwd_em.h b/examples/l3fwd/l3fwd_em.h\nindex 11bd951858..fe2ee59f6a 100644\n--- a/examples/l3fwd/l3fwd_em.h\n+++ b/examples/l3fwd/l3fwd_em.h\n@@ -5,6 +5,8 @@\n #ifndef __L3FWD_EM_H__\n #define __L3FWD_EM_H__\n \n+#include <rte_common.h>\n+\n static __rte_always_inline uint16_t\n l3fwd_em_handle_ipv4(struct rte_mbuf *m, uint16_t portid,\n \t\t struct rte_ether_hdr *eth_hdr, struct lcore_conf *qconf)\ndiff --git a/examples/l3fwd/l3fwd_em_sequential.h b/examples/l3fwd/l3fwd_em_sequential.h\nindex f426c508ef..d2f75edb8a 100644\n--- a/examples/l3fwd/l3fwd_em_sequential.h\n+++ b/examples/l3fwd/l3fwd_em_sequential.h\n@@ -5,6 +5,8 @@\n #ifndef __L3FWD_EM_SEQUENTIAL_H__\n #define __L3FWD_EM_SEQUENTIAL_H__\n \n+#include <rte_common.h>\n+\n /**\n * @file\n * This is an optional implementation of packet classification in Exact-Match\n", "prefixes": [ "1/2" ] }